From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Saravanan Sekar <sravanhome@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
Sebastian Reichel <sre@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v9 0/6] Add battery charger driver support for MP2629
Date: Wed, 15 Apr 2020 19:40:58 +0300 [thread overview]
Message-ID: <CAHp75VerGG0_J+fHrZfwJRa3EHtGuz-pJbD7zwoXN2jfO7dszA@mail.gmail.com> (raw)
In-Reply-To: <20200415162030.16414-1-sravanhome@gmail.com>
On Wed, Apr 15, 2020 at 7:20 PM Saravanan Sekar <sravanhome@gmail.com> wrote:
>
> changes in v9:
> - fixed review comments in mp2629 power supply such as resource based
> iio channel, replace workqueue by threaded irq, irq get with "_optional"
>
May I ask you why you are ignoring my tag?
If you don't want to have your patches reviewed / applied, just don't send them.
> changes in v8:
> - fixed order of call in probe/remove in iio adc
> - add ABI documentation for mp2629 power supply
>
> changes in v7:
> - fixed probe/remove order, managed and unmanaged call mix use in adc.
> - Documentation dual license, i2c node with controller address
>
> Overall looks good to me, FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> One question though in reply to patch 4.
>
> changes in v6:
> - removed includes types.h in mfd, of_device.h in adc.
> - fixed review comments parentheses, err check, kstrtouint
>
> changes in v5:
> - removed platfrom data stored in mfd and directly accessed mfd struct in child
> - fixed spell check and capitalization in mfd and documentation
>
> changes in v4:
> - fixed capitalization in mfg Kconfig and documentation
>
> changes in v3:
> - regmap for children passed using platform data and remove mfd driver info
> access directly from children
>
> changes in v2:
> - removed EXPORT_SYMBOL of register set/get helper
> - regmap bit filed used, fixed other review comments
>
> This patch series add support for Battery charger control driver for Monolithic
> Power System's MP2629 chipset, includes MFD driver for ADC battery & input
> power supply measurement and battery charger control driver.
>
> Thanks,
> Saravanan
>
> Saravanan Sekar (6):
> dt-bindings: mfd: add document bindings for mp2629
> mfd: mp2629: Add support for mps battery charger
> iio: adc: mp2629: Add support for mp2629 ADC driver
> power: supply: Add support for mps mp2629 battery charger
> power: supply: mp2629: Add impedance compenstation config
> MAINTAINERS: Add entry for mp2629 Battery Charger driver
>
> .../ABI/testing/sysfs-class-power-mp2629 | 8 +
> .../devicetree/bindings/mfd/mps,mp2629.yaml | 60 ++
> MAINTAINERS | 5 +
> drivers/iio/adc/Kconfig | 10 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/mp2629_adc.c | 208 ++++++
> drivers/mfd/Kconfig | 9 +
> drivers/mfd/Makefile | 2 +
> drivers/mfd/mp2629.c | 86 +++
> drivers/power/supply/Kconfig | 10 +
> drivers/power/supply/Makefile | 1 +
> drivers/power/supply/mp2629_charger.c | 667 ++++++++++++++++++
> include/linux/mfd/mp2629.h | 28 +
> 13 files changed, 1095 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-class-power-mp2629
> create mode 100644 Documentation/devicetree/bindings/mfd/mps,mp2629.yaml
> create mode 100644 drivers/iio/adc/mp2629_adc.c
> create mode 100644 drivers/mfd/mp2629.c
> create mode 100644 drivers/power/supply/mp2629_charger.c
> create mode 100644 include/linux/mfd/mp2629.h
>
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-15 16:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 16:20 [PATCH v9 0/6] Add battery charger driver support for MP2629 Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 1/6] dt-bindings: mfd: add document bindings for mp2629 Saravanan Sekar
2020-04-16 20:44 ` Rob Herring
2020-04-15 16:20 ` [PATCH v9 2/6] mfd: mp2629: Add support for mps battery charger Saravanan Sekar
2020-04-24 7:18 ` Lee Jones
2020-04-24 7:26 ` saravanan sekar
2020-04-24 9:37 ` Lee Jones
2020-04-24 10:23 ` saravanan sekar
2020-04-24 10:53 ` Lee Jones
2020-04-24 11:04 ` saravanan sekar
2020-04-27 8:51 ` Lee Jones
2020-04-27 9:30 ` saravanan sekar
2020-04-30 10:39 ` saravanan sekar
2020-04-30 11:07 ` Andy Shevchenko
2020-04-27 7:26 ` Lee Jones
2020-04-15 16:20 ` [PATCH v9 3/6] iio: adc: mp2629: Add support for mp2629 ADC driver Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 4/6] power: supply: Add support for mps mp2629 battery charger Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 5/6] power: supply: mp2629: Add impedance compenstation config Saravanan Sekar
2020-04-15 16:20 ` [PATCH v9 6/6] MAINTAINERS: Add entry for mp2629 Battery Charger driver Saravanan Sekar
2020-04-15 16:40 ` Andy Shevchenko [this message]
2020-04-15 16:53 ` [PATCH v9 0/6] Add battery charger driver support for MP2629 saravanan sekar
2020-04-15 17:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VerGG0_J+fHrZfwJRa3EHtGuz-pJbD7zwoXN2jfO7dszA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=sravanhome@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).