* [PATCH -next] tracing: Make tracing_snapshot_instance_cond() static
@ 2020-04-23 4:08 Zou Wei
2020-04-24 13:48 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-04-23 4:08 UTC (permalink / raw)
To: rostedt, mingo; +Cc: linux-kernel, Zou Wei
Fix the following sparse warning:
kernel/trace/trace.c:950:6: warning: symbol 'tracing_snapshot_instance_cond'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
kernel/trace/trace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 8d2b988..1424a89 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -947,7 +947,8 @@ int __trace_bputs(unsigned long ip, const char *str)
EXPORT_SYMBOL_GPL(__trace_bputs);
#ifdef CONFIG_TRACER_SNAPSHOT
-void tracing_snapshot_instance_cond(struct trace_array *tr, void *cond_data)
+static void tracing_snapshot_instance_cond(struct trace_array *tr,
+ void *cond_data)
{
struct tracer *tracer = tr->current_trace;
unsigned long flags;
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] tracing: Make tracing_snapshot_instance_cond() static
2020-04-23 4:08 [PATCH -next] tracing: Make tracing_snapshot_instance_cond() static Zou Wei
@ 2020-04-24 13:48 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2020-04-24 13:48 UTC (permalink / raw)
To: Zou Wei; +Cc: mingo, linux-kernel
On Thu, 23 Apr 2020 12:08:25 +0800
Zou Wei <zou_wei@huawei.com> wrote:
> Fix the following sparse warning:
>
> kernel/trace/trace.c:950:6: warning: symbol 'tracing_snapshot_instance_cond'
> was not declared. Should it be static?
Thanks, I'll add it to my queue.
-- Steve
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> kernel/trace/trace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 8d2b988..1424a89 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -947,7 +947,8 @@ int __trace_bputs(unsigned long ip, const char *str)
> EXPORT_SYMBOL_GPL(__trace_bputs);
>
> #ifdef CONFIG_TRACER_SNAPSHOT
> -void tracing_snapshot_instance_cond(struct trace_array *tr, void *cond_data)
> +static void tracing_snapshot_instance_cond(struct trace_array *tr,
> + void *cond_data)
> {
> struct tracer *tracer = tr->current_trace;
> unsigned long flags;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-24 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-23 4:08 [PATCH -next] tracing: Make tracing_snapshot_instance_cond() static Zou Wei
2020-04-24 13:48 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).