From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robherring2@gmail.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST by default
Date: Fri, 24 Apr 2020 14:30:08 -0500 [thread overview]
Message-ID: <20200424193008.GA177667@google.com> (raw)
In-Reply-To: <20200422192957.6lwr3aig4a3dcynr@rob-hp-laptop>
On Wed, Apr 22, 2020 at 02:29:57PM -0500, Rob Herring wrote:
> On Tue, Apr 14, 2020 at 07:12:41PM -0500, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Drivers should not be selected by default because that bloats the kernel
> > for people who don't need them.
> >
> > Remove the "default y" for CONFIG_PCI_DRA7XX_HOST.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Kishon Vijay Abraham I <kishon@ti.com>
> > Cc: linux-omap@vger.kernel.org
> > ---
> > drivers/pci/controller/dwc/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> > index 03dcaf65d159..ea335ee7ca8e 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -26,7 +26,6 @@ config PCI_DRA7XX_HOST
> > depends on OF && HAS_IOMEM && TI_PIPE3
> > select PCIE_DW_HOST
> > select PCI_DRA7XX
> > - default y
>
> Perhaps 'default y if SOC_DRA7XX'?
Good idea, I did that.
next prev parent reply other threads:[~2020-04-24 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
2020-04-15 0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
2020-04-22 19:29 ` Rob Herring
2020-04-24 19:30 ` Bjorn Helgaas [this message]
2020-04-15 0:12 ` [PATCH 2/4] PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST " Bjorn Helgaas
2020-04-15 0:12 ` [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER " Bjorn Helgaas
2020-04-15 0:20 ` Kuppuswamy, Sathyanarayanan
2020-04-15 0:12 ` [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM " Bjorn Helgaas
2020-06-01 16:31 ` Bjorn Helgaas
2020-04-24 19:37 ` [PATCH 0/4] PCI: Don't select Kconfig symbols " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424193008.GA177667@google.com \
--to=helgaas@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).