From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-pci@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Christoph Hellwig <hch@infradead.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM by default
Date: Mon, 1 Jun 2020 11:31:34 -0500 [thread overview]
Message-ID: <20200601163134.GA724675@bjorn-Precision-5520> (raw)
In-Reply-To: <20200415001244.144623-5-helgaas@kernel.org>
On Tue, Apr 14, 2020 at 07:12:44PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> PCIe Active State Power Management (ASPM) is optional and there's no need
> for it to be selected by default.
>
> Remove the "default y" for CONFIG_PCIEASPM.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Heiner Kallweit <hkallweit1@gmail.com>
I dropped this patch for now.
Without CONFIG_PCIEASPM, Linux doesn't request control of *any*
features via _OSC (see ACPI_PCIE_REQ_SUPPORT), which means we can't
use PCIe PME to resume from runtime suspend.
https://bugzilla.redhat.com/show_bug.cgi?id=638912
https://lore.kernel.org/r/2e1ee784-7493-284b-96f9-96b2e0c4b817@gmail.com
> ---
> drivers/pci/pcie/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig
> index 9cd31331aee9..5b7b460a8a98 100644
> --- a/drivers/pci/pcie/Kconfig
> +++ b/drivers/pci/pcie/Kconfig
> @@ -62,7 +62,6 @@ config PCIE_ECRC
> #
> config PCIEASPM
> bool "PCI Express ASPM control" if EXPERT
> - default y
> help
> This enables OS control over PCI Express ASPM (Active State
> Power Management) and Clock Power Management. ASPM supports
> --
> 2.26.0.110.g2183baf09c-goog
>
next prev parent reply other threads:[~2020-06-01 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 0:12 [PATCH 0/4] PCI: Don't select Kconfig symbols by default Bjorn Helgaas
2020-04-15 0:12 ` [PATCH 1/4] PCI: dra7xx: Don't select CONFIG_PCI_DRA7XX_HOST " Bjorn Helgaas
2020-04-22 19:29 ` Rob Herring
2020-04-24 19:30 ` Bjorn Helgaas
2020-04-15 0:12 ` [PATCH 2/4] PCI: keystone: Don't select CONFIG_PCI_KEYSTONE_HOST " Bjorn Helgaas
2020-04-15 0:12 ` [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER " Bjorn Helgaas
2020-04-15 0:20 ` Kuppuswamy, Sathyanarayanan
2020-04-15 0:12 ` [PATCH 4/4] PCI/ASPM: Don't select CONFIG_PCIEASPM " Bjorn Helgaas
2020-06-01 16:31 ` Bjorn Helgaas [this message]
2020-04-24 19:37 ` [PATCH 0/4] PCI: Don't select Kconfig symbols " Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200601163134.GA724675@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).