* [PATCH] soundwire: intel: Remove unused function
@ 2020-04-22 19:08 Sudip Mukherjee
2020-04-24 19:56 ` Nathan Chancellor
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2020-04-22 19:08 UTC (permalink / raw)
To: Vinod Koul, Sanyog Kale, Pierre-Louis Bossart
Cc: linux-kernel, alsa-devel, Sudip Mukherjee
The function sdw_intel_init() is not used anywhere, remove it for now.
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
---
drivers/soundwire/intel_init.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index ad7053463889..2f37dad06321 100644
--- a/drivers/soundwire/intel_init.c
+++ b/drivers/soundwire/intel_init.c
@@ -183,29 +183,6 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
}
/**
- * sdw_intel_init() - SoundWire Intel init routine
- * @parent_handle: ACPI parent handle
- * @res: resource data
- *
- * This scans the namespace and creates SoundWire link controller devices
- * based on the info queried.
- */
-static void *sdw_intel_init(acpi_handle *parent_handle,
- struct sdw_intel_res *res)
-{
- acpi_status status;
-
- status = acpi_walk_namespace(ACPI_TYPE_DEVICE,
- parent_handle, 1,
- sdw_intel_acpi_cb,
- NULL, res, NULL);
- if (ACPI_FAILURE(status))
- return NULL;
-
- return sdw_intel_add_controller(res);
-}
-
-/**
* sdw_intel_exit() - SoundWire Intel exit
* @arg: callback context
*
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] soundwire: intel: Remove unused function
2020-04-22 19:08 [PATCH] soundwire: intel: Remove unused function Sudip Mukherjee
@ 2020-04-24 19:56 ` Nathan Chancellor
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Chancellor @ 2020-04-24 19:56 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Vinod Koul, Sanyog Kale, Pierre-Louis Bossart, linux-kernel, alsa-devel
On Wed, Apr 22, 2020 at 08:08:15PM +0100, Sudip Mukherjee wrote:
> The function sdw_intel_init() is not used anywhere, remove it for now.
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
> drivers/soundwire/intel_init.c | 23 -----------------------
> 1 file changed, 23 deletions(-)
>
> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
> index ad7053463889..2f37dad06321 100644
> --- a/drivers/soundwire/intel_init.c
> +++ b/drivers/soundwire/intel_init.c
> @@ -183,29 +183,6 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
> }
>
> /**
> - * sdw_intel_init() - SoundWire Intel init routine
> - * @parent_handle: ACPI parent handle
> - * @res: resource data
> - *
> - * This scans the namespace and creates SoundWire link controller devices
> - * based on the info queried.
> - */
> -static void *sdw_intel_init(acpi_handle *parent_handle,
> - struct sdw_intel_res *res)
> -{
> - acpi_status status;
> -
> - status = acpi_walk_namespace(ACPI_TYPE_DEVICE,
> - parent_handle, 1,
> - sdw_intel_acpi_cb,
> - NULL, res, NULL);
> - if (ACPI_FAILURE(status))
> - return NULL;
> -
> - return sdw_intel_add_controller(res);
> -}
> -
> -/**
> * sdw_intel_exit() - SoundWire Intel exit
> * @arg: callback context
> *
> --
> 2.11.0
>
This patch will cause two more warnings.
$ make -j$(nproc) -s O=out allyesconfig drivers/soundwire/intel_init.o
../drivers/soundwire/intel_init.c:152:20: warning: ‘sdw_intel_acpi_cb’
defined but not used [-Wunused-function]
static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
^~~~~~~~~~~~~~~~~
../drivers/soundwire/intel_init.c:51:2: warning:
‘sdw_intel_add_controller’ defined but not used [-Wunused-function]
*sdw_intel_add_controller(struct sdw_intel_res *res)
^~~~~~~~~~~~~~~~~~~~~~~~
Removing these two functions seems to be enough. link_mask should also
be removed at that point.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-24 19:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22 19:08 [PATCH] soundwire: intel: Remove unused function Sudip Mukherjee
2020-04-24 19:56 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).