* [PATCH] dma-buf: heaps: Initialize during core instead of subsys
@ 2020-04-24 22:17 Andrew F. Davis
2020-04-25 0:23 ` John Stultz
0 siblings, 1 reply; 2+ messages in thread
From: Andrew F. Davis @ 2020-04-24 22:17 UTC (permalink / raw)
To: Sumit Semwal, John Stultz, Benjamin Gaignard, Liam Mark,
Laura Abbott, Brian Starkey
Cc: dri-devel, linaro-mm-sig, linux-kernel, Andrew F . Davis
Some clients of DMA-Heaps probe earlier than subsys_initcall(), this
can cause issues when these clients call dma_heap_add() before the
core DMA-Heaps framework has initialized. DMA-Heaps should initialize
during core startup to get ahead of all users.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/dma-buf/dma-heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index afd22c9dbdcf..af6edfbeddfe 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -295,4 +295,4 @@ static int dma_heap_init(void)
return 0;
}
-subsys_initcall(dma_heap_init);
+core_initcall(dma_heap_init);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dma-buf: heaps: Initialize during core instead of subsys
2020-04-24 22:17 [PATCH] dma-buf: heaps: Initialize during core instead of subsys Andrew F. Davis
@ 2020-04-25 0:23 ` John Stultz
0 siblings, 0 replies; 2+ messages in thread
From: John Stultz @ 2020-04-25 0:23 UTC (permalink / raw)
To: Andrew F. Davis
Cc: Sumit Semwal, Benjamin Gaignard, Liam Mark, Laura Abbott,
Brian Starkey, dri-devel,
moderated list:DMA BUFFER SHARING FRAMEWORK, lkml
On Fri, Apr 24, 2020 at 3:18 PM Andrew F. Davis <afd@ti.com> wrote:
>
> Some clients of DMA-Heaps probe earlier than subsys_initcall(), this
> can cause issues when these clients call dma_heap_add() before the
> core DMA-Heaps framework has initialized. DMA-Heaps should initialize
> during core startup to get ahead of all users.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
No objection from me right off.
Acked-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-25 0:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 22:17 [PATCH] dma-buf: heaps: Initialize during core instead of subsys Andrew F. Davis
2020-04-25 0:23 ` John Stultz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).