* [PATCH] net: phy: bcm54140: Make a bunch of functions static
@ 2020-04-25 8:49 ChenTao
2020-04-27 18:14 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: ChenTao @ 2020-04-25 8:49 UTC (permalink / raw)
To: f.fainelli, hkallweit1; +Cc: linux, davem, linux-kernel, chentao107
Fix the following warning:
drivers/net/phy/bcm54140.c:663:5: warning:
symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
drivers/net/phy/bcm54140.c:672:5: warning:
symbol 'bcm54140_ack_intr' was not declared. Should it be static?
drivers/net/phy/bcm54140.c:684:5: warning:
symbol 'bcm54140_config_intr' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenTao <chentao107@huawei.com>
---
drivers/net/phy/bcm54140.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/bcm54140.c b/drivers/net/phy/bcm54140.c
index 7341f0126cc4..c009ac2856a5 100644
--- a/drivers/net/phy/bcm54140.c
+++ b/drivers/net/phy/bcm54140.c
@@ -660,7 +660,7 @@ static int bcm54140_config_init(struct phy_device *phydev)
BCM54140_RDB_C_PWR_ISOLATE, 0);
}
-int bcm54140_did_interrupt(struct phy_device *phydev)
+static int bcm54140_did_interrupt(struct phy_device *phydev)
{
int ret;
@@ -669,7 +669,7 @@ int bcm54140_did_interrupt(struct phy_device *phydev)
return (ret < 0) ? 0 : ret;
}
-int bcm54140_ack_intr(struct phy_device *phydev)
+static int bcm54140_ack_intr(struct phy_device *phydev)
{
int reg;
@@ -681,7 +681,7 @@ int bcm54140_ack_intr(struct phy_device *phydev)
return 0;
}
-int bcm54140_config_intr(struct phy_device *phydev)
+static int bcm54140_config_intr(struct phy_device *phydev)
{
struct bcm54140_priv *priv = phydev->priv;
static const u16 port_to_imr_bit[] = {
--
2.22.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: bcm54140: Make a bunch of functions static
2020-04-25 8:49 [PATCH] net: phy: bcm54140: Make a bunch of functions static ChenTao
@ 2020-04-27 18:14 ` David Miller
2020-04-28 1:42 ` chentao (AS)
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-04-27 18:14 UTC (permalink / raw)
To: chentao107; +Cc: f.fainelli, hkallweit1, linux, linux-kernel
From: ChenTao <chentao107@huawei.com>
Date: Sat, 25 Apr 2020 16:49:44 +0800
> Fix the following warning:
>
> drivers/net/phy/bcm54140.c:663:5: warning:
> symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:672:5: warning:
> symbol 'bcm54140_ack_intr' was not declared. Should it be static?
> drivers/net/phy/bcm54140.c:684:5: warning:
> symbol 'bcm54140_config_intr' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: ChenTao <chentao107@huawei.com>
The appropriate mailing list for networking changes is netdev@vger.kernel.org
so please resubmit this there.
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: bcm54140: Make a bunch of functions static
2020-04-27 18:14 ` David Miller
@ 2020-04-28 1:42 ` chentao (AS)
0 siblings, 0 replies; 3+ messages in thread
From: chentao (AS) @ 2020-04-28 1:42 UTC (permalink / raw)
To: David Miller; +Cc: f.fainelli, hkallweit1, linux, linux-kernel
Thanks a lot, i will resubmit the patch.
On 2020/4/28 2:14, David Miller wrote:
> From: ChenTao <chentao107@huawei.com>
> Date: Sat, 25 Apr 2020 16:49:44 +0800
>
>> Fix the following warning:
>>
>> drivers/net/phy/bcm54140.c:663:5: warning:
>> symbol 'bcm54140_did_interrupt' was not declared. Should it be static?
>> drivers/net/phy/bcm54140.c:672:5: warning:
>> symbol 'bcm54140_ack_intr' was not declared. Should it be static?
>> drivers/net/phy/bcm54140.c:684:5: warning:
>> symbol 'bcm54140_config_intr' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: ChenTao <chentao107@huawei.com>
> The appropriate mailing list for networking changes is netdev@vger.kernel.org
> so please resubmit this there.
>
> Thank you.
> .
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-28 1:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-25 8:49 [PATCH] net: phy: bcm54140: Make a bunch of functions static ChenTao
2020-04-27 18:14 ` David Miller
2020-04-28 1:42 ` chentao (AS)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).