linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: adaplas@gmail.com, b.zolnierkie@samsung.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video/fbdev/riva: Remove dead code
Date: Sat, 25 Apr 2020 17:11:07 +0200	[thread overview]
Message-ID: <20200425151107.GH32235@ravnborg.org> (raw)
In-Reply-To: <1587407244-32574-1-git-send-email-jrdr.linux@gmail.com>

Hi Souptick
On Mon, Apr 20, 2020 at 11:57:24PM +0530, Souptick Joarder wrote:
> These are dead code since 3.15. These can be removed forever if no
> plan to use it further.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Thanks. Patch applied to drm-misc-next.
It will appear in mianline kernel in next merge window.

	Sam


> ---
>  drivers/video/fbdev/riva/riva_hw.c | 18 ------------------
>  1 file changed, 18 deletions(-)
> 
> diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
> index 0601c13..08c9ee4 100644
> --- a/drivers/video/fbdev/riva/riva_hw.c
> +++ b/drivers/video/fbdev/riva/riva_hw.c
> @@ -1343,24 +1343,6 @@ static char nv3_get_param(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_ar
>  /*
>   * Load fixed function state and pre-calculated/stored state.
>   */
> -#if 0
> -#define LOAD_FIXED_STATE(tbl,dev)                                       \
> -    for (i = 0; i < sizeof(tbl##Table##dev)/8; i++)                 \
> -        chip->dev[tbl##Table##dev[i][0]] = tbl##Table##dev[i][1]
> -#define LOAD_FIXED_STATE_8BPP(tbl,dev)                                  \
> -    for (i = 0; i < sizeof(tbl##Table##dev##_8BPP)/8; i++)            \
> -        chip->dev[tbl##Table##dev##_8BPP[i][0]] = tbl##Table##dev##_8BPP[i][1]
> -#define LOAD_FIXED_STATE_15BPP(tbl,dev)                                 \
> -    for (i = 0; i < sizeof(tbl##Table##dev##_15BPP)/8; i++)           \
> -        chip->dev[tbl##Table##dev##_15BPP[i][0]] = tbl##Table##dev##_15BPP[i][1]
> -#define LOAD_FIXED_STATE_16BPP(tbl,dev)                                 \
> -    for (i = 0; i < sizeof(tbl##Table##dev##_16BPP)/8; i++)           \
> -        chip->dev[tbl##Table##dev##_16BPP[i][0]] = tbl##Table##dev##_16BPP[i][1]
> -#define LOAD_FIXED_STATE_32BPP(tbl,dev)                                 \
> -    for (i = 0; i < sizeof(tbl##Table##dev##_32BPP)/8; i++)           \
> -        chip->dev[tbl##Table##dev##_32BPP[i][0]] = tbl##Table##dev##_32BPP[i][1]
> -#endif
> -
>  #define LOAD_FIXED_STATE(tbl,dev)                                       \
>      for (i = 0; i < sizeof(tbl##Table##dev)/8; i++)                 \
>          NV_WR32(&chip->dev[tbl##Table##dev[i][0]], 0, tbl##Table##dev[i][1])
> -- 
> 1.9.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-04-25 15:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20 18:27 [PATCH] video/fbdev/riva: Remove dead code Souptick Joarder
2020-04-25 15:11 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200425151107.GH32235@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=adaplas@gmail.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).