* [PATCH] video/fbdev/riva: Remove dead code
@ 2020-04-20 18:27 Souptick Joarder
2020-04-25 15:11 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Souptick Joarder @ 2020-04-20 18:27 UTC (permalink / raw)
To: adaplas, b.zolnierkie; +Cc: dri-devel, linux-kernel, Souptick Joarder
These are dead code since 3.15. These can be removed forever if no
plan to use it further.
Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
drivers/video/fbdev/riva/riva_hw.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
index 0601c13..08c9ee4 100644
--- a/drivers/video/fbdev/riva/riva_hw.c
+++ b/drivers/video/fbdev/riva/riva_hw.c
@@ -1343,24 +1343,6 @@ static char nv3_get_param(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_ar
/*
* Load fixed function state and pre-calculated/stored state.
*/
-#if 0
-#define LOAD_FIXED_STATE(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
- chip->dev[tbl##Table##dev[i][0]] = tbl##Table##dev[i][1]
-#define LOAD_FIXED_STATE_8BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_8BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_8BPP[i][0]] = tbl##Table##dev##_8BPP[i][1]
-#define LOAD_FIXED_STATE_15BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_15BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_15BPP[i][0]] = tbl##Table##dev##_15BPP[i][1]
-#define LOAD_FIXED_STATE_16BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_16BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_16BPP[i][0]] = tbl##Table##dev##_16BPP[i][1]
-#define LOAD_FIXED_STATE_32BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_32BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_32BPP[i][0]] = tbl##Table##dev##_32BPP[i][1]
-#endif
-
#define LOAD_FIXED_STATE(tbl,dev) \
for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
NV_WR32(&chip->dev[tbl##Table##dev[i][0]], 0, tbl##Table##dev[i][1])
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video/fbdev/riva: Remove dead code
2020-04-20 18:27 [PATCH] video/fbdev/riva: Remove dead code Souptick Joarder
@ 2020-04-25 15:11 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2020-04-25 15:11 UTC (permalink / raw)
To: Souptick Joarder; +Cc: adaplas, b.zolnierkie, linux-kernel, dri-devel
Hi Souptick
On Mon, Apr 20, 2020 at 11:57:24PM +0530, Souptick Joarder wrote:
> These are dead code since 3.15. These can be removed forever if no
> plan to use it further.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
Thanks. Patch applied to drm-misc-next.
It will appear in mianline kernel in next merge window.
Sam
> ---
> drivers/video/fbdev/riva/riva_hw.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
> index 0601c13..08c9ee4 100644
> --- a/drivers/video/fbdev/riva/riva_hw.c
> +++ b/drivers/video/fbdev/riva/riva_hw.c
> @@ -1343,24 +1343,6 @@ static char nv3_get_param(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_ar
> /*
> * Load fixed function state and pre-calculated/stored state.
> */
> -#if 0
> -#define LOAD_FIXED_STATE(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
> - chip->dev[tbl##Table##dev[i][0]] = tbl##Table##dev[i][1]
> -#define LOAD_FIXED_STATE_8BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_8BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_8BPP[i][0]] = tbl##Table##dev##_8BPP[i][1]
> -#define LOAD_FIXED_STATE_15BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_15BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_15BPP[i][0]] = tbl##Table##dev##_15BPP[i][1]
> -#define LOAD_FIXED_STATE_16BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_16BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_16BPP[i][0]] = tbl##Table##dev##_16BPP[i][1]
> -#define LOAD_FIXED_STATE_32BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_32BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_32BPP[i][0]] = tbl##Table##dev##_32BPP[i][1]
> -#endif
> -
> #define LOAD_FIXED_STATE(tbl,dev) \
> for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
> NV_WR32(&chip->dev[tbl##Table##dev[i][0]], 0, tbl##Table##dev[i][1])
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-25 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 18:27 [PATCH] video/fbdev/riva: Remove dead code Souptick Joarder
2020-04-25 15:11 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).