* [PATCH] arm64: dts: allwinner: a64: pinetab: Fix cpvdd supply name
@ 2020-04-26 16:23 Samuel Holland
2020-05-04 10:53 ` Maxime Ripard
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2020-04-26 16:23 UTC (permalink / raw)
To: Maxime Ripard, Chen-Yu Tsai
Cc: Rob Herring, devicetree, linux-arm-kernel, linux-kernel,
linux-sunxi, Samuel Holland
An older version of the analog codec binding referenced the headphone
amplifier binding as "hpvcc". However, by the time it was merged in
commit 21dd30200e3d ("ASoC: dt-bindings: sun50i-codec-analog: Add
headphone amp regulator supply"), the regulator reference was renamed to
"cpvdd". This board's device tree still uses the old name, which fails
to work at runtime, and which causes a warning from `make dtbs_check`.
Resolve both by fixing the name.
Fixes: 674ef1d0a7b2 ("arm64: dts: allwinner: a64: add support for PineTab")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
index 316e8a443913..dc4ab6b434f9 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts
@@ -98,7 +98,7 @@ &codec {
};
&codec_analog {
- hpvcc-supply = <®_eldo1>;
+ cpvdd-supply = <®_eldo1>;
status = "okay";
};
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: allwinner: a64: pinetab: Fix cpvdd supply name
2020-04-26 16:23 [PATCH] arm64: dts: allwinner: a64: pinetab: Fix cpvdd supply name Samuel Holland
@ 2020-05-04 10:53 ` Maxime Ripard
0 siblings, 0 replies; 2+ messages in thread
From: Maxime Ripard @ 2020-05-04 10:53 UTC (permalink / raw)
To: Samuel Holland
Cc: Chen-Yu Tsai, Rob Herring, devicetree, linux-arm-kernel,
linux-kernel, linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On Sun, Apr 26, 2020 at 11:23:53AM -0500, Samuel Holland wrote:
> An older version of the analog codec binding referenced the headphone
> amplifier binding as "hpvcc". However, by the time it was merged in
> commit 21dd30200e3d ("ASoC: dt-bindings: sun50i-codec-analog: Add
> headphone amp regulator supply"), the regulator reference was renamed to
> "cpvdd". This board's device tree still uses the old name, which fails
> to work at runtime, and which causes a warning from `make dtbs_check`.
> Resolve both by fixing the name.
>
> Fixes: 674ef1d0a7b2 ("arm64: dts: allwinner: a64: add support for PineTab")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Applied, thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-04 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 16:23 [PATCH] arm64: dts: allwinner: a64: pinetab: Fix cpvdd supply name Samuel Holland
2020-05-04 10:53 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).