linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock
@ 2020-04-24 18:16 Adrian Pop
  2020-04-27  6:49 ` Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Pop @ 2020-04-24 18:16 UTC (permalink / raw)
  To: Alexandre Torgue, Maxime Coquelin, Rob Herring
  Cc: linux-kernel, linux-arm-kernel, linux-stm32, devicetree,
	Lee Jones, Adrian Pop

Add missing clock.

Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
---
 include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-bindings/mfd/stm32f7-rcc.h
index a90f3613c584..ba5cb7456ee4 100644
--- a/include/dt-bindings/mfd/stm32f7-rcc.h
+++ b/include/dt-bindings/mfd/stm32f7-rcc.h
@@ -107,6 +107,7 @@
 #define STM32F7_RCC_APB2_SAI1		22
 #define STM32F7_RCC_APB2_SAI2		23
 #define STM32F7_RCC_APB2_LTDC		26
+#define STM32F7_RCC_APB2_DSI		27
 
 #define STM32F7_APB2_RESET(bit)	(STM32F7_RCC_APB2_##bit + (0x24 * 8))
 #define STM32F7_APB2_CLOCK(bit)	(STM32F7_RCC_APB2_##bit + 0xA0)
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock
  2020-04-24 18:16 [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock Adrian Pop
@ 2020-04-27  6:49 ` Lee Jones
  2020-04-27 18:59   ` Adrian Pop
  0 siblings, 1 reply; 4+ messages in thread
From: Lee Jones @ 2020-04-27  6:49 UTC (permalink / raw)
  To: Adrian Pop
  Cc: Alexandre Torgue, Maxime Coquelin, Rob Herring, linux-kernel,
	linux-arm-kernel, linux-stm32, devicetree

On Fri, 24 Apr 2020, Adrian Pop wrote:

> Add missing clock.
> 
> Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> ---
>  include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
>  1 file changed, 1 insertion(+)

I assume patch 2 depends on this?

If so, where is it?  Why isn't it in my inbox?

> diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-bindings/mfd/stm32f7-rcc.h
> index a90f3613c584..ba5cb7456ee4 100644
> --- a/include/dt-bindings/mfd/stm32f7-rcc.h
> +++ b/include/dt-bindings/mfd/stm32f7-rcc.h
> @@ -107,6 +107,7 @@
>  #define STM32F7_RCC_APB2_SAI1		22
>  #define STM32F7_RCC_APB2_SAI2		23
>  #define STM32F7_RCC_APB2_LTDC		26
> +#define STM32F7_RCC_APB2_DSI		27
>  
>  #define STM32F7_APB2_RESET(bit)	(STM32F7_RCC_APB2_##bit + (0x24 * 8))
>  #define STM32F7_APB2_CLOCK(bit)	(STM32F7_RCC_APB2_##bit + 0xA0)

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock
  2020-04-27  6:49 ` Lee Jones
@ 2020-04-27 18:59   ` Adrian Pop
  2020-04-28  7:03     ` Lee Jones
  0 siblings, 1 reply; 4+ messages in thread
From: Adrian Pop @ 2020-04-27 18:59 UTC (permalink / raw)
  To: Lee Jones
  Cc: Alexandre Torgue, Maxime Coquelin, Rob Herring, linux-kernel,
	linux-arm-kernel, linux-stm32, devicetree

On Mon, Apr 27, 2020 at 9:49 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 24 Apr 2020, Adrian Pop wrote:
>
> > Add missing clock.
> >
> > Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> > ---
> >  include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
> >  1 file changed, 1 insertion(+)
>
> I assume patch 2 depends on this?

Yes, second patch depends on this.

>
> If so, where is it?  Why isn't it in my inbox?
>

Here it is:

STM32f769-disco features a 4" MIPI DSI display: add support for it.

Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
---
 arch/arm/boot/dts/stm32f746.dtsi      | 34 ++++++++++++++++++
 arch/arm/boot/dts/stm32f769-disco.dts | 50 +++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)

diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi
index 93c063796780..202bb6edc9f1 100644
--- a/arch/arm/boot/dts/stm32f746.dtsi
+++ b/arch/arm/boot/dts/stm32f746.dtsi
@@ -48,6 +48,19 @@ / {
        #address-cells = <1>;
        #size-cells = <1>;

+       reserved-memory {
+               #address-cells = <1>;
+               #size-cells = <1>;
+               ranges;
+
+               linux,dma {
+                       compatible = "shared-dma-pool";
+                       linux,dma-default;
+                       no-map;
+                       size = <0x10F000>;
+               };
+       };
+
        clocks {
                clk_hse: clk-hse {
                        #clock-cells = <0>;
@@ -75,6 +88,27 @@ clk_i2s_ckin: clk-i2s-ckin {
        };

        soc {
+               ltdc: display-controller@40016800 {
+                       compatible = "st,stm32-ltdc";
+                       reg = <0x40016800 0x200>;
+                       interrupts = <88>, <89>;
+                       resets = <&rcc STM32F7_APB2_RESET(LTDC)>;
+                       clocks = <&rcc 1 CLK_LCD>;
+                       clock-names = "lcd";
+                       status = "disabled";
+               };
+
+               dsi: dsi@40016c00 {
+                       compatible = "st,stm32-dsi";
+                       reg = <0x40016c00 0x800>;
+                       interrupts = <98>;
+                       clocks = <&rcc 1 CLK_F769_DSI>, <&clk_hse>;
+                       clock-names = "pclk", "ref";
+                       resets = <&rcc STM32F7_APB2_RESET(DSI)>;
+                       reset-names = "apb";
+                       status = "disabled";
+               };
+
                timer2: timer@40000000 {
                        compatible = "st,stm32-timer";
                        reg = <0x40000000 0x400>;
diff --git a/arch/arm/boot/dts/stm32f769-disco.dts
b/arch/arm/boot/dts/stm32f769-disco.dts
index 1626e00bb2cb..30ebbc193e82 100644
--- a/arch/arm/boot/dts/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/stm32f769-disco.dts
@@ -153,3 +153,53 @@ &usbotg_hs {
        pinctrl-names = "default";
        status = "okay";
 };
+
+&dsi {
+       #address-cells = <1>;
+       #size-cells = <0>;
+       status = "okay";
+
+       ports {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               port@0 {
+                       reg = <0>;
+                       dsi_in: endpoint {
+                               remote-endpoint = <&ltdc_out_dsi>;
+                       };
+               };
+
+               port@1 {
+                       reg = <1>;
+                       dsi_out: endpoint {
+                               remote-endpoint = <&dsi_in_panel>;
+                       };
+               };
+
+       };
+
+       panel: panel {
+               compatible = "orisetech,otm8009a";
+               reg = <0>; /* dsi virtual channel (0..3) */
+               reset-gpios = <&gpioj 15 GPIO_ACTIVE_LOW>;
+               status = "okay";
+
+               port {
+                       dsi_in_panel: endpoint {
+                               remote-endpoint = <&dsi_out>;
+                       };
+               };
+       };
+};
+
+&ltdc {
+       dma-ranges;
+       status = "okay";
+
+       port {
+               ltdc_out_dsi: endpoint {
+                       remote-endpoint = <&dsi_in>;
+               };
+       };
+};
--

> > diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-bindings/mfd/stm32f7-rcc.h
> > index a90f3613c584..ba5cb7456ee4 100644
> > --- a/include/dt-bindings/mfd/stm32f7-rcc.h
> > +++ b/include/dt-bindings/mfd/stm32f7-rcc.h
> > @@ -107,6 +107,7 @@
> >  #define STM32F7_RCC_APB2_SAI1                22
> >  #define STM32F7_RCC_APB2_SAI2                23
> >  #define STM32F7_RCC_APB2_LTDC                26
> > +#define STM32F7_RCC_APB2_DSI         27
> >
> >  #define STM32F7_APB2_RESET(bit)      (STM32F7_RCC_APB2_##bit + (0x24 * 8))
> >  #define STM32F7_APB2_CLOCK(bit)      (STM32F7_RCC_APB2_##bit + 0xA0)
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

On Mon, Apr 27, 2020 at 9:49 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 24 Apr 2020, Adrian Pop wrote:
>
> > Add missing clock.
> >
> > Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> > ---
> >  include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
> >  1 file changed, 1 insertion(+)
>
> I assume patch 2 depends on this?
>
> If so, where is it?  Why isn't it in my inbox?
>
> > diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-bindings/mfd/stm32f7-rcc.h
> > index a90f3613c584..ba5cb7456ee4 100644
> > --- a/include/dt-bindings/mfd/stm32f7-rcc.h
> > +++ b/include/dt-bindings/mfd/stm32f7-rcc.h
> > @@ -107,6 +107,7 @@
> >  #define STM32F7_RCC_APB2_SAI1                22
> >  #define STM32F7_RCC_APB2_SAI2                23
> >  #define STM32F7_RCC_APB2_LTDC                26
> > +#define STM32F7_RCC_APB2_DSI         27
> >
> >  #define STM32F7_APB2_RESET(bit)      (STM32F7_RCC_APB2_##bit + (0x24 * 8))
> >  #define STM32F7_APB2_CLOCK(bit)      (STM32F7_RCC_APB2_##bit + 0xA0)
>
> --
> Lee Jones [李琼斯]
> Linaro Services Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock
  2020-04-27 18:59   ` Adrian Pop
@ 2020-04-28  7:03     ` Lee Jones
  0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2020-04-28  7:03 UTC (permalink / raw)
  To: Adrian Pop
  Cc: Alexandre Torgue, Maxime Coquelin, Rob Herring, linux-kernel,
	linux-arm-kernel, linux-stm32, devicetree

On Mon, 27 Apr 2020, Adrian Pop wrote:

> On Mon, Apr 27, 2020 at 9:49 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 24 Apr 2020, Adrian Pop wrote:
> >
> > > Add missing clock.
> > >
> > > Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> > > ---
> > >  include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
> > >  1 file changed, 1 insertion(+)
> >
> > I assume patch 2 depends on this?
> 
> Yes, second patch depends on this.
> 
> >
> > If so, where is it?  Why isn't it in my inbox?
> >
> 
> Here it is:
> 
> STM32f769-disco features a 4" MIPI DSI display: add support for it.
> 
> Signed-off-by: Adrian Pop <pop.adrian61@gmail.com>
> ---
>  arch/arm/boot/dts/stm32f746.dtsi      | 34 ++++++++++++++++++
>  arch/arm/boot/dts/stm32f769-disco.dts | 50 +++++++++++++++++++++++++++
>  2 files changed, 84 insertions(+)

When you resubmit this, please add all recipients to all patches.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-28  7:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 18:16 [PATCH 1/2] arm: dt-bindings: mfd: stm32f-rcc: Add missing DSI clock Adrian Pop
2020-04-27  6:49 ` Lee Jones
2020-04-27 18:59   ` Adrian Pop
2020-04-28  7:03     ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).