* [PATCH] x86/tboot: Mark tboot static
@ 2020-04-28 5:17 Christoph Hellwig
2020-04-28 11:06 ` [tip: x86/boot] " tip-bot2 for Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2020-04-28 5:17 UTC (permalink / raw)
To: ning.sun, x86; +Cc: tboot-devel, linux-kernel
This structure is only really used in tboot.c. The only exception
is a single tboot_enabled check, but for that we don't need an inline
function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
arch/x86/kernel/tboot.c | 8 ++++++--
include/linux/tboot.h | 8 +-------
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
index b89f6ac6a0c01..b2942b2dbfcfc 100644
--- a/arch/x86/kernel/tboot.c
+++ b/arch/x86/kernel/tboot.c
@@ -35,8 +35,7 @@
#include "../realmode/rm/wakeup.h"
/* Global pointer to shared data; NULL means no measured launch. */
-struct tboot *tboot __read_mostly;
-EXPORT_SYMBOL(tboot);
+static struct tboot *tboot __read_mostly;
/* timeout for APs (in secs) to enter wait-for-SIPI state during shutdown */
#define AP_WAIT_TIMEOUT 1
@@ -46,6 +45,11 @@ EXPORT_SYMBOL(tboot);
static u8 tboot_uuid[16] __initdata = TBOOT_UUID;
+bool tboot_enabled(void)
+{
+ return tboot != NULL;
+}
+
void __init tboot_probe(void)
{
/* Look for valid page-aligned address for shared page. */
diff --git a/include/linux/tboot.h b/include/linux/tboot.h
index 5424bc6feac88..c7e4247663602 100644
--- a/include/linux/tboot.h
+++ b/include/linux/tboot.h
@@ -121,13 +121,7 @@ struct tboot {
#define TBOOT_UUID {0xff, 0x8d, 0x3c, 0x66, 0xb3, 0xe8, 0x82, 0x4b, 0xbf,\
0xaa, 0x19, 0xea, 0x4d, 0x5, 0x7a, 0x8}
-extern struct tboot *tboot;
-
-static inline int tboot_enabled(void)
-{
- return tboot != NULL;
-}
-
+bool tboot_enabled(void);
extern void tboot_probe(void);
extern void tboot_shutdown(u32 shutdown_type);
extern struct acpi_table_header *tboot_get_dmar_table(
--
2.26.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip: x86/boot] x86/tboot: Mark tboot static
2020-04-28 5:17 [PATCH] x86/tboot: Mark tboot static Christoph Hellwig
@ 2020-04-28 11:06 ` tip-bot2 for Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Christoph Hellwig @ 2020-04-28 11:06 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Christoph Hellwig, Borislav Petkov, x86, LKML
The following commit has been merged into the x86/boot branch of tip:
Commit-ID: 767dea211cd0c68d8116d8c3b5104e82454fb44b
Gitweb: https://git.kernel.org/tip/767dea211cd0c68d8116d8c3b5104e82454fb44b
Author: Christoph Hellwig <hch@lst.de>
AuthorDate: Tue, 28 Apr 2020 07:17:03 +02:00
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Tue, 28 Apr 2020 11:05:44 +02:00
x86/tboot: Mark tboot static
This structure is only really used in tboot.c. The only exception
is a single tboot_enabled check, but for that we don't need an inline
function.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200428051703.1625952-1-hch@lst.de
---
arch/x86/kernel/tboot.c | 8 ++++++--
include/linux/tboot.h | 8 +-------
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
index b89f6ac..b2942b2 100644
--- a/arch/x86/kernel/tboot.c
+++ b/arch/x86/kernel/tboot.c
@@ -35,8 +35,7 @@
#include "../realmode/rm/wakeup.h"
/* Global pointer to shared data; NULL means no measured launch. */
-struct tboot *tboot __read_mostly;
-EXPORT_SYMBOL(tboot);
+static struct tboot *tboot __read_mostly;
/* timeout for APs (in secs) to enter wait-for-SIPI state during shutdown */
#define AP_WAIT_TIMEOUT 1
@@ -46,6 +45,11 @@ EXPORT_SYMBOL(tboot);
static u8 tboot_uuid[16] __initdata = TBOOT_UUID;
+bool tboot_enabled(void)
+{
+ return tboot != NULL;
+}
+
void __init tboot_probe(void)
{
/* Look for valid page-aligned address for shared page. */
diff --git a/include/linux/tboot.h b/include/linux/tboot.h
index 5424bc6..c7e4247 100644
--- a/include/linux/tboot.h
+++ b/include/linux/tboot.h
@@ -121,13 +121,7 @@ struct tboot {
#define TBOOT_UUID {0xff, 0x8d, 0x3c, 0x66, 0xb3, 0xe8, 0x82, 0x4b, 0xbf,\
0xaa, 0x19, 0xea, 0x4d, 0x5, 0x7a, 0x8}
-extern struct tboot *tboot;
-
-static inline int tboot_enabled(void)
-{
- return tboot != NULL;
-}
-
+bool tboot_enabled(void);
extern void tboot_probe(void);
extern void tboot_shutdown(u32 shutdown_type);
extern struct acpi_table_header *tboot_get_dmar_table(
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-28 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 5:17 [PATCH] x86/tboot: Mark tboot static Christoph Hellwig
2020-04-28 11:06 ` [tip: x86/boot] " tip-bot2 for Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).