From: Andrew Lunn <andrew@lunn.ch>
To: Michael Walle <michael@walle.cc>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/4] net: phy: bcm54140: fix phy_id_mask
Date: Tue, 28 Apr 2020 23:22:11 +0200 [thread overview]
Message-ID: <20200428212211.GC30459@lunn.ch> (raw)
In-Reply-To: <20200428210854.28088-2-michael@walle.cc>
On Tue, Apr 28, 2020 at 11:08:52PM +0200, Michael Walle wrote:
> Broadcom defines the bits for this PHY as follows:
> { oui[24:3], model[6:0], revision[2:0] }
>
> Thus we have to mask the lower three bits only.
>
> Fixes: 6937602ed3f9 ("net: phy: add Broadcom BCM54140 support")
> Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-04-28 21:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:08 [PATCH net-next 1/4] net: phy: bcm54140: use genphy_soft_reset() Michael Walle
2020-04-28 21:08 ` [PATCH net-next 2/4] net: phy: bcm54140: fix phy_id_mask Michael Walle
2020-04-28 21:22 ` Andrew Lunn [this message]
2020-04-28 22:31 ` Florian Fainelli
2020-04-28 21:08 ` [PATCH net-next 3/4] net: phy: bcm54140: apply the workaround on b0 chips Michael Walle
2020-04-28 21:23 ` Andrew Lunn
2020-04-28 22:31 ` Florian Fainelli
2020-04-28 21:08 ` [PATCH net-next 4/4] net: phy: bcm54140: add second PHY ID Michael Walle
2020-04-28 21:29 ` Andrew Lunn
2020-04-28 22:08 ` Michael Walle
2020-04-28 22:33 ` Florian Fainelli
2020-04-28 22:28 ` [PATCH net-next 1/4] net: phy: bcm54140: use genphy_soft_reset() Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428212211.GC30459@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).