From: Florian Fainelli <f.fainelli@gmail.com>
To: Michael Walle <michael@walle.cc>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next 4/4] net: phy: bcm54140: add second PHY ID
Date: Tue, 28 Apr 2020 15:33:14 -0700 [thread overview]
Message-ID: <44750393-9443-6def-e64a-7c1c133fd0c6@gmail.com> (raw)
In-Reply-To: <20200428210854.28088-4-michael@walle.cc>
On 4/28/20 2:08 PM, Michael Walle wrote:
> This PHY have to PHY IDs depending on its mode. Adjust the mask so that
> it includes both IDs.
>
> Also move the PHY_ID_BCM54140 out of the brcmphy.h into the driver to
> have the mask and the ID in one place.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
[snip]
Just one request below.
> diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
> index 8be150e69c7c..897b69309964 100644
> --- a/include/linux/brcmphy.h
> +++ b/include/linux/brcmphy.h
> @@ -25,7 +25,6 @@
> #define PHY_ID_BCM5461 0x002060c0
> #define PHY_ID_BCM54612E 0x03625e60
> #define PHY_ID_BCM54616S 0x03625d10
> -#define PHY_ID_BCM54140 0xae025019
I would prefer if you could leave the entry here since this the file
that centralizes all Broadcom PHY OUIs.
Thanks!
--
Florian
next prev parent reply other threads:[~2020-04-28 22:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:08 [PATCH net-next 1/4] net: phy: bcm54140: use genphy_soft_reset() Michael Walle
2020-04-28 21:08 ` [PATCH net-next 2/4] net: phy: bcm54140: fix phy_id_mask Michael Walle
2020-04-28 21:22 ` Andrew Lunn
2020-04-28 22:31 ` Florian Fainelli
2020-04-28 21:08 ` [PATCH net-next 3/4] net: phy: bcm54140: apply the workaround on b0 chips Michael Walle
2020-04-28 21:23 ` Andrew Lunn
2020-04-28 22:31 ` Florian Fainelli
2020-04-28 21:08 ` [PATCH net-next 4/4] net: phy: bcm54140: add second PHY ID Michael Walle
2020-04-28 21:29 ` Andrew Lunn
2020-04-28 22:08 ` Michael Walle
2020-04-28 22:33 ` Florian Fainelli [this message]
2020-04-28 22:28 ` [PATCH net-next 1/4] net: phy: bcm54140: use genphy_soft_reset() Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44750393-9443-6def-e64a-7c1c133fd0c6@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).