From: Jiri Olsa <jolsa@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>, Ingo Molnar <mingo@elte.hu>
Cc: Jiri Olsa <jolsa@kernel.org>,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Peter Zijlstra <peterz@infradead.org>,
lkml <linux-kernel@vger.kernel.org>,
"bibo,mao" <bibo.mao@intel.com>,
"Ziqian SUN (Zamir)" <zsun@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCHv2] kretprobe: Prevent triggering kretprobe from within kprobe_flush_task
Date: Tue, 28 Apr 2020 23:36:27 +0200 [thread overview]
Message-ID: <20200428213627.GI1476763@krava> (raw)
In-Reply-To: <20200417163810.ffe5c9145eae281fc493932c@kernel.org>
On Fri, Apr 17, 2020 at 04:38:10PM +0900, Masami Hiramatsu wrote:
SNIP
> >
> > The code within the kretprobe handler checks for probe reentrancy,
> > so we won't trigger any _raw_spin_lock_irqsave probe in there.
> >
> > The problem is in outside kprobe_flush_task, where we call:
> >
> > kprobe_flush_task
> > kretprobe_table_lock
> > raw_spin_lock_irqsave
> > _raw_spin_lock_irqsave
> >
> > where _raw_spin_lock_irqsave triggers the kretprobe and installs
> > kretprobe_trampoline handler on _raw_spin_lock_irqsave return.
> >
> > The kretprobe_trampoline handler is then executed with already
> > locked kretprobe_table_locks, and first thing it does is to
> > lock kretprobe_table_locks ;-) the whole lockup path like:
> >
> > kprobe_flush_task
> > kretprobe_table_lock
> > raw_spin_lock_irqsave
> > _raw_spin_lock_irqsave ---> probe triggered, kretprobe_trampoline installed
> >
> > ---> kretprobe_table_locks locked
> >
> > kretprobe_trampoline
> > trampoline_handler
> > kretprobe_hash_lock(current, &head, &flags); <--- deadlock
> >
> > Adding kprobe_busy_begin/end helpers that mark code with fake
> > probe installed to prevent triggering of another kprobe within
> > this code.
> >
> > Using these helpers in kprobe_flush_task, so the probe recursion
> > protection check is hit and the probe is never set to prevent
> > above lockup.
> >
>
> Thanks Jiri!
>
> Ingo, could you pick this up?
Ingo, any chance you could take this one?
thanks,
jirka
next prev parent reply other threads:[~2020-04-28 21:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 16:46 [RFC] kretprobe: Prevent triggering kretprobe from within kprobe_flush_task Jiri Olsa
2020-04-09 9:02 ` Naveen N. Rao
2020-04-09 18:43 ` Jiri Olsa
2020-04-09 12:38 ` Masami Hiramatsu
2020-04-09 12:52 ` Jiri Olsa
2020-04-09 14:16 ` Masami Hiramatsu
2020-04-09 13:16 ` Naveen N. Rao
2020-04-09 14:26 ` Masami Hiramatsu
2020-04-09 14:41 ` Masami Hiramatsu
2020-04-09 18:44 ` Jiri Olsa
2020-04-09 20:13 ` Jiri Olsa
2020-04-10 0:31 ` Masami Hiramatsu
2020-04-14 16:03 ` Jiri Olsa
2020-04-15 9:05 ` [PATCH] " Jiri Olsa
2020-04-16 1:55 ` Masami Hiramatsu
2020-04-16 9:13 ` Jiri Olsa
2020-04-16 13:42 ` Masami Hiramatsu
2020-04-16 14:31 ` [PATCHv2] " Jiri Olsa
2020-04-17 7:38 ` Masami Hiramatsu
2020-04-28 21:36 ` Jiri Olsa [this message]
2020-05-01 2:01 ` Masami Hiramatsu
2020-05-07 10:15 ` Jiri Olsa
2020-04-10 1:31 ` [RFC] " Ziqian SUN (Zamir)
2020-04-14 16:03 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200428213627.GI1476763@krava \
--to=jolsa@redhat.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bibo.mao@intel.com \
--cc=davem@davemloft.net \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@elte.hu \
--cc=naveen.n.rao@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=zsun@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).