* [PATCH] watchdog: iTCO: fix link error
@ 2020-04-28 21:29 Arnd Bergmann
2020-04-28 22:05 ` Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Arnd Bergmann @ 2020-04-28 21:29 UTC (permalink / raw)
To: Guenter Roeck
Cc: Arnd Bergmann, Mika Westerberg, Andy Shevchenko, Lee Jones,
Wim Van Sebroeck, linux-watchdog, linux-kernel
When the MFD driver is a loadable module, the watchdog driver fails
to get linked into the kernel:
drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc':
iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update'
The code is written to support operation without the MFD driver, so
add a Kconfig dependency that allows this, while disallowing the watchdog
to be built-in when the MFD driver is a module.
Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/watchdog/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 66ca69f30f01..67a83578810e 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1217,6 +1217,7 @@ config ITCO_WDT
depends on (X86 || IA64) && PCI
select WATCHDOG_CORE
depends on I2C || I2C=n
+ depends on MFD_INTEL_PMC_BXT || !MFD_INTEL_PMC_BXT
select LPC_ICH if !EXPERT
select I2C_I801 if !EXPERT && I2C
---help---
--
2.26.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: iTCO: fix link error
2020-04-28 21:29 [PATCH] watchdog: iTCO: fix link error Arnd Bergmann
@ 2020-04-28 22:05 ` Andy Shevchenko
2020-04-29 12:26 ` Guenter Roeck
2020-04-29 12:52 ` Mika Westerberg
2 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-04-28 22:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Guenter Roeck, Mika Westerberg, Andy Shevchenko, Lee Jones,
Wim Van Sebroeck, linux-watchdog, Linux Kernel Mailing List
On Wed, Apr 29, 2020 at 12:33 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> When the MFD driver is a loadable module, the watchdog driver fails
> to get linked into the kernel:
>
> drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc':
> iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update'
>
> The code is written to support operation without the MFD driver, so
> add a Kconfig dependency that allows this, while disallowing the watchdog
> to be built-in when the MFD driver is a module.
>
> Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 66ca69f30f01..67a83578810e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1217,6 +1217,7 @@ config ITCO_WDT
> depends on (X86 || IA64) && PCI
> select WATCHDOG_CORE
> depends on I2C || I2C=n
> + depends on MFD_INTEL_PMC_BXT || !MFD_INTEL_PMC_BXT
Can we use same format as for I2C?
> select LPC_ICH if !EXPERT
> select I2C_I801 if !EXPERT && I2C
> ---help---
> --
> 2.26.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: iTCO: fix link error
2020-04-28 21:29 [PATCH] watchdog: iTCO: fix link error Arnd Bergmann
2020-04-28 22:05 ` Andy Shevchenko
@ 2020-04-29 12:26 ` Guenter Roeck
2020-04-29 12:52 ` Mika Westerberg
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2020-04-29 12:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Mika Westerberg, Andy Shevchenko, Lee Jones, Wim Van Sebroeck,
linux-watchdog, linux-kernel
On 4/28/20 2:29 PM, Arnd Bergmann wrote:
> When the MFD driver is a loadable module, the watchdog driver fails
> to get linked into the kernel:
>
> drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc':
> iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update'
>
> The code is written to support operation without the MFD driver, so
> add a Kconfig dependency that allows this, while disallowing the watchdog
> to be built-in when the MFD driver is a module.
>
> Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/watchdog/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 66ca69f30f01..67a83578810e 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1217,6 +1217,7 @@ config ITCO_WDT
> depends on (X86 || IA64) && PCI
> select WATCHDOG_CORE
> depends on I2C || I2C=n
> + depends on MFD_INTEL_PMC_BXT || !MFD_INTEL_PMC_BXT
> select LPC_ICH if !EXPERT
> select I2C_I801 if !EXPERT && I2C
> ---help---
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] watchdog: iTCO: fix link error
2020-04-28 21:29 [PATCH] watchdog: iTCO: fix link error Arnd Bergmann
2020-04-28 22:05 ` Andy Shevchenko
2020-04-29 12:26 ` Guenter Roeck
@ 2020-04-29 12:52 ` Mika Westerberg
2 siblings, 0 replies; 4+ messages in thread
From: Mika Westerberg @ 2020-04-29 12:52 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Guenter Roeck, Andy Shevchenko, Lee Jones, Wim Van Sebroeck,
linux-watchdog, linux-kernel
On Tue, Apr 28, 2020 at 11:29:11PM +0200, Arnd Bergmann wrote:
> When the MFD driver is a loadable module, the watchdog driver fails
> to get linked into the kernel:
>
> drivers/watchdog/iTCO_wdt.o: In function `update_no_reboot_bit_pmc':
> iTCO_wdt.c:(.text+0x54f): undefined reference to `intel_pmc_gcr_update'
>
> The code is written to support operation without the MFD driver, so
> add a Kconfig dependency that allows this, while disallowing the watchdog
> to be built-in when the MFD driver is a module.
>
> Fixes: 25f1ca31e230 ("platform/x86: intel_pmc_ipc: Convert to MFD")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-29 12:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-28 21:29 [PATCH] watchdog: iTCO: fix link error Arnd Bergmann
2020-04-28 22:05 ` Andy Shevchenko
2020-04-29 12:26 ` Guenter Roeck
2020-04-29 12:52 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).