linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Akira Shimahara <akira215corp@gmail.com>
Cc: zbr@ioremap.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] w1_therm: Optimizing read timing by checking device resolution. Updating documentation
Date: Wed, 29 Apr 2020 15:47:28 +0200	[thread overview]
Message-ID: <20200429134728.GC2132814@kroah.com> (raw)
In-Reply-To: <20200429133320.140458-1-akira215corp@gmail.com>

On Wed, Apr 29, 2020 at 03:33:20PM +0200, Akira Shimahara wrote:
> Patch for enhacement of w1_therm module. Added features :
>  - Optimized conversion time regarding to device resolution
>  - Dedicated sysfs entry for, resolution set/get, eeprom save/restore,
> 	and additionnal temperature entry to ease user data collect.
>  - Code optimization to mitigate bus traffic

When you have to list different things you did in a single patch, that's
a huge sign it needs to be multiple patches.  Please break this up into
one-logical-change-per-patch.

thanks,

greg k-h

  reply	other threads:[~2020-04-29 13:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 13:33 [PATCH v3 3/5] w1_therm: Optimizing read timing by checking device resolution. Updating documentation Akira Shimahara
2020-04-29 13:47 ` Greg KH [this message]
2020-04-29 13:59   ` Akira shimahara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429134728.GC2132814@kroah.com \
    --to=greg@kroah.com \
    --cc=akira215corp@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).