From: Akira shimahara <akira215corp@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: zbr@ioremap.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] w1_therm: Optimizing read timing by checking device resolution. Updating documentation
Date: Wed, 29 Apr 2020 15:59:14 +0200 [thread overview]
Message-ID: <972773563574efe8db63d2fc245c822cc420dde5.camel@gmail.com> (raw)
In-Reply-To: <20200429134728.GC2132814@kroah.com>
Le mercredi 29 avril 2020 à 15:47 +0200, Greg KH a écrit :
> On Wed, Apr 29, 2020 at 03:33:20PM +0200, Akira Shimahara wrote:
> > Patch for enhacement of w1_therm module. Added features :
> > - Optimized conversion time regarding to device resolution
> > - Dedicated sysfs entry for, resolution set/get, eeprom
> > save/restore,
> > and additionnal temperature entry to ease user data collect.
> > - Code optimization to mitigate bus traffic
>
> When you have to list different things you did in a single patch,
> that's
> a huge sign it needs to be multiple patches. Please break this up
> into
> one-logical-change-per-patch.
>
I will try but this block is hard to split as everything is connected.
I will separate it, but some some patches will be useless if applied
without the next ones.
> thanks,
>
> greg k-h
prev parent reply other threads:[~2020-04-29 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 13:33 [PATCH v3 3/5] w1_therm: Optimizing read timing by checking device resolution. Updating documentation Akira Shimahara
2020-04-29 13:47 ` Greg KH
2020-04-29 13:59 ` Akira shimahara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=972773563574efe8db63d2fc245c822cc420dde5.camel@gmail.com \
--to=akira215corp@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).