linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Kees Cook <keescook@chromium.org>
Subject: Re: Remaining randconfig objtool warnings, linux-next-20200428
Date: Wed, 29 Apr 2020 14:18:46 -0500	[thread overview]
Message-ID: <20200429191846.hcfc7t4zusdudtej@treble> (raw)
In-Reply-To: <20200428161044.caamvx67t2z4t6vd@treble>

On Tue, Apr 28, 2020 at 11:10:44AM -0500, Josh Poimboeuf wrote:
> > ==> build/x86/0x2EA4CE4F_defconfig/log <==
> > kernel/kcov.o: warning: objtool: write_comp_data()+0x1b: call to check_kcov_mode() with UACCESS enabled
> > kernel/kcov.o: warning: objtool: __sanitizer_cov_trace_pc()+0x15: call to check_kcov_mode() with UACCESS enabled

From: Josh Poimboeuf <jpoimboe@redhat.com>
Subject: [PATCH] objtool: Add check_kcov_mode() to the uaccess safelist

check_kcov_mode() is called by write_comp_data() and
__sanitizer_cov_trace_pc(), which are already on the uaccess safe list.
Might as well add check_kcov_mode() to the party.

This fixes the following warnings:

  kernel/kcov.o: warning: objtool: __sanitizer_cov_trace_pc()+0x15: call to check_kcov_mode() with UACCESS enabled
  kernel/kcov.o: warning: objtool: write_comp_data()+0x1b: call to check_kcov_mode() with UACCESS enabled

Reported-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
 tools/objtool/check.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 0c732d586924..fec890547e04 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -516,6 +516,7 @@ static const char *uaccess_safe_builtin[] = {
 	"__tsan_write16",
 	/* KCOV */
 	"write_comp_data",
+	"check_kcov_mode",
 	"__sanitizer_cov_trace_pc",
 	"__sanitizer_cov_trace_const_cmp1",
 	"__sanitizer_cov_trace_const_cmp2",
-- 
2.21.1


  parent reply	other threads:[~2020-04-29 19:18 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 14:49 Remaining randconfig objtool warnings, linux-next-20200428 Arnd Bergmann
2020-04-28 16:10 ` Josh Poimboeuf
2020-04-28 19:11   ` Kees Cook
2020-04-28 20:19   ` Arnd Bergmann
2020-04-28 20:38     ` Josh Poimboeuf
2020-04-28 21:55       ` Peter Zijlstra
2020-04-28 22:03         ` Josh Poimboeuf
2020-04-28 22:33           ` Peter Zijlstra
2020-04-28 22:48             ` Josh Poimboeuf
2020-04-28 23:08               ` Josh Poimboeuf
2020-04-29 18:55   ` Josh Poimboeuf
2020-04-29 22:46     ` Arnd Bergmann
2020-04-29 23:01       ` Josh Poimboeuf
2020-04-29 23:11       ` Josh Poimboeuf
2020-04-29 23:28         ` Josh Poimboeuf
2020-04-30 13:41           ` Arnd Bergmann
2020-04-30 14:33             ` Josh Poimboeuf
2020-04-30 19:46               ` Josh Poimboeuf
2020-04-30 20:59                 ` Arnd Bergmann
2020-04-30 21:10                   ` Josh Poimboeuf
2020-04-30 21:08                 ` Josh Poimboeuf
2020-04-30 23:02                   ` Josh Poimboeuf
2020-04-29 19:18   ` Josh Poimboeuf [this message]
2020-05-01 12:23     ` Peter Zijlstra
2020-04-30 14:05 ` Arnd Bergmann
2020-05-01  0:28   ` Josh Poimboeuf
2020-05-01 11:41     ` Arnd Bergmann
2020-05-01 17:16       ` Peter Zijlstra
2020-05-01 12:27     ` Peter Zijlstra
2020-05-01  1:07   ` Josh Poimboeuf
2020-05-01 11:18     ` Arnd Bergmann
2020-05-01 12:33     ` Peter Zijlstra
2020-05-01 13:08       ` Arnd Bergmann
2020-05-01 15:49       ` Josh Poimboeuf
2020-05-01 17:21   ` Arnd Bergmann
2020-05-01 17:26     ` Peter Zijlstra
2020-05-01 17:50       ` Josh Poimboeuf
2020-05-01 19:47         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429191846.hcfc7t4zusdudtej@treble \
    --to=jpoimboe@redhat.com \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).