linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Remaining randconfig objtool warnings, linux-next-20200428
Date: Fri, 1 May 2020 14:27:43 +0200	[thread overview]
Message-ID: <20200501122743.GB3762@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200501002858.4wuiqqv5o32jcvxf@treble>

On Thu, Apr 30, 2020 at 07:28:58PM -0500, Josh Poimboeuf wrote:
> On Thu, Apr 30, 2020 at 04:05:07PM +0200, Arnd Bergmann wrote:
> > lib/locking-selftest.o: warning: objtool: locking_selftest()+0x117f: PUSHF stack exhausted
> > lib/locking-selftest.o: warning: objtool: ww_tests()+0x1083: PUSHF stack exhausted
> 
> Peter,
> 
> These functions have a bunch of irqs_disabled() checks, which means a
> bunch of PUSHFs with no POPFs.
> 
> Am I reading it correctly that objtool assumes PUSHF is always paired
> with POPF?  irqs_disabled() doesn't do that.

Right, it sorta does. I wonder why this shows up with GCC-10 though, and
not before.

Anyway, the sneaky fix here would be something like this.

diff --git a/lib/locking-selftest.c b/lib/locking-selftest.c
index 14f44f59e733..510656c776d9 100644
--- a/lib/locking-selftest.c
+++ b/lib/locking-selftest.c
@@ -1138,7 +1138,7 @@ static void dotest(void (*testcase_fn)(void), int expected, int lockclass_mask)
 {
 	unsigned long saved_preempt_count = preempt_count();
 
-	WARN_ON(irqs_disabled());
+	lockdep_assert_irqs_enabled();
 
 	testcase_fn();
 	/*

  parent reply	other threads:[~2020-05-01 12:27 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28 14:49 Remaining randconfig objtool warnings, linux-next-20200428 Arnd Bergmann
2020-04-28 16:10 ` Josh Poimboeuf
2020-04-28 19:11   ` Kees Cook
2020-04-28 20:19   ` Arnd Bergmann
2020-04-28 20:38     ` Josh Poimboeuf
2020-04-28 21:55       ` Peter Zijlstra
2020-04-28 22:03         ` Josh Poimboeuf
2020-04-28 22:33           ` Peter Zijlstra
2020-04-28 22:48             ` Josh Poimboeuf
2020-04-28 23:08               ` Josh Poimboeuf
2020-04-29 18:55   ` Josh Poimboeuf
2020-04-29 22:46     ` Arnd Bergmann
2020-04-29 23:01       ` Josh Poimboeuf
2020-04-29 23:11       ` Josh Poimboeuf
2020-04-29 23:28         ` Josh Poimboeuf
2020-04-30 13:41           ` Arnd Bergmann
2020-04-30 14:33             ` Josh Poimboeuf
2020-04-30 19:46               ` Josh Poimboeuf
2020-04-30 20:59                 ` Arnd Bergmann
2020-04-30 21:10                   ` Josh Poimboeuf
2020-04-30 21:08                 ` Josh Poimboeuf
2020-04-30 23:02                   ` Josh Poimboeuf
2020-04-29 19:18   ` Josh Poimboeuf
2020-05-01 12:23     ` Peter Zijlstra
2020-04-30 14:05 ` Arnd Bergmann
2020-05-01  0:28   ` Josh Poimboeuf
2020-05-01 11:41     ` Arnd Bergmann
2020-05-01 17:16       ` Peter Zijlstra
2020-05-01 12:27     ` Peter Zijlstra [this message]
2020-05-01  1:07   ` Josh Poimboeuf
2020-05-01 11:18     ` Arnd Bergmann
2020-05-01 12:33     ` Peter Zijlstra
2020-05-01 13:08       ` Arnd Bergmann
2020-05-01 15:49       ` Josh Poimboeuf
2020-05-01 17:21   ` Arnd Bergmann
2020-05-01 17:26     ` Peter Zijlstra
2020-05-01 17:50       ` Josh Poimboeuf
2020-05-01 19:47         ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200501122743.GB3762@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=arnd@arndb.de \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).