* [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable
@ 2020-04-30 12:17 Jason Yan
2020-05-06 4:43 ` [EXT] " Manish Rangankar
2020-05-08 2:54 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-04-30 12:17 UTC (permalink / raw)
To: QLogic-Storage-Upstream, jejb, martin.petersen, mrangankar,
linux-scsi, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
bool variable
drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
bool variable
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/scsi/qedi/qedi_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 4dd965860c98..46584e16d635 100644
--- a/drivers/scsi/qedi/qedi_main.c
+++ b/drivers/scsi/qedi/qedi_main.c
@@ -1306,13 +1306,13 @@ static irqreturn_t qedi_msix_handler(int irq, void *dev_id)
"process already running\n");
}
- if (qedi_fp_has_work(fp) == 0)
+ if (!qedi_fp_has_work(fp))
qed_sb_update_sb_idx(fp->sb_info);
/* Check for more work */
rmb();
- if (qedi_fp_has_work(fp) == 0)
+ if (!qedi_fp_has_work(fp))
qed_sb_ack(fp->sb_info, IGU_INT_ENABLE, 1);
else
goto process_again;
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable
2020-04-30 12:17 [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable Jason Yan
@ 2020-05-06 4:43 ` Manish Rangankar
2020-05-08 2:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Manish Rangankar @ 2020-05-06 4:43 UTC (permalink / raw)
To: Jason Yan, QLogic-Storage-Upstream, jejb, martin.petersen,
linux-scsi, linux-kernel
> -----Original Message-----
> From: Jason Yan <yanaijie@huawei.com>
> Sent: Thursday, April 30, 2020 5:47 PM
> To: QLogic-Storage-Upstream@cavium.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; Manish Rangankar
> <mrangankar@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Jason Yan <yanaijie@huawei.com>
> Subject: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool
> variable
>
> External Email
>
> ----------------------------------------------------------------------
> Fix the following coccicheck warning:
>
> drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
> bool variable
> drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/scsi/qedi/qedi_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
> index 4dd965860c98..46584e16d635 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1306,13 +1306,13 @@ static irqreturn_t qedi_msix_handler(int irq,
> void *dev_id)
> "process already running\n");
> }
>
> - if (qedi_fp_has_work(fp) == 0)
> + if (!qedi_fp_has_work(fp))
> qed_sb_update_sb_idx(fp->sb_info);
>
> /* Check for more work */
> rmb();
>
> - if (qedi_fp_has_work(fp) == 0)
> + if (!qedi_fp_has_work(fp))
> qed_sb_ack(fp->sb_info, IGU_INT_ENABLE, 1);
> else
> goto process_again;
> --
Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable
2020-04-30 12:17 [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable Jason Yan
2020-05-06 4:43 ` [EXT] " Manish Rangankar
@ 2020-05-08 2:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2020-05-08 2:54 UTC (permalink / raw)
To: jejb, Jason Yan, QLogic-Storage-Upstream, linux-scsi, mrangankar,
linux-kernel
Cc: Martin K . Petersen
On Thu, 30 Apr 2020 20:17:06 +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/scsi/qedi/qedi_main.c:1309:5-25: WARNING: Comparison of 0/1 to
> bool variable
> drivers/scsi/qedi/qedi_main.c:1315:5-25: WARNING: Comparison of 0/1 to
> bool variable
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: qedi: Remove comparison of 0/1 to bool variable
https://git.kernel.org/mkp/scsi/c/9187745ceec6
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-08 2:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 12:17 [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable Jason Yan
2020-05-06 4:43 ` [EXT] " Manish Rangankar
2020-05-08 2:54 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).