From: Johannes Weiner <hannes@cmpxchg.org>
To: Shakeel Butt <shakeelb@google.com>
Cc: Roman Gushchin <guro@fb.com>, Michal Hocko <mhocko@kernel.org>,
Greg Thelen <gthelen@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memcg: oom: ignore oom warnings from memory.max
Date: Thu, 30 Apr 2020 15:29:07 -0400 [thread overview]
Message-ID: <20200430192907.GA2436@cmpxchg.org> (raw)
In-Reply-To: <20200430182712.237526-1-shakeelb@google.com>
On Thu, Apr 30, 2020 at 11:27:12AM -0700, Shakeel Butt wrote:
> Lowering memory.max can trigger an oom-kill if the reclaim does not
> succeed. However if oom-killer does not find a process for killing, it
> dumps a lot of warnings.
>
> Deleting a memcg does not reclaim memory from it and the memory can
> linger till there is a memory pressure. One normal way to proactively
> reclaim such memory is to set memory.max to 0 just before deleting the
> memcg. However if some of the memcg's memory is pinned by others, this
> operation can trigger an oom-kill without any process and thus can log a
> lot un-needed warnings. So, ignore all such warnings from memory.max.
Can't you set memory.high=0 instead? It does the reclaim portion of
memory.max, without the actual OOM killing that causes you problems.
next prev parent reply other threads:[~2020-04-30 19:29 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 18:27 [PATCH] memcg: oom: ignore oom warnings from memory.max Shakeel Butt
2020-04-30 19:06 ` Roman Gushchin
2020-04-30 19:30 ` Johannes Weiner
2020-04-30 20:23 ` Roman Gushchin
2020-04-30 19:31 ` Shakeel Butt
2020-04-30 19:29 ` Johannes Weiner [this message]
2020-04-30 20:20 ` Shakeel Butt
2020-05-04 6:57 ` Michal Hocko
2020-05-04 13:54 ` Shakeel Butt
2020-05-01 1:39 ` Yafang Shao
2020-05-01 2:04 ` Shakeel Butt
2020-05-01 2:12 ` Yafang Shao
2020-05-04 7:03 ` Michal Hocko
2020-05-04 7:26 ` Yafang Shao
2020-05-04 7:35 ` Michal Hocko
2020-05-04 7:40 ` Yafang Shao
2020-05-04 8:03 ` Michal Hocko
2020-05-04 6:56 ` Michal Hocko
2020-05-04 13:54 ` Shakeel Butt
2020-05-04 14:11 ` Michal Hocko
2020-05-04 14:53 ` Shakeel Butt
2020-05-04 15:00 ` Michal Hocko
2020-05-04 15:35 ` Shakeel Butt
2020-05-04 15:39 ` Yafang Shao
2020-05-04 16:06 ` Michal Hocko
2020-05-04 19:23 ` Shakeel Butt
2020-05-05 7:13 ` Michal Hocko
2020-05-05 15:03 ` Shakeel Butt
2020-05-05 16:57 ` Johannes Weiner
2020-05-05 15:27 ` Johannes Weiner
2020-05-05 15:35 ` Shakeel Butt
2020-05-05 15:49 ` Michal Hocko
2020-05-05 16:40 ` Johannes Weiner
2020-05-04 14:20 ` Tetsuo Handa
2020-05-04 14:57 ` Shakeel Butt
2020-05-04 15:44 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430192907.GA2436@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=guro@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).