From: Christoph Hellwig <hch@infradead.org>
To: Denis Efremov <efremov@linux.com>
Cc: linux-block@vger.kernel.org, Willy Tarreau <w@1wt.eu>,
Christoph Hellwig <hch@infradead.org>,
Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] floppy: add FD_AUTODETECT_SIZE define for struct floppy_drive_params
Date: Fri, 1 May 2020 08:36:00 -0700 [thread overview]
Message-ID: <20200501153600.GC12469@infradead.org> (raw)
In-Reply-To: <20200501134416.72248-3-efremov@linux.com>
On Fri, May 01, 2020 at 04:44:14PM +0300, Denis Efremov wrote:
> Use FD_AUTODETECT_SIZE for autodetect buffer size in struct
> floppy_drive_params instead of a magic number.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-05-01 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 13:44 [PATCH v3 0/4] floppy: suppress UBSAN warning in setup_rw_floppy() Denis Efremov
2020-05-01 13:44 ` [PATCH v3 1/4] floppy: use print_hex_dump() in setup_DMA() Denis Efremov
2020-05-01 15:35 ` Christoph Hellwig
2020-05-01 13:44 ` [PATCH v3 2/4] floppy: add FD_AUTODETECT_SIZE define for struct floppy_drive_params Denis Efremov
2020-05-01 15:36 ` Christoph Hellwig [this message]
2020-05-01 13:44 ` [PATCH v3 3/4] floppy: add defines for sizes of cmd & reply buffers of floppy_raw_cmd Denis Efremov
2020-05-01 13:44 ` [PATCH v3 4/4] floppy: suppress UBSAN warning in setup_rw_floppy() Denis Efremov
2020-05-01 18:02 ` [PATCH v3 0/4] " Joe Perches
2020-05-01 18:22 ` Denis Efremov
2020-05-01 18:31 ` Joe Perches
2020-05-06 7:33 ` Denis Efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501153600.GC12469@infradead.org \
--to=hch@infradead.org \
--cc=efremov@linux.com \
--cc=joe@perches.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).