* [Patch] mtd: set master partition panic write flag
@ 2020-05-04 23:54 Kamal Dasu
2020-06-13 6:49 ` Kamal Dasu
0 siblings, 1 reply; 3+ messages in thread
From: Kamal Dasu @ 2020-05-04 23:54 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: bcm-kernel-feedback-list, Kamal Dasu, linux-mtd, linux-kernel
Check and set master panic write flag so that low level drivers
can use it to take required action to ensure oops data gets written
to assigned mtdoops device partition.
Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
---
drivers/mtd/mtdcore.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 2916674208b3..7e37ed2f38ea 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -1235,8 +1235,8 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
return -EROFS;
if (!len)
return 0;
- if (!mtd->oops_panic_write)
- mtd->oops_panic_write = true;
+ if (!master->oops_panic_write)
+ master->oops_panic_write = true;
return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
retlen, buf);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] mtd: set master partition panic write flag
2020-05-04 23:54 [Patch] mtd: set master partition panic write flag Kamal Dasu
@ 2020-06-13 6:49 ` Kamal Dasu
2020-06-15 7:22 ` Miquel Raynal
0 siblings, 1 reply; 3+ messages in thread
From: Kamal Dasu @ 2020-06-13 6:49 UTC (permalink / raw)
To: Miquel Raynal, Richard Weinberger, Vignesh Raghavendra
Cc: bcm-kernel-feedback-list, linux-mtd, linux-kernel
Can you please accept this if there are no objections.
Kamal
> On May 4, 2020, at 7:54 PM, Kamal Dasu <kdasu.kdev@gmail.com> wrote:
>
> Check and set master panic write flag so that low level drivers
> can use it to take required action to ensure oops data gets written
> to assigned mtdoops device partition.
>
> Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> ---
> drivers/mtd/mtdcore.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index 2916674208b3..7e37ed2f38ea 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1235,8 +1235,8 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
> return -EROFS;
> if (!len)
> return 0;
> - if (!mtd->oops_panic_write)
> - mtd->oops_panic_write = true;
> + if (!master->oops_panic_write)
> + master->oops_panic_write = true;
>
> return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> retlen, buf);
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] mtd: set master partition panic write flag
2020-06-13 6:49 ` Kamal Dasu
@ 2020-06-15 7:22 ` Miquel Raynal
0 siblings, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2020-06-15 7:22 UTC (permalink / raw)
To: Kamal Dasu
Cc: Richard Weinberger, Vignesh Raghavendra,
bcm-kernel-feedback-list, linux-mtd, linux-kernel
Hi Kamal,
Kamal Dasu <kdasu.kdev@gmail.com> wrote on Sat, 13 Jun 2020 02:49:31
-0400:
> Can you please accept this if there are no objections.
>
> Kamal
>
> > On May 4, 2020, at 7:54 PM, Kamal Dasu <kdasu.kdev@gmail.com> wrote:
> >
> > Check and set master panic write flag so that low level drivers
> > can use it to take required action to ensure oops data gets written
> > to assigned mtdoops device partition.
> >
> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> > ---
> > drivers/mtd/mtdcore.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 2916674208b3..7e37ed2f38ea 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -1235,8 +1235,8 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
> > return -EROFS;
> > if (!len)
> > return 0;
> > - if (!mtd->oops_panic_write)
> > - mtd->oops_panic_write = true;
> > + if (!master->oops_panic_write)
> > + master->oops_panic_write = true;
> >
> > return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> > retlen, buf);
> > --
> > 2.17.1
> >
I thing we missed it. However, shouldn't we have a Cc:/Fixes: pair of
tags here? We could send it as part of a fixes PR then.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-15 7:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 23:54 [Patch] mtd: set master partition panic write flag Kamal Dasu
2020-06-13 6:49 ` Kamal Dasu
2020-06-15 7:22 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).