* [PATCH v6 1/5] ARM: dts: add Protonic PRTI6Q board
2020-04-21 12:40 [PATCH v6 0/5] mainline Protonic boards Oleksij Rempel
@ 2020-04-21 12:40 ` Oleksij Rempel
2020-04-22 7:19 ` Marco Felsch
2020-04-21 12:40 ` [PATCH v6 2/5] ARM: dts: add Protonic WD2 board Oleksij Rempel
` (3 subsequent siblings)
4 siblings, 1 reply; 12+ messages in thread
From: Oleksij Rempel @ 2020-04-21 12:40 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, Rob Herring, David Jander, devicetree,
Fabio Estevam, linux-arm-kernel, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team
Protonic PRTI6Q is a development board and a base class for different
specific customer application boards based on the i.MX6 family of SoCs,
developed by Protonic Holland.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx6q-prti6q.dts | 529 ++++++++++++++++++++++++++
arch/arm/boot/dts/imx6qdl-prti6q.dtsi | 174 +++++++++
3 files changed, 704 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6q-prti6q.dts
create mode 100644 arch/arm/boot/dts/imx6qdl-prti6q.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e8dd992013973..206a36a50575e 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -538,6 +538,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-pico-nymph.dtb \
imx6q-pico-pi.dtb \
imx6q-pistachio.dtb \
+ imx6q-prti6q.dtb \
imx6q-rex-pro.dtb \
imx6q-sabreauto.dtb \
imx6q-sabrelite.dtb \
diff --git a/arch/arm/boot/dts/imx6q-prti6q.dts b/arch/arm/boot/dts/imx6q-prti6q.dts
new file mode 100644
index 0000000000000..b0d597a7d59cd
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-prti6q.dts
@@ -0,0 +1,529 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2014 Protonic Holland
+ */
+
+/dts-v1/;
+#include "imx6q.dtsi"
+#include "imx6qdl-prti6q.dtsi"
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/sound/fsl-imx-audmux.h>
+
+/ {
+ model = "Protonic PRTI6Q board";
+ compatible = "prt,prti6q", "fsl,imx6q";
+
+ memory@10000000 {
+ device_type = "memory";
+ reg = <0x10000000 0xf0000000>;
+ };
+
+ backlight_lcd: backlight-lcd {
+ compatible = "pwm-backlight";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_backlight>;
+ pwms = <&pwm1 0 5000000>;
+ brightness-levels = <0 16 64 255>;
+ num-interpolated-steps = <16>;
+ default-brightness-level = <16>;
+ power-supply = <®_3v3>;
+ enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+ };
+
+ can3_25m_osc: can3-25m-osc {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <25000000>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_leds>;
+
+ led-debug0 {
+ function = LED_FUNCTION_STATUS;
+ gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+
+ led-debug1 {
+ function = LED_FUNCTION_SD;
+ gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "disk-activity";
+ };
+ };
+
+ panel {
+ compatible = "kyo,tcg121xglp";
+ backlight = <&backlight_lcd>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&lvds0_out>;
+ };
+ };
+ };
+
+ reg_wifi: regulator-wifi {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wifi_npd>;
+ enable-active-high;
+ gpio = <&gpio1 26 GPIO_ACTIVE_HIGH>;
+ regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-name = "regulator-WL12xx";
+ startup-delay-us = <70000>;
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "prti6q-sgtl5000";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Line", "Line In Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "External Speaker";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "External Speaker", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&ssi1>;
+ system-clock-frequency = <0>;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&sgtl5000>;
+ bitclock-master;
+ frame-master;
+ };
+ };
+
+ sound-spdif {
+ compatible = "fsl,imx-audio-spdif";
+ model = "imx-spdif";
+ spdif-controller = <&spdif>;
+ spdif-in;
+ spdif-out;
+ };
+};
+
+&audmux {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_audmux>;
+ status = "okay";
+
+ mux_ssi1 {
+ fsl,audmux-port = <0>;
+ fsl,port-config = <
+ IMX_AUDMUX_V2_PTCR_SYN 0
+ IMX_AUDMUX_V2_PTCR_TFSEL(2) 0
+ IMX_AUDMUX_V2_PTCR_TCSEL(2) 0
+ IMX_AUDMUX_V2_PTCR_TFSDIR 0
+ IMX_AUDMUX_V2_PTCR_TCLKDIR IMX_AUDMUX_V2_PDCR_RXDSEL(2)
+ >;
+ };
+
+ mux_pins3 {
+ fsl,audmux-port = <2>;
+ fsl,port-config = <
+ IMX_AUDMUX_V2_PTCR_SYN IMX_AUDMUX_V2_PDCR_RXDSEL(0)
+ 0 IMX_AUDMUX_V2_PDCR_TXRXEN
+ >;
+ };
+};
+
+&can2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_can2>;
+ status = "okay";
+};
+
+&ecspi1 {
+ cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi1>;
+ status = "okay";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ };
+};
+
+&ecspi2 {
+ cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio4 25 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
+ status = "okay";
+
+ can@0 {
+ compatible = "microchip,mcp2515";
+ reg = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_can3>;
+ clocks = <&can3_25m_osc>;
+ interrupts-extended = <&gpio3 20 IRQ_TYPE_LEVEL_LOW>;
+ spi-max-frequency = <5000000>;
+ };
+
+ adc@1 {
+ compatible = "ti,adc128s052";
+ reg = <1>;
+ spi-max-frequency = <2000000>;
+ vref-supply = <®_3v3>;
+ };
+};
+
+&ecspi3 {
+ cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi3>;
+ status = "okay";
+};
+
+&fec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_enet>;
+ phy-mode = "rgmii-id";
+ phy-handle = <&rgmii_phy>;
+ status = "okay";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* Microchip KSZ9031RNX PHY */
+ rgmii_phy: ethernet-phy@0 {
+ reg = <0>;
+ interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+ reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+ reset-assert-us = <10000>;
+ reset-deassert-us = <300>;
+ };
+ };
+};
+
+&hdmi {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_hdmi>;
+ ddc-i2c-bus = <&i2c2>;
+ status = "okay";
+};
+
+&i2c1 {
+ sgtl5000: audio-codec@a {
+ compatible = "fsl,sgtl5000";
+ reg = <0xa>;
+ #sound-dai-cells = <0>;
+ clocks = <&clks 201>;
+ VDDA-supply = <®_3v3>;
+ VDDIO-supply = <®_3v3>;
+ VDDD-supply = <®_1v8>;
+ };
+};
+
+/* DDC */
+&i2c2 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c2>;
+ status = "okay";
+};
+
+&i2c3 {
+ adc@49 {
+ compatible = "ti,ads1015";
+ reg = <0x49>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* can2_l */
+ channel@4 {
+ reg = <4>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+
+ /* can2_h */
+ channel@5 {
+ reg = <5>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+
+ /* can1_l */
+ channel@6 {
+ reg = <6>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+
+ /* can1_h */
+ channel@7 {
+ reg = <7>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+ };
+};
+
+&pcie {
+ status = "okay";
+};
+
+&pwm1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm1>;
+ status = "okay";
+};
+
+&ldb {
+ status = "okay";
+
+ lvds-channel@0 {
+ status = "okay";
+
+ port@4 {
+ reg = <4>;
+
+ lvds0_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+};
+
+&sata {
+ status = "okay";
+};
+
+&snvs_poweroff {
+ status = "okay";
+};
+
+&spdif {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_spdif>;
+ status = "okay";
+};
+
+&ssi1 {
+ #sound-dai-cells = <0>;
+ fsl,mode = "ac97-slave";
+ status = "okay";
+};
+
+&uart2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart2>;
+ status = "okay";
+};
+
+&uart5 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart5>;
+ status = "okay";
+};
+
+&usbotg {
+ pinctrl-0 = <&pinctrl_usbotg &pinctrl_usbotg_id>;
+};
+
+&usdhc2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc2>;
+ non-removable;
+ vmmc-supply = <®_wifi>;
+ cap-power-off-card;
+ keep-power-in-suspend;
+ status = "okay";
+
+ wifi {
+ compatible = "ti,wl1271";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wifi>;
+ interrupts-extended = <&gpio1 30 IRQ_TYPE_LEVEL_HIGH>;
+ ref-clock-frequency = "38400000";
+ tcxo-clock-frequency = "19200000";
+ };
+};
+
+&iomuxc {
+ pinctrl_audmux: audmuxgrp {
+ fsl,pins = <
+ MX6QDL_PAD_CSI0_MCLK__CCM_CLKO1 0x030b0
+ MX6QDL_PAD_CSI0_DAT7__AUD3_RXD 0x130b0
+ MX6QDL_PAD_CSI0_DAT4__AUD3_TXC 0x130b0
+ MX6QDL_PAD_CSI0_DAT5__AUD3_TXD 0x110b0
+ MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS 0x130b0
+ >;
+ };
+
+ pinctrl_backlight: backlightgrp {
+ fsl,pins = <
+ MX6QDL_PAD_DISP0_DAT7__GPIO4_IO28 0x1b0b0
+ >;
+ };
+
+ pinctrl_can2: can2grp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x80000000
+ MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x80000000
+ >;
+ };
+
+ pinctrl_can3: can3grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b1
+ >;
+ };
+
+ pinctrl_ecspi1: ecspi1grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D17__ECSPI1_MISO 0x100b1
+ MX6QDL_PAD_EIM_D18__ECSPI1_MOSI 0x100b1
+ MX6QDL_PAD_EIM_D16__ECSPI1_SCLK 0x100b1
+ /* CS */
+ MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x000b1
+ >;
+ };
+
+ pinctrl_ecspi2: ecspi2grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_OE__ECSPI2_MISO 0x100b1
+ MX6QDL_PAD_EIM_CS0__ECSPI2_SCLK 0x100b1
+ MX6QDL_PAD_EIM_CS1__ECSPI2_MOSI 0x100b1
+ MX6QDL_PAD_EIM_RW__GPIO2_IO26 0x000b1
+ >;
+ };
+
+ pinctrl_ecspi2_cs: ecspi2csgrp {
+ fsl,pins = <
+ /* ADC128S022 CS */
+ MX6QDL_PAD_DISP0_DAT4__GPIO4_IO25 0x1b0b1
+ >;
+ };
+
+ pinctrl_ecspi3: ecspi3grp {
+ fsl,pins = <
+ MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK 0x100b1
+ MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI 0x100b1
+ MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO 0x100b1
+ MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x000b1
+ >;
+ };
+
+ pinctrl_enet: enetgrp {
+ fsl,pins = <
+ MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1b030
+ MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1b030
+ MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1b030
+ MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1b030
+ MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1b030
+ MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b030
+ MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x10030
+ MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x10030
+ MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x10030
+ MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x10030
+ MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x10030
+ MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x10030
+ MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x10030
+ MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x10030
+ MX6QDL_PAD_ENET_MDC__ENET_MDC 0x10030
+
+ /* Phy reset */
+ MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
+ MX6QDL_PAD_ENET_TX_EN__GPIO1_IO28 0x1b0b1
+ >;
+ };
+
+ pinctrl_hdmi: hdmigrp {
+ fsl,pins = <
+ /* NOTE: DDC is done via I2C2, so DON'T
+ * configure DDC pins for HDMI!
+ */
+ MX6QDL_PAD_EIM_A25__HDMI_TX_CEC_LINE 0x1f8b0
+ >;
+ };
+
+ /* DDC */
+ pinctrl_i2c2: i2c2grp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b8b1
+ MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b8b1
+ >;
+ };
+
+ pinctrl_leds: ledsgrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
+ MX6QDL_PAD_GPIO_9__GPIO1_IO09 0x1b0b0
+ >;
+ };
+
+ pinctrl_pwm1: pwm1grp {
+ fsl,pins = <
+ MX6QDL_PAD_DISP0_DAT8__PWM1_OUT 0x1b0b0
+ >;
+ };
+
+ pinctrl_spdif: spdifgrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_16__SPDIF_IN 0x1b0b0
+ MX6QDL_PAD_GPIO_19__SPDIF_OUT 0x1b0b0
+ >;
+ };
+
+ pinctrl_uart2: uart2grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D26__UART2_RX_DATA 0x1b0b1
+ MX6QDL_PAD_EIM_D27__UART2_TX_DATA 0x1b0b1
+ MX6QDL_PAD_EIM_D28__UART2_DTE_CTS_B 0x1b0b1
+ MX6QDL_PAD_EIM_D29__UART2_DTE_RTS_B 0x1b0b1
+ >;
+ };
+
+ pinctrl_uart5: uart5grp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_COL1__UART5_TX_DATA 0x1b0b1
+ MX6QDL_PAD_KEY_ROW1__UART5_RX_DATA 0x1b0b1
+ >;
+ };
+
+ pinctrl_usbotg_id: usbotgidgrp {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x1f058
+ >;
+ };
+
+ pinctrl_usdhc2: usdhc2grp {
+ fsl,pins = <
+ MX6QDL_PAD_SD2_CMD__SD2_CMD 0x170b9
+ MX6QDL_PAD_SD2_CLK__SD2_CLK 0x100b9
+ MX6QDL_PAD_SD2_DAT0__SD2_DATA0 0x170b9
+ MX6QDL_PAD_SD2_DAT1__SD2_DATA1 0x170b9
+ MX6QDL_PAD_SD2_DAT2__SD2_DATA2 0x170b9
+ MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x170b9
+ >;
+ };
+
+ pinctrl_wifi: wifigrp {
+ fsl,pins = <
+ /* WL12xx IRQ */
+ MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x10880
+ >;
+ };
+
+ pinctrl_wifi_npd: wifinpd {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b8b0
+ >;
+ };
+};
diff --git a/arch/arm/boot/dts/imx6qdl-prti6q.dtsi b/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
new file mode 100644
index 0000000000000..7090a7ca83d8d
--- /dev/null
+++ b/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
@@ -0,0 +1,174 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2014 Protonic Holland
+ */
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+
+/ {
+ chosen {
+ stdout-path = &uart4;
+ };
+
+ reg_1v8: regulator-1v8 {
+ compatible = "regulator-fixed";
+ regulator-name = "1v8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ reg_3v3: regulator-3v3 {
+ compatible = "regulator-fixed";
+ regulator-name = "3v3";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-always-on;
+ };
+
+ reg_usb_h1_vbus: regulator-h1-vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "h1-vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ };
+
+ reg_usb_otg_vbus: regulator-otg-vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "otg-vbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+};
+
+&can1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_can1>;
+ status = "okay";
+};
+
+&i2c1 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c1>;
+ status = "okay";
+};
+
+&i2c3 {
+ clock-frequency = <100000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c3>;
+ status = "okay";
+
+ temperature-sensor@70 {
+ compatible = "ti,tmp103";
+ reg = <0x70>;
+ };
+};
+
+&uart4 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart4>;
+ status = "okay";
+};
+
+&usbh1 {
+ vbus-supply = <®_usb_h1_vbus>;
+ phy_type = "utmi";
+ dr_mode = "host";
+ status = "okay";
+};
+
+&usbotg {
+ vbus-supply = <®_usb_otg_vbus>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbotg>;
+ phy_type = "utmi";
+ dr_mode = "host";
+ disable-over-current;
+ status = "okay";
+};
+
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
+ status = "okay";
+};
+
+&usdhc3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc3>;
+ bus-width = <8>;
+ non-removable;
+ status = "okay";
+};
+
+&iomuxc {
+ pinctrl_can1: can1grp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
+ MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
+ >;
+ };
+
+ pinctrl_i2c1: i2c1grp {
+ fsl,pins = <
+ MX6QDL_PAD_CSI0_DAT8__I2C1_SDA 0x4001f8b1
+ MX6QDL_PAD_CSI0_DAT9__I2C1_SCL 0x4001f8b1
+ >;
+ };
+
+ pinctrl_i2c3: i2c3grp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_5__I2C3_SCL 0x4001b8b1
+ MX6QDL_PAD_GPIO_6__I2C3_SDA 0x4001b8b1
+ >;
+ };
+
+ pinctrl_uart4: uart4grp {
+ fsl,pins = <
+ MX6QDL_PAD_KEY_COL0__UART4_TX_DATA 0x1b0b1
+ MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA 0x1b0b1
+ >;
+ };
+
+ pinctrl_usdhc1: usdhc1grp {
+ fsl,pins = <
+ MX6QDL_PAD_SD1_CMD__SD1_CMD 0x170f9
+ MX6QDL_PAD_SD1_CLK__SD1_CLK 0x100f9
+ MX6QDL_PAD_SD1_DAT0__SD1_DATA0 0x170f9
+ MX6QDL_PAD_SD1_DAT1__SD1_DATA1 0x170f9
+ MX6QDL_PAD_SD1_DAT2__SD1_DATA2 0x170f9
+ MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x170f9
+ MX6QDL_PAD_GPIO_1__GPIO1_IO01 0x1b0b0
+ >;
+ };
+
+ pinctrl_usdhc3: usdhc3grp {
+ fsl,pins = <
+ MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17099
+ MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10099
+ MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17099
+ MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17099
+ MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17099
+ MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17099
+ MX6QDL_PAD_SD3_DAT4__SD3_DATA4 0x17099
+ MX6QDL_PAD_SD3_DAT5__SD3_DATA5 0x17099
+ MX6QDL_PAD_SD3_DAT6__SD3_DATA6 0x17099
+ MX6QDL_PAD_SD3_DAT7__SD3_DATA7 0x17099
+ MX6QDL_PAD_SD3_RST__SD3_RESET 0x1b0b1
+ >;
+ };
+
+ pinctrl_usbotg: usbotggrp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x1b0b0
+ MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x1b0b0
+ >;
+ };
+};
--
2.26.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v6 1/5] ARM: dts: add Protonic PRTI6Q board
2020-04-21 12:40 ` [PATCH v6 1/5] ARM: dts: add Protonic PRTI6Q board Oleksij Rempel
@ 2020-04-22 7:19 ` Marco Felsch
0 siblings, 0 replies; 12+ messages in thread
From: Marco Felsch @ 2020-04-22 7:19 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo, devicetree,
Rob Herring, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team, David Jander, Fabio Estevam,
linux-arm-kernel
On 20-04-21 14:40, Oleksij Rempel wrote:
> Protonic PRTI6Q is a development board and a base class for different
> specific customer application boards based on the i.MX6 family of SoCs,
> developed by Protonic Holland.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx6q-prti6q.dts | 529 ++++++++++++++++++++++++++
> arch/arm/boot/dts/imx6qdl-prti6q.dtsi | 174 +++++++++
> 3 files changed, 704 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6q-prti6q.dts
> create mode 100644 arch/arm/boot/dts/imx6qdl-prti6q.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index e8dd992013973..206a36a50575e 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -538,6 +538,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6q-pico-nymph.dtb \
> imx6q-pico-pi.dtb \
> imx6q-pistachio.dtb \
> + imx6q-prti6q.dtb \
> imx6q-rex-pro.dtb \
> imx6q-sabreauto.dtb \
> imx6q-sabrelite.dtb \
> diff --git a/arch/arm/boot/dts/imx6q-prti6q.dts b/arch/arm/boot/dts/imx6q-prti6q.dts
> new file mode 100644
> index 0000000000000..b0d597a7d59cd
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-prti6q.dts
> @@ -0,0 +1,529 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2014 Protonic Holland
> + */
> +
> +/dts-v1/;
> +#include "imx6q.dtsi"
> +#include "imx6qdl-prti6q.dtsi"
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/sound/fsl-imx-audmux.h>
> +
> +/ {
> + model = "Protonic PRTI6Q board";
> + compatible = "prt,prti6q", "fsl,imx6q";
> +
> + memory@10000000 {
> + device_type = "memory";
> + reg = <0x10000000 0xf0000000>;
> + };
> +
> + backlight_lcd: backlight-lcd {
> + compatible = "pwm-backlight";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_backlight>;
> + pwms = <&pwm1 0 5000000>;
> + brightness-levels = <0 16 64 255>;
> + num-interpolated-steps = <16>;
> + default-brightness-level = <16>;
> + power-supply = <®_3v3>;
> + enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
> + };
> +
> + can3_25m_osc: can3-25m-osc {
Nit, can be named can_osc or can_25m_osc.
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <25000000>;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_leds>;
> +
> + led-debug0 {
> + function = LED_FUNCTION_STATUS;
> + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> +
> + led-debug1 {
> + function = LED_FUNCTION_SD;
> + gpios = <&gpio1 9 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "disk-activity";
> + };
> + };
> +
> + panel {
> + compatible = "kyo,tcg121xglp";
> + backlight = <&backlight_lcd>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lvds0_out>;
> + };
> + };
> + };
> +
> + reg_wifi: regulator-wifi {
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_wifi_npd>;
> + enable-active-high;
> + gpio = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> + regulator-max-microvolt = <1800000>;
> + regulator-min-microvolt = <1800000>;
> + regulator-name = "regulator-WL12xx";
> + startup-delay-us = <70000>;
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "prti6q-sgtl5000";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Line", "Line In Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "External Speaker";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "External Speaker", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&ssi1>;
> + system-clock-frequency = <0>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&sgtl5000>;
> + bitclock-master;
> + frame-master;
> + };
> + };
> +
> + sound-spdif {
> + compatible = "fsl,imx-audio-spdif";
> + model = "imx-spdif";
> + spdif-controller = <&spdif>;
> + spdif-in;
> + spdif-out;
> + };
> +};
> +
> +&audmux {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_audmux>;
> + status = "okay";
> +
> + mux_ssi1 {
> + fsl,audmux-port = <0>;
> + fsl,port-config = <
> + IMX_AUDMUX_V2_PTCR_SYN 0
> + IMX_AUDMUX_V2_PTCR_TFSEL(2) 0
> + IMX_AUDMUX_V2_PTCR_TCSEL(2) 0
> + IMX_AUDMUX_V2_PTCR_TFSDIR 0
> + IMX_AUDMUX_V2_PTCR_TCLKDIR IMX_AUDMUX_V2_PDCR_RXDSEL(2)
> + >;
> + };
> +
> + mux_pins3 {
> + fsl,audmux-port = <2>;
> + fsl,port-config = <
> + IMX_AUDMUX_V2_PTCR_SYN IMX_AUDMUX_V2_PDCR_RXDSEL(0)
> + 0 IMX_AUDMUX_V2_PDCR_TXRXEN
> + >;
> + };
> +};
> +
> +&can2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_can2>;
> + status = "okay";
> +};
> +
> +&ecspi1 {
> + cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi1>;
> + status = "okay";
> +
> + flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + spi-max-frequency = <20000000>;
> + };
> +};
> +
> +&ecspi2 {
> + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio4 25 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi2 &pinctrl_ecspi2_cs>;
> + status = "okay";
> +
> + can@0 {
> + compatible = "microchip,mcp2515";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_can3>;
> + clocks = <&can3_25m_osc>;
> + interrupts-extended = <&gpio3 20 IRQ_TYPE_LEVEL_LOW>;
> + spi-max-frequency = <5000000>;
> + };
> +
> + adc@1 {
> + compatible = "ti,adc128s052";
> + reg = <1>;
> + spi-max-frequency = <2000000>;
> + vref-supply = <®_3v3>;
> + };
> +};
> +
> +&ecspi3 {
> + cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi3>;
> + status = "okay";
> +};
> +
> +&fec {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_enet>;
> + phy-mode = "rgmii-id";
> + phy-handle = <&rgmii_phy>;
> + status = "okay";
> +
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* Microchip KSZ9031RNX PHY */
> + rgmii_phy: ethernet-phy@0 {
> + reg = <0>;
> + interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
> + reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> + reset-assert-us = <10000>;
> + reset-deassert-us = <300>;
> + };
> + };
> +};
> +
> +&hdmi {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_hdmi>;
> + ddc-i2c-bus = <&i2c2>;
> + status = "okay";
> +};
> +
> +&i2c1 {
> + sgtl5000: audio-codec@a {
> + compatible = "fsl,sgtl5000";
> + reg = <0xa>;
> + #sound-dai-cells = <0>;
> + clocks = <&clks 201>;
> + VDDA-supply = <®_3v3>;
> + VDDIO-supply = <®_3v3>;
> + VDDD-supply = <®_1v8>;
> + };
> +};
> +
> +/* DDC */
> +&i2c2 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c2>;
> + status = "okay";
> +};
> +
> +&i2c3 {
> + adc@49 {
> + compatible = "ti,ads1015";
> + reg = <0x49>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* can2_l */
> + channel@4 {
> + reg = <4>;
> + ti,gain = <3>;
> + ti,datarate = <3>;
> + };
> +
> + /* can2_h */
> + channel@5 {
> + reg = <5>;
> + ti,gain = <3>;
> + ti,datarate = <3>;
> + };
> +
> + /* can1_l */
> + channel@6 {
> + reg = <6>;
> + ti,gain = <3>;
> + ti,datarate = <3>;
> + };
> +
> + /* can1_h */
> + channel@7 {
> + reg = <7>;
> + ti,gain = <3>;
> + ti,datarate = <3>;
> + };
> + };
> +};
> +
> +&pcie {
> + status = "okay";
> +};
> +
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1>;
> + status = "okay";
> +};
> +
> +&ldb {
> + status = "okay";
> +
> + lvds-channel@0 {
> + status = "okay";
> +
> + port@4 {
> + reg = <4>;
> +
> + lvds0_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +};
> +
> +&sata {
> + status = "okay";
> +};
> +
> +&snvs_poweroff {
> + status = "okay";
> +};
> +
> +&spdif {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spdif>;
> + status = "okay";
> +};
> +
> +&ssi1 {
> + #sound-dai-cells = <0>;
> + fsl,mode = "ac97-slave";
> + status = "okay";
> +};
> +
> +&uart2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart2>;
> + status = "okay";
> +};
> +
> +&uart5 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart5>;
> + status = "okay";
> +};
> +
> +&usbotg {
> + pinctrl-0 = <&pinctrl_usbotg &pinctrl_usbotg_id>;
> +};
> +
> +&usdhc2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc2>;
> + non-removable;
> + vmmc-supply = <®_wifi>;
> + cap-power-off-card;
> + keep-power-in-suspend;
> + status = "okay";
> +
> + wifi {
> + compatible = "ti,wl1271";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_wifi>;
> + interrupts-extended = <&gpio1 30 IRQ_TYPE_LEVEL_HIGH>;
> + ref-clock-frequency = "38400000";
> + tcxo-clock-frequency = "19200000";
> + };
> +};
> +
> +&iomuxc {
> + pinctrl_audmux: audmuxgrp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_MCLK__CCM_CLKO1 0x030b0
> + MX6QDL_PAD_CSI0_DAT7__AUD3_RXD 0x130b0
> + MX6QDL_PAD_CSI0_DAT4__AUD3_TXC 0x130b0
> + MX6QDL_PAD_CSI0_DAT5__AUD3_TXD 0x110b0
> + MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS 0x130b0
> + >;
> + };
> +
> + pinctrl_backlight: backlightgrp {
> + fsl,pins = <
> + MX6QDL_PAD_DISP0_DAT7__GPIO4_IO28 0x1b0b0
> + >;
> + };
> +
> + pinctrl_can2: can2grp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL4__FLEXCAN2_TX 0x80000000
> + MX6QDL_PAD_KEY_ROW4__FLEXCAN2_RX 0x80000000
> + >;
> + };
> +
> + pinctrl_can3: can3grp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b1
> + >;
> + };
> +
> + pinctrl_ecspi1: ecspi1grp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_D17__ECSPI1_MISO 0x100b1
> + MX6QDL_PAD_EIM_D18__ECSPI1_MOSI 0x100b1
> + MX6QDL_PAD_EIM_D16__ECSPI1_SCLK 0x100b1
> + /* CS */
> + MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x000b1
> + >;
> + };
> +
> + pinctrl_ecspi2: ecspi2grp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_OE__ECSPI2_MISO 0x100b1
> + MX6QDL_PAD_EIM_CS0__ECSPI2_SCLK 0x100b1
> + MX6QDL_PAD_EIM_CS1__ECSPI2_MOSI 0x100b1
> + MX6QDL_PAD_EIM_RW__GPIO2_IO26 0x000b1
> + >;
> + };
> +
> + pinctrl_ecspi2_cs: ecspi2csgrp {
> + fsl,pins = <
> + /* ADC128S022 CS */
> + MX6QDL_PAD_DISP0_DAT4__GPIO4_IO25 0x1b0b1
> + >;
> + };
> +
> + pinctrl_ecspi3: ecspi3grp {
> + fsl,pins = <
> + MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK 0x100b1
> + MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI 0x100b1
> + MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO 0x100b1
> + MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x000b1
> + >;
> + };
> +
> + pinctrl_enet: enetgrp {
> + fsl,pins = <
> + MX6QDL_PAD_RGMII_RXC__RGMII_RXC 0x1b030
> + MX6QDL_PAD_RGMII_RD0__RGMII_RD0 0x1b030
> + MX6QDL_PAD_RGMII_RD1__RGMII_RD1 0x1b030
> + MX6QDL_PAD_RGMII_RD2__RGMII_RD2 0x1b030
> + MX6QDL_PAD_RGMII_RD3__RGMII_RD3 0x1b030
> + MX6QDL_PAD_RGMII_RX_CTL__RGMII_RX_CTL 0x1b030
> + MX6QDL_PAD_RGMII_TXC__RGMII_TXC 0x10030
> + MX6QDL_PAD_RGMII_TD0__RGMII_TD0 0x10030
> + MX6QDL_PAD_RGMII_TD1__RGMII_TD1 0x10030
> + MX6QDL_PAD_RGMII_TD2__RGMII_TD2 0x10030
> + MX6QDL_PAD_RGMII_TD3__RGMII_TD3 0x10030
> + MX6QDL_PAD_RGMII_TX_CTL__RGMII_TX_CTL 0x10030
> + MX6QDL_PAD_ENET_REF_CLK__ENET_TX_CLK 0x10030
> + MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x10030
> + MX6QDL_PAD_ENET_MDC__ENET_MDC 0x10030
> +
> + /* Phy reset */
> + MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x1b0b0
> + MX6QDL_PAD_ENET_TX_EN__GPIO1_IO28 0x1b0b1
> + >;
> + };
> +
> + pinctrl_hdmi: hdmigrp {
> + fsl,pins = <
> + /* NOTE: DDC is done via I2C2, so DON'T
> + * configure DDC pins for HDMI!
> + */
> + MX6QDL_PAD_EIM_A25__HDMI_TX_CEC_LINE 0x1f8b0
> + >;
> + };
> +
> + /* DDC */
> + pinctrl_i2c2: i2c2grp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL3__I2C2_SCL 0x4001b8b1
> + MX6QDL_PAD_KEY_ROW3__I2C2_SDA 0x4001b8b1
> + >;
> + };
> +
> + pinctrl_leds: ledsgrp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
> + MX6QDL_PAD_GPIO_9__GPIO1_IO09 0x1b0b0
> + >;
> + };
> +
> + pinctrl_pwm1: pwm1grp {
> + fsl,pins = <
> + MX6QDL_PAD_DISP0_DAT8__PWM1_OUT 0x1b0b0
> + >;
> + };
> +
> + pinctrl_spdif: spdifgrp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_16__SPDIF_IN 0x1b0b0
> + MX6QDL_PAD_GPIO_19__SPDIF_OUT 0x1b0b0
> + >;
> + };
> +
> + pinctrl_uart2: uart2grp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_D26__UART2_RX_DATA 0x1b0b1
> + MX6QDL_PAD_EIM_D27__UART2_TX_DATA 0x1b0b1
> + MX6QDL_PAD_EIM_D28__UART2_DTE_CTS_B 0x1b0b1
> + MX6QDL_PAD_EIM_D29__UART2_DTE_RTS_B 0x1b0b1
> + >;
> + };
> +
> + pinctrl_uart5: uart5grp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL1__UART5_TX_DATA 0x1b0b1
> + MX6QDL_PAD_KEY_ROW1__UART5_RX_DATA 0x1b0b1
> + >;
> + };
> +
> + pinctrl_usbotg_id: usbotgidgrp {
> + fsl,pins = <
> + MX6QDL_PAD_ENET_RX_ER__USB_OTG_ID 0x1f058
> + >;
> + };
> +
> + pinctrl_usdhc2: usdhc2grp {
> + fsl,pins = <
> + MX6QDL_PAD_SD2_CMD__SD2_CMD 0x170b9
> + MX6QDL_PAD_SD2_CLK__SD2_CLK 0x100b9
> + MX6QDL_PAD_SD2_DAT0__SD2_DATA0 0x170b9
> + MX6QDL_PAD_SD2_DAT1__SD2_DATA1 0x170b9
> + MX6QDL_PAD_SD2_DAT2__SD2_DATA2 0x170b9
> + MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x170b9
> + >;
> + };
> +
> + pinctrl_wifi: wifigrp {
> + fsl,pins = <
> + /* WL12xx IRQ */
> + MX6QDL_PAD_ENET_TXD0__GPIO1_IO30 0x10880
> + >;
> + };
> +
> + pinctrl_wifi_npd: wifinpd {
> + fsl,pins = <
> + MX6QDL_PAD_ENET_RXD1__GPIO1_IO26 0x1b8b0
> + >;
> + };
> +};
> diff --git a/arch/arm/boot/dts/imx6qdl-prti6q.dtsi b/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
> new file mode 100644
> index 0000000000000..7090a7ca83d8d
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6qdl-prti6q.dtsi
> @@ -0,0 +1,174 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2014 Protonic Holland
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + chosen {
> + stdout-path = &uart4;
> + };
> +
> + reg_1v8: regulator-1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "1v8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + reg_3v3: regulator-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "3v3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + reg_usb_h1_vbus: regulator-h1-vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "h1-vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + };
> +
> + reg_usb_otg_vbus: regulator-otg-vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "otg-vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +};
> +
> +&can1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_can1>;
> + status = "okay";
> +};
You change the pinctl for every .dts so we can drop it from the common
.dtsi completely.
> +&i2c1 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c1>;
> + status = "okay";
> +};
> +
> +&i2c3 {
> + clock-frequency = <100000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_i2c3>;
> + status = "okay";
> +
> + temperature-sensor@70 {
> + compatible = "ti,tmp103";
> + reg = <0x70>;
> + };
> +};
> +
> +&uart4 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_uart4>;
> + status = "okay";
> +};
> +
> +&usbh1 {
> + vbus-supply = <®_usb_h1_vbus>;
> + phy_type = "utmi";
> + dr_mode = "host";
> + status = "okay";
> +};
> +
> +&usbotg {
> + vbus-supply = <®_usb_otg_vbus>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbotg>;
> + phy_type = "utmi";
> + dr_mode = "host";
> + disable-over-current;
> + status = "okay";
> +};
I don't count the .dts which disables the nodes because we enabled it
here. I would setup the mux and stuff here but would not set it to
"okay". It is a bit more straight forward to enable a node rather then:
imx6qdl.dtsi -> disable
common.dtsi -> enable
specific.dts -> disable
Regards,
Marco
> +
> +&usdhc1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc1>;
> + cd-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;
> + status = "okay";
> +};
> +
> +&usdhc3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usdhc3>;
> + bus-width = <8>;
> + non-removable;
> + status = "okay";
> +};
> +
> +&iomuxc {
> + pinctrl_can1: can1grp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_ROW2__FLEXCAN1_RX 0x80000000
> + MX6QDL_PAD_KEY_COL2__FLEXCAN1_TX 0x80000000
> + >;
> + };
> +
> + pinctrl_i2c1: i2c1grp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_DAT8__I2C1_SDA 0x4001f8b1
> + MX6QDL_PAD_CSI0_DAT9__I2C1_SCL 0x4001f8b1
> + >;
> + };
> +
> + pinctrl_i2c3: i2c3grp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_5__I2C3_SCL 0x4001b8b1
> + MX6QDL_PAD_GPIO_6__I2C3_SDA 0x4001b8b1
> + >;
> + };
> +
> + pinctrl_uart4: uart4grp {
> + fsl,pins = <
> + MX6QDL_PAD_KEY_COL0__UART4_TX_DATA 0x1b0b1
> + MX6QDL_PAD_KEY_ROW0__UART4_RX_DATA 0x1b0b1
> + >;
> + };
> +
> + pinctrl_usdhc1: usdhc1grp {
> + fsl,pins = <
> + MX6QDL_PAD_SD1_CMD__SD1_CMD 0x170f9
> + MX6QDL_PAD_SD1_CLK__SD1_CLK 0x100f9
> + MX6QDL_PAD_SD1_DAT0__SD1_DATA0 0x170f9
> + MX6QDL_PAD_SD1_DAT1__SD1_DATA1 0x170f9
> + MX6QDL_PAD_SD1_DAT2__SD1_DATA2 0x170f9
> + MX6QDL_PAD_SD1_DAT3__SD1_DATA3 0x170f9
> + MX6QDL_PAD_GPIO_1__GPIO1_IO01 0x1b0b0
> + >;
> + };
> +
> + pinctrl_usdhc3: usdhc3grp {
> + fsl,pins = <
> + MX6QDL_PAD_SD3_CMD__SD3_CMD 0x17099
> + MX6QDL_PAD_SD3_CLK__SD3_CLK 0x10099
> + MX6QDL_PAD_SD3_DAT0__SD3_DATA0 0x17099
> + MX6QDL_PAD_SD3_DAT1__SD3_DATA1 0x17099
> + MX6QDL_PAD_SD3_DAT2__SD3_DATA2 0x17099
> + MX6QDL_PAD_SD3_DAT3__SD3_DATA3 0x17099
> + MX6QDL_PAD_SD3_DAT4__SD3_DATA4 0x17099
> + MX6QDL_PAD_SD3_DAT5__SD3_DATA5 0x17099
> + MX6QDL_PAD_SD3_DAT6__SD3_DATA6 0x17099
> + MX6QDL_PAD_SD3_DAT7__SD3_DATA7 0x17099
> + MX6QDL_PAD_SD3_RST__SD3_RESET 0x1b0b1
> + >;
> + };
> +
> + pinctrl_usbotg: usbotggrp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_D21__USB_OTG_OC 0x1b0b0
> + MX6QDL_PAD_EIM_D22__GPIO3_IO22 0x1b0b0
> + >;
> + };
> +};
> --
> 2.26.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v6 2/5] ARM: dts: add Protonic WD2 board
2020-04-21 12:40 [PATCH v6 0/5] mainline Protonic boards Oleksij Rempel
2020-04-21 12:40 ` [PATCH v6 1/5] ARM: dts: add Protonic PRTI6Q board Oleksij Rempel
@ 2020-04-21 12:40 ` Oleksij Rempel
2020-04-21 12:40 ` [PATCH v6 3/5] ARM: dts: add Protonic VT7 board Oleksij Rempel
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2020-04-21 12:40 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, Rob Herring, David Jander, devicetree,
Fabio Estevam, linux-arm-kernel, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team
Add support for the Protonic WD2 board, which is an internal development
platform for low-cost agricultural Virtual Terminals based on COTS tablets
and web applications.
It inherits from the PRTI6Q base class.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx6q-prtwd2.dts | 188 +++++++++++++++++++++++++++++
2 files changed, 189 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6q-prtwd2.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 206a36a50575e..8ce744f1cbfc9 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -539,6 +539,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6q-pico-pi.dtb \
imx6q-pistachio.dtb \
imx6q-prti6q.dtb \
+ imx6q-prtwd2.dtb \
imx6q-rex-pro.dtb \
imx6q-sabreauto.dtb \
imx6q-sabrelite.dtb \
diff --git a/arch/arm/boot/dts/imx6q-prtwd2.dts b/arch/arm/boot/dts/imx6q-prtwd2.dts
new file mode 100644
index 0000000000000..57d2a595d8d14
--- /dev/null
+++ b/arch/arm/boot/dts/imx6q-prtwd2.dts
@@ -0,0 +1,188 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2018 Protonic Holland
+ */
+
+/dts-v1/;
+#include "imx6q.dtsi"
+#include "imx6qdl-prti6q.dtsi"
+#include <dt-bindings/leds/common.h>
+
+/ {
+ model = "Protonic WD2 board";
+ compatible = "prt,prtwd2", "fsl,imx6q";
+
+ memory@10000000 {
+ device_type = "memory";
+ reg = <0x10000000 0x20000000>;
+ };
+
+ memory@80000000 {
+ device_type = "memory";
+ reg = <0x80000000 0x20000000>;
+ };
+
+ usdhc2_wifi_pwrseq: usdhc2_wifi_pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_wifi_npd>;
+ reset-gpios = <&gpio6 10 GPIO_ACTIVE_LOW>;
+ };
+
+ /* PRTWD2 rev 1 bitbang I2C for Ethernet Switch */
+ i2c@4 {
+ compatible = "i2c-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_i2c4>;
+ sda-gpios = <&gpio1 22 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
+ scl-gpios = <&gpio1 31 GPIO_ACTIVE_HIGH>;
+ i2c-gpio,delay-us = <20>; /* ~10 kHz */
+ i2c-gpio,scl-output-only;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
+};
+
+&can1 {
+ pinctrl-0 = <&pinctrl_can1 &pinctrl_can1phy>;
+};
+
+&fec {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_enet>;
+ phy-mode = "rmii";
+ clocks = <&clks IMX6QDL_CLK_ENET>,
+ <&clks IMX6QDL_CLK_ENET>;
+ clock-names = "ipg", "ahb";
+ status = "okay";
+
+ fixed-link {
+ speed = <100>;
+ pause;
+ full-duplex;
+ };
+};
+
+&i2c3 {
+ adc@49 {
+ compatible = "ti,ads1015";
+ reg = <0x49>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* V in */
+ channel@4 {
+ reg = <4>;
+ ti,gain = <1>;
+ ti,datarate = <3>;
+ };
+
+ /* I charge */
+ channel@5 {
+ reg = <5>;
+ ti,gain = <1>;
+ ti,datarate = <3>;
+ };
+
+ /* V bus */
+ channel@6 {
+ reg = <6>;
+ ti,gain = <1>;
+ ti,datarate = <3>;
+ };
+
+ /* nc */
+ channel@7 {
+ reg = <7>;
+ ti,gain = <1>;
+ ti,datarate = <3>;
+ };
+ };
+};
+
+&usdhc2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc2>;
+ non-removable;
+ no-1-8-v;
+ non-removable;
+ mmc-pwrseq = <&usdhc2_wifi_pwrseq>;
+ pm-ignore-notify;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ wifi@1 {
+ compatible = "brcm,bcm4329-fmac";
+ reg = <1>;
+ };
+};
+
+&iomuxc {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usb_eth_chg>;
+
+ pinctrl_can1phy: can1phy {
+ fsl,pins = <
+ /* CAN1_SR */
+ MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x13070
+ >;
+ };
+
+ pinctrl_enet: enetgrp {
+ fsl,pins = <
+ /* MX6QDL_ENET_PINGRP4 */
+ MX6QDL_PAD_ENET_RXD0__ENET_RX_DATA0 0x1b0b0
+ MX6QDL_PAD_ENET_RXD1__ENET_RX_DATA1 0x1b0b0
+ MX6QDL_PAD_ENET_RX_ER__ENET_RX_ER 0x130b0
+ MX6QDL_PAD_ENET_TX_EN__ENET_TX_EN 0x1b0b0
+ MX6QDL_PAD_ENET_TXD0__ENET_TX_DATA0 0x1b0b0
+ MX6QDL_PAD_ENET_TXD1__ENET_TX_DATA1 0x1b0b0
+ MX6QDL_PAD_ENET_CRS_DV__ENET_RX_EN 0x1b0b0
+
+ MX6QDL_PAD_GPIO_16__ENET_REF_CLK 0x1b0b0
+ /* Phy reset */
+ MX6QDL_PAD_CSI0_DAT4__GPIO5_IO22 0x1b0b0
+ /* nINTRP */
+ MX6QDL_PAD_CSI0_DAT5__GPIO5_IO23 0x1b0b0
+
+ MX6QDL_PAD_ENET_MDIO__ENET_MDIO 0x10030
+ MX6QDL_PAD_ENET_MDC__ENET_MDC 0x10030
+ >;
+ };
+
+ pinctrl_i2c4: i2c4grp {
+ fsl,pins = <
+ MX6QDL_PAD_ENET_MDIO__GPIO1_IO22 0x1f8b0
+ MX6QDL_PAD_ENET_MDC__GPIO1_IO31 0x1f8b0
+ >;
+ };
+
+ pinctrl_usb_eth_chg: usbethchggrp {
+ fsl,pins = <
+ /* USB charging control */
+ MX6QDL_PAD_NANDF_CS0__GPIO6_IO11 0x130b0
+ MX6QDL_PAD_NANDF_CS1__GPIO6_IO14 0x130b0
+ MX6QDL_PAD_NANDF_CS2__GPIO6_IO15 0x130b0
+ MX6QDL_PAD_NANDF_CS3__GPIO6_IO16 0x130b0
+ >;
+ };
+
+ pinctrl_usdhc2: usdhc2grp {
+ fsl,pins = <
+ MX6QDL_PAD_SD2_CMD__SD2_CMD 0x170b9
+ MX6QDL_PAD_SD2_CLK__SD2_CLK 0x100b9
+ MX6QDL_PAD_SD2_DAT0__SD2_DATA0 0x170b9
+ MX6QDL_PAD_SD2_DAT1__SD2_DATA1 0x170b9
+ MX6QDL_PAD_SD2_DAT2__SD2_DATA2 0x170b9
+ MX6QDL_PAD_SD2_DAT3__SD2_DATA3 0x170b9
+ >;
+ };
+
+ pinctrl_wifi_npd: wifinpd {
+ fsl,pins = <
+ /* WL_REG_ON */
+ MX6QDL_PAD_NANDF_RB0__GPIO6_IO10 0x13069
+ >;
+ };
+};
--
2.26.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v6 3/5] ARM: dts: add Protonic VT7 board
2020-04-21 12:40 [PATCH v6 0/5] mainline Protonic boards Oleksij Rempel
2020-04-21 12:40 ` [PATCH v6 1/5] ARM: dts: add Protonic PRTI6Q board Oleksij Rempel
2020-04-21 12:40 ` [PATCH v6 2/5] ARM: dts: add Protonic WD2 board Oleksij Rempel
@ 2020-04-21 12:40 ` Oleksij Rempel
2020-04-22 7:04 ` Marco Felsch
2020-04-21 12:40 ` [PATCH v6 4/5] ARM: dts: add Protonic RVT board Oleksij Rempel
2020-04-21 12:40 ` [PATCH v6 5/5] dt-bindings: arm: fsl: add different Protonic boards Oleksij Rempel
4 siblings, 1 reply; 12+ messages in thread
From: Oleksij Rempel @ 2020-04-21 12:40 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, Rob Herring, Robin van der Gracht, David Jander,
devicetree, Fabio Estevam, linux-arm-kernel, linux-kernel,
NXP Linux Team, Pengutronix Kernel Team
The Protonic VT7 is a mid-class ISObus Virtual Terminal with a 7 inch
touchscreen display.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Robin van der Gracht <robin@protonic.nl>
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx6dl-prtvt7.dts | 472 ++++++++++++++++++++++++++++
2 files changed, 473 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6dl-prtvt7.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 8ce744f1cbfc9..66ee89e7929f9 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -450,6 +450,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6dl-pico-hobbit.dtb \
imx6dl-pico-nymph.dtb \
imx6dl-pico-pi.dtb \
+ imx6dl-prtvt7.dtb \
imx6dl-rex-basic.dtb \
imx6dl-riotboard.dtb \
imx6dl-sabreauto.dtb \
diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
new file mode 100644
index 0000000000000..a948c7c6eb3ce
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
@@ -0,0 +1,472 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2016 Protonic Holland
+ */
+
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-prti6q.dtsi"
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/sound/fsl-imx-audmux.h>
+
+/ {
+ model = "Protonic VT7";
+ compatible = "prt,prtvt7", "fsl,imx6dl";
+
+ memory@10000000 {
+ device_type = "memory";
+ reg = <0x10000000 0x20000000>;
+ };
+
+ backlight_lcd: backlight-lcd {
+ compatible = "pwm-backlight";
+ pwms = <&pwm1 0 500000>;
+ brightness-levels = <0 20 81 248 1000>;
+ default-brightness-level = <20>;
+ num-interpolated-steps = <21>;
+ power-supply = <®_12v_bl>;
+ enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
+ };
+
+ display {
+ compatible = "fsl,imx-parallel-display";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ipu1_disp>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ interface-pix-fmt = "rgb24";
+ status = "okay";
+
+ port@0 {
+ reg = <0>;
+
+ display_in: endpoint {
+ remote-endpoint = <&ipu1_di0_disp0>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ display_out: endpoint {
+ remote-endpoint = <&panel_in>;
+ };
+ };
+ };
+
+ keys {
+ compatible = "gpio-keys";
+ autorepeat;
+
+ esc {
+ label = "GPIO Key ESC";
+ linux,code = <KEY_ESC>;
+ gpios = <&gpio_pca 0 GPIO_ACTIVE_LOW>;
+ };
+
+ up {
+ label = "GPIO Key UP";
+ linux,code = <KEY_UP>;
+ gpios = <&gpio_pca 1 GPIO_ACTIVE_LOW>;
+ };
+
+ down {
+ label = "GPIO Key DOWN";
+ linux,code = <KEY_DOWN>;
+ gpios = <&gpio_pca 4 GPIO_ACTIVE_LOW>;
+ };
+
+ enter {
+ label = "GPIO Key Enter";
+ linux,code = <KEY_ENTER>;
+ gpios = <&gpio_pca 3 GPIO_ACTIVE_LOW>;
+ };
+
+ cycle {
+ label = "GPIO Key CYCLE";
+ linux,code = <KEY_CYCLEWINDOWS>;
+ gpios = <&gpio_pca 2 GPIO_ACTIVE_LOW>;
+ };
+
+ f1 {
+ label = "GPIO Key F1";
+ linux,code = <KEY_F1>;
+ gpios = <&gpio_pca 14 GPIO_ACTIVE_LOW>;
+ };
+
+ f2 {
+ label = "GPIO Key F2";
+ linux,code = <KEY_F2>;
+ gpios = <&gpio_pca 13 GPIO_ACTIVE_LOW>;
+ };
+
+ f3 {
+ label = "GPIO Key F3";
+ linux,code = <KEY_F3>;
+ gpios = <&gpio_pca 12 GPIO_ACTIVE_LOW>;
+ };
+
+ f4 {
+ label = "GPIO Key F4";
+ linux,code = <KEY_F4>;
+ gpios = <&gpio_pca 11 GPIO_ACTIVE_LOW>;
+ };
+
+ f5 {
+ label = "GPIO Key F5";
+ linux,code = <KEY_F5>;
+ gpios = <&gpio_pca 10 GPIO_ACTIVE_LOW>;
+ };
+
+ f6 {
+ label = "GPIO Key F6";
+ linux,code = <KEY_F6>;
+ gpios = <&gpio_pca 5 GPIO_ACTIVE_LOW>;
+ };
+
+ f7 {
+ label = "GPIO Key F7";
+ linux,code = <KEY_F7>;
+ gpios = <&gpio_pca 6 GPIO_ACTIVE_LOW>;
+ };
+
+ f8 {
+ label = "GPIO Key F8";
+ linux,code = <KEY_F8>;
+ gpios = <&gpio_pca 7 GPIO_ACTIVE_LOW>;
+ };
+
+ f9 {
+ label = "GPIO Key F9";
+ linux,code = <KEY_F9>;
+ gpios = <&gpio_pca 8 GPIO_ACTIVE_LOW>;
+ };
+
+ f10 {
+ label = "GPIO Key F10";
+ linux,code = <KEY_F10>;
+ gpios = <&gpio_pca 9 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_leds>;
+
+ led-debug0 {
+ function = LED_FUNCTION_STATUS;
+ gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+
+ panel {
+ compatible = "innolux,g070y2t0ec";
+ backlight = <&backlight_lcd>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&display_out>;
+ };
+ };
+ };
+
+ reg_12v_bl: regulator-bl-12v {
+ compatible = "regulator-fixed";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_reg_12v_bl>;
+ regulator-name = "12v-bl";
+ regulator-min-microvolt = <12000000>;
+ regulator-max-microvolt = <12000000>;
+ gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
+ enable-active-high;
+ };
+
+ reg_1v8: regulator-1v8 {
+ compatible = "regulator-fixed";
+ regulator-name = "1v8";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-always-on;
+ };
+
+ sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,name = "prti6q-sgtl5000";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,widgets =
+ "Microphone", "Microphone Jack",
+ "Line", "Line In Jack",
+ "Headphone", "Headphone Jack",
+ "Speaker", "External Speaker";
+ simple-audio-card,routing =
+ "MIC_IN", "Microphone Jack",
+ "LINE_IN", "Line In Jack",
+ "Headphone Jack", "HP_OUT",
+ "External Speaker", "LINE_OUT";
+
+ simple-audio-card,cpu {
+ sound-dai = <&ssi1>;
+ system-clock-frequency = <0>;
+ };
+
+ simple-audio-card,codec {
+ sound-dai = <&sgtl5000>;
+ bitclock-master;
+ frame-master;
+ };
+ };
+};
+
+&clks {
+ assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>;
+ assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>;
+};
+
+&ecspi2 {
+ cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi2>;
+ status = "okay";
+
+ tsc@0 {
+ compatible = "ti,tsc2046";
+ reg = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_tsc>;
+ spi-max-frequency = <100000>;
+ interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
+ pendown-gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
+ vcc-supply = <®_3v3>;
+
+ ti,vref-delay-usecs = /bits/ 16 <100>;
+
+ ti,x-min = /bits/ 16 <0>;
+ ti,x-max = /bits/ 16 <8000>;
+ ti,y-min = /bits/ 16 <0>;
+ ti,y-max = /bits/ 16 <4800>;
+ ti,x-plate-ohms = /bits/ 16 <800>;
+ ti,y-plate-ohms = /bits/ 16 <300>;
+ ti,pressure-max = /bits/ 16 <4095>;
+
+ ti,skip-samples = <2>;
+ ti,sample-period-msecs = <10>;
+ ti,report-period-msecs = <30>;
+
+ ti,filter-tolerance = <80>;
+ ti,touch-resistance-threshold = <3500>;
+ };
+};
+
+&audmux {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_audmux>;
+ status = "okay";
+
+ mux_ssi1 {
+ fsl,audmux-port = <0>;
+ fsl,port-config = <
+ IMX_AUDMUX_V2_PTCR_SYN 0
+ IMX_AUDMUX_V2_PTCR_TFSEL(2) 0
+ IMX_AUDMUX_V2_PTCR_TCSEL(2) 0
+ IMX_AUDMUX_V2_PTCR_TFSDIR 0
+ IMX_AUDMUX_V2_PTCR_TCLKDIR IMX_AUDMUX_V2_PDCR_RXDSEL(2)
+ >;
+ };
+
+ mux_pins3 {
+ fsl,audmux-port = <2>;
+ fsl,port-config = <
+ IMX_AUDMUX_V2_PTCR_SYN IMX_AUDMUX_V2_PDCR_RXDSEL(0)
+ 0 IMX_AUDMUX_V2_PDCR_TXRXEN
+ >;
+ };
+};
+
+&can1 {
+ pinctrl-0 = <&pinctrl_can1 &pinctrl_can1phy>;
+};
+
+&i2c1 {
+ sgtl5000: codec@a {
+ compatible = "fsl,sgtl5000";
+ reg = <0xa>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_codec>;
+ #sound-dai-cells = <0>;
+ clocks = <&clks 201>;
+ VDDA-supply = <®_3v3>;
+ VDDIO-supply = <®_3v3>;
+ VDDD-supply = <®_1v8>;
+ };
+};
+
+&i2c3 {
+ rtc@51 {
+ compatible = "nxp,pcf8563";
+ reg = <0x51>;
+ };
+
+ gpio_pca: gpio@74 {
+ compatible = "nxp,pca9539";
+ reg = <0x74>;
+ interrupts-extended = <&gpio4 5 IRQ_TYPE_LEVEL_LOW>;
+ #gpio-cells = <2>;
+ gpio-controller;
+ };
+};
+
+&ipu1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ipu1_csi0>;
+ status = "okay";
+};
+
+&ipu1_di0_disp0 {
+ remote-endpoint = <&display_in>;
+};
+
+&pwm1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_pwm1>;
+ status = "okay";
+};
+
+&snvs_poweroff {
+ status = "okay";
+};
+
+&snvs_pwrkey {
+ status = "okay";
+};
+
+&ssi1 {
+ #sound-dai-cells = <0>;
+ fsl,mode = "i2s-slave";
+ status = "okay";
+};
+
+&usbh1 {
+ status = "disabled";
+};
+
+&vpu {
+ status = "disabled";
+};
+
+&iomuxc {
+ pinctrl_audmux: audmuxgrp {
+ fsl,pins = <
+ MX6QDL_PAD_CSI0_MCLK__CCM_CLKO1 0x030b0
+ MX6QDL_PAD_CSI0_DAT7__AUD3_RXD 0x130b0
+ MX6QDL_PAD_CSI0_DAT4__AUD3_TXC 0x130b0
+ MX6QDL_PAD_CSI0_DAT5__AUD3_TXD 0x110b0
+ MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS 0x130b0
+ >;
+ };
+
+ pinctrl_can1phy: can1phy {
+ fsl,pins = <
+ /* CAN1_SR */
+ MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x13070
+ /* CAN1_TERM */
+ MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0
+ >;
+ };
+
+ pinctrl_codec: codecgrp {
+ fsl,pins = <
+ /* AUDIO_nRESET */
+ MX6QDL_PAD_CSI0_VSYNC__GPIO5_IO21 0x1f0b0
+ >;
+ };
+
+ pinctrl_ecspi2: ecspi2grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_OE__ECSPI2_MISO 0x100b1
+ MX6QDL_PAD_EIM_CS0__ECSPI2_SCLK 0x100b1
+ MX6QDL_PAD_EIM_CS1__ECSPI2_MOSI 0x100b1
+ MX6QDL_PAD_EIM_RW__GPIO2_IO26 0x000b1
+ >;
+ };
+
+ pinctrl_ipu1_csi0: ipu1csi0grp {
+ fsl,pins = <
+ MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT13__IPU1_CSI0_DATA13 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT14__IPU1_CSI0_DATA14 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT15__IPU1_CSI0_DATA15 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT16__IPU1_CSI0_DATA16 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT17__IPU1_CSI0_DATA17 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT18__IPU1_CSI0_DATA18 0x1b0b0
+ MX6QDL_PAD_CSI0_DAT19__IPU1_CSI0_DATA19 0x1b0b0
+ MX6QDL_PAD_CSI0_PIXCLK__IPU1_CSI0_PIXCLK 0x1b0b0
+ /* ITU656_nRESET */
+ MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0
+ /* ITU656_nPDN */
+ MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b0
+ >;
+ };
+
+ pinctrl_ipu1_disp: ipudisp1grp {
+ fsl,pins = <
+ MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0xb0
+ MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0xb0
+
+ MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0xb0
+ MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0xb0
+ MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0xb0
+ MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0xb0
+ MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0xb0
+ MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0xb0
+ MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0xb0
+ MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0xb0
+
+ MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0xb0
+ MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0xb0
+ MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0xb0
+ MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0xb0
+ MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0xb0
+ MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0xb0
+ MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0xb0
+ MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0xb0
+
+ MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0xb0
+ MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0xb0
+ MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0xb0
+ MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0xb0
+ MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0xb0
+ MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0xb0
+ MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0xb0
+ MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0xb0
+ >;
+ };
+
+ pinctrl_leds: ledsgrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
+ >;
+ };
+
+ pinctrl_pwm1: pwm1grp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_9__PWM1_OUT 0x1b0b0
+ >;
+ };
+
+ pinctrl_reg_12v_bl: 12blgrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_7__GPIO1_IO07 0x1b0b0
+ >;
+ };
+
+ pinctrl_tsc: tscgrp {
+
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b0
+ MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0
+ >;
+ };
+};
--
2.26.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v6 3/5] ARM: dts: add Protonic VT7 board
2020-04-21 12:40 ` [PATCH v6 3/5] ARM: dts: add Protonic VT7 board Oleksij Rempel
@ 2020-04-22 7:04 ` Marco Felsch
2020-04-22 7:11 ` Marco Felsch
2020-04-22 9:38 ` David Jander
0 siblings, 2 replies; 12+ messages in thread
From: Marco Felsch @ 2020-04-22 7:04 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo, devicetree,
Rob Herring, Robin van der Gracht, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team, David Jander, Fabio Estevam,
linux-arm-kernel
Hi Oleksij,
On 20-04-21 14:40, Oleksij Rempel wrote:
> The Protonic VT7 is a mid-class ISObus Virtual Terminal with a 7 inch
> touchscreen display.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> Signed-off-by: David Jander <david@protonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/imx6dl-prtvt7.dts | 472 ++++++++++++++++++++++++++++
> 2 files changed, 473 insertions(+)
> create mode 100644 arch/arm/boot/dts/imx6dl-prtvt7.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 8ce744f1cbfc9..66ee89e7929f9 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -450,6 +450,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> imx6dl-pico-hobbit.dtb \
> imx6dl-pico-nymph.dtb \
> imx6dl-pico-pi.dtb \
> + imx6dl-prtvt7.dtb \
> imx6dl-rex-basic.dtb \
> imx6dl-riotboard.dtb \
> imx6dl-sabreauto.dtb \
> diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> new file mode 100644
> index 0000000000000..a948c7c6eb3ce
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> @@ -0,0 +1,472 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Copyright (c) 2016 Protonic Holland
> + */
> +
> +/dts-v1/;
> +#include "imx6dl.dtsi"
> +#include "imx6qdl-prti6q.dtsi"
Should we name it "imx6qdl-prt-common.dtsi"? Still don't like that this
dtsi comes from the 1st commit rather then having a single commit adding
the .dtsi but that is only my opinion.
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/sound/fsl-imx-audmux.h>
> +
> +/ {
> + model = "Protonic VT7";
> + compatible = "prt,prtvt7", "fsl,imx6dl";
> +
> + memory@10000000 {
> + device_type = "memory";
> + reg = <0x10000000 0x20000000>;
> + };
> +
> + backlight_lcd: backlight-lcd {
> + compatible = "pwm-backlight";
> + pwms = <&pwm1 0 500000>;
> + brightness-levels = <0 20 81 248 1000>;
> + default-brightness-level = <20>;
> + num-interpolated-steps = <21>;
Do you need this fine granularity here? Just asking ;)
> + power-supply = <®_12v_bl>;
> + enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
Where gets this gpio muxed?
> + };
> +
> + display {
> + compatible = "fsl,imx-parallel-display";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ipu1_disp>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interface-pix-fmt = "rgb24";
> + status = "okay";
Status not needed here.
> +
> + port@0 {
> + reg = <0>;
> +
> + display_in: endpoint {
> + remote-endpoint = <&ipu1_di0_disp0>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> +
> + display_out: endpoint {
> + remote-endpoint = <&panel_in>;
> + };
> + };
> + };
> +
> + keys {
> + compatible = "gpio-keys";
> + autorepeat;
> +
> + esc {
> + label = "GPIO Key ESC";
> + linux,code = <KEY_ESC>;
> + gpios = <&gpio_pca 0 GPIO_ACTIVE_LOW>;
> + };
> +
> + up {
> + label = "GPIO Key UP";
> + linux,code = <KEY_UP>;
> + gpios = <&gpio_pca 1 GPIO_ACTIVE_LOW>;
> + };
> +
> + down {
> + label = "GPIO Key DOWN";
> + linux,code = <KEY_DOWN>;
> + gpios = <&gpio_pca 4 GPIO_ACTIVE_LOW>;
> + };
> +
> + enter {
> + label = "GPIO Key Enter";
> + linux,code = <KEY_ENTER>;
> + gpios = <&gpio_pca 3 GPIO_ACTIVE_LOW>;
> + };
> +
> + cycle {
> + label = "GPIO Key CYCLE";
> + linux,code = <KEY_CYCLEWINDOWS>;
> + gpios = <&gpio_pca 2 GPIO_ACTIVE_LOW>;
> + };
> +
> + f1 {
> + label = "GPIO Key F1";
> + linux,code = <KEY_F1>;
> + gpios = <&gpio_pca 14 GPIO_ACTIVE_LOW>;
> + };
> +
> + f2 {
> + label = "GPIO Key F2";
> + linux,code = <KEY_F2>;
> + gpios = <&gpio_pca 13 GPIO_ACTIVE_LOW>;
> + };
> +
> + f3 {
> + label = "GPIO Key F3";
> + linux,code = <KEY_F3>;
> + gpios = <&gpio_pca 12 GPIO_ACTIVE_LOW>;
> + };
> +
> + f4 {
> + label = "GPIO Key F4";
> + linux,code = <KEY_F4>;
> + gpios = <&gpio_pca 11 GPIO_ACTIVE_LOW>;
> + };
> +
> + f5 {
> + label = "GPIO Key F5";
> + linux,code = <KEY_F5>;
> + gpios = <&gpio_pca 10 GPIO_ACTIVE_LOW>;
> + };
> +
> + f6 {
> + label = "GPIO Key F6";
> + linux,code = <KEY_F6>;
> + gpios = <&gpio_pca 5 GPIO_ACTIVE_LOW>;
> + };
> +
> + f7 {
> + label = "GPIO Key F7";
> + linux,code = <KEY_F7>;
> + gpios = <&gpio_pca 6 GPIO_ACTIVE_LOW>;
> + };
> +
> + f8 {
> + label = "GPIO Key F8";
> + linux,code = <KEY_F8>;
> + gpios = <&gpio_pca 7 GPIO_ACTIVE_LOW>;
> + };
> +
> + f9 {
> + label = "GPIO Key F9";
> + linux,code = <KEY_F9>;
> + gpios = <&gpio_pca 8 GPIO_ACTIVE_LOW>;
> + };
> +
> + f10 {
> + label = "GPIO Key F10";
> + linux,code = <KEY_F10>;
> + gpios = <&gpio_pca 9 GPIO_ACTIVE_LOW>;
> + };
Don't know if there is a common rule if the gpio key should be sorted
alphabetical too.
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_leds>;
> +
> + led-debug0 {
> + function = LED_FUNCTION_STATUS;
> + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "heartbeat";
> + };
> + };
> +
> + panel {
> + compatible = "innolux,g070y2t0ec";
Did you send a patch for this panel?
> + backlight = <&backlight_lcd>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&display_out>;
> + };
> + };
> + };
> +
> + reg_12v_bl: regulator-bl-12v {
Nit, it's common to allign the pahndle and the name, so either:
reg_12v_bl -> regulator-12v-bl
or
reg_bl_12v -> regulator-bl-12v
also it would be cool to keep the first digit after the point like you
did it for the 1.8 regulator. So the result would be:
reg_12v0_bl -> regulator-12v0-bl
or
reg_bl_12v0 -> regulator-bl-12v0
> + compatible = "regulator-fixed";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_reg_12v_bl>;
> + regulator-name = "12v-bl";
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> + gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + reg_1v8: regulator-1v8 {
> + compatible = "regulator-fixed";
> + regulator-name = "1v8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "prti6q-sgtl5000";
> + simple-audio-card,format = "i2s";
> + simple-audio-card,widgets =
> + "Microphone", "Microphone Jack",
> + "Line", "Line In Jack",
> + "Headphone", "Headphone Jack",
> + "Speaker", "External Speaker";
> + simple-audio-card,routing =
> + "MIC_IN", "Microphone Jack",
> + "LINE_IN", "Line In Jack",
> + "Headphone Jack", "HP_OUT",
> + "External Speaker", "LINE_OUT";
> +
> + simple-audio-card,cpu {
> + sound-dai = <&ssi1>;
> + system-clock-frequency = <0>;
> + };
> +
> + simple-audio-card,codec {
> + sound-dai = <&sgtl5000>;
> + bitclock-master;
> + frame-master;
> + };
> + };
> +};
> +
> +&clks {
> + assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>;
> + assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>;
> +};
> +
> +&ecspi2 {
> + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi2>;
> + status = "okay";
> +
> + tsc@0 {
> + compatible = "ti,tsc2046";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_tsc>;
> + spi-max-frequency = <100000>;
> + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
The this should be listed within the binding doc.
> + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
IRQ and the GPIO are the same gpio line?
> + vcc-supply = <®_3v3>;
> +
> + ti,vref-delay-usecs = /bits/ 16 <100>;
> +
> + ti,x-min = /bits/ 16 <0>;
> + ti,x-max = /bits/ 16 <8000>;
> + ti,y-min = /bits/ 16 <0>;
> + ti,y-max = /bits/ 16 <4800>;
> + ti,x-plate-ohms = /bits/ 16 <800>;
> + ti,y-plate-ohms = /bits/ 16 <300>;
> + ti,pressure-max = /bits/ 16 <4095>;
> +
> + ti,skip-samples = <2>;
> + ti,sample-period-msecs = <10>;
> + ti,report-period-msecs = <30>;
> +
> + ti,filter-tolerance = <80>;
> + ti,touch-resistance-threshold = <3500>;
> + };
> +};
> +
> +&audmux {
Pls, sort it alphabetical.
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_audmux>;
> + status = "okay";
> +
> + mux_ssi1 {
> + fsl,audmux-port = <0>;
> + fsl,port-config = <
> + IMX_AUDMUX_V2_PTCR_SYN 0
> + IMX_AUDMUX_V2_PTCR_TFSEL(2) 0
> + IMX_AUDMUX_V2_PTCR_TCSEL(2) 0
> + IMX_AUDMUX_V2_PTCR_TFSDIR 0
> + IMX_AUDMUX_V2_PTCR_TCLKDIR IMX_AUDMUX_V2_PDCR_RXDSEL(2)
> + >;
> + };
> +
> + mux_pins3 {
> + fsl,audmux-port = <2>;
> + fsl,port-config = <
> + IMX_AUDMUX_V2_PTCR_SYN IMX_AUDMUX_V2_PDCR_RXDSEL(0)
> + 0 IMX_AUDMUX_V2_PDCR_TXRXEN
> + >;
> + };
> +};
> +
> +&can1 {
This here too.
> + pinctrl-0 = <&pinctrl_can1 &pinctrl_can1phy>;
> +};
> +
> +&i2c1 {
> + sgtl5000: codec@a {
> + compatible = "fsl,sgtl5000";
> + reg = <0xa>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_codec>;
> + #sound-dai-cells = <0>;
> + clocks = <&clks 201>;
> + VDDA-supply = <®_3v3>;
> + VDDIO-supply = <®_3v3>;
> + VDDD-supply = <®_1v8>;
> + };
> +};
> +
> +&i2c3 {
> + rtc@51 {
> + compatible = "nxp,pcf8563";
> + reg = <0x51>;
> + };
> +
> + gpio_pca: gpio@74 {
> + compatible = "nxp,pca9539";
> + reg = <0x74>;
> + interrupts-extended = <&gpio4 5 IRQ_TYPE_LEVEL_LOW>;
> + #gpio-cells = <2>;
> + gpio-controller;
> + };
> +};
> +
> +&ipu1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ipu1_csi0>;
> + status = "okay";
> +};
> +
> +&ipu1_di0_disp0 {
> + remote-endpoint = <&display_in>;
> +};
> +
> +&pwm1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pwm1>;
> + status = "okay";
> +};
> +
> +&snvs_poweroff {
> + status = "okay";
> +};
> +
> +&snvs_pwrkey {
> + status = "okay";
> +};
> +
> +&ssi1 {
> + #sound-dai-cells = <0>;
> + fsl,mode = "i2s-slave";
> + status = "okay";
> +};
> +
> +&usbh1 {
> + status = "disabled";
> +};
> +
> +&vpu {
> + status = "disabled";
> +};
Why do you disable this nodes? You should drop it from the common .dtsi
if you disable them more than once.
> +&iomuxc {
> + pinctrl_audmux: audmuxgrp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_MCLK__CCM_CLKO1 0x030b0
> + MX6QDL_PAD_CSI0_DAT7__AUD3_RXD 0x130b0
> + MX6QDL_PAD_CSI0_DAT4__AUD3_TXC 0x130b0
> + MX6QDL_PAD_CSI0_DAT5__AUD3_TXD 0x110b0
> + MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS 0x130b0
> + >;
> + };
> +
> + pinctrl_can1phy: can1phy {
> + fsl,pins = <
> + /* CAN1_SR */
> + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x13070
> + /* CAN1_TERM */
> + MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0
> + >;
> + };
> +
> + pinctrl_codec: codecgrp {
> + fsl,pins = <
> + /* AUDIO_nRESET */
> + MX6QDL_PAD_CSI0_VSYNC__GPIO5_IO21 0x1f0b0
> + >;
> + };
> +
> + pinctrl_ecspi2: ecspi2grp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_OE__ECSPI2_MISO 0x100b1
> + MX6QDL_PAD_EIM_CS0__ECSPI2_SCLK 0x100b1
> + MX6QDL_PAD_EIM_CS1__ECSPI2_MOSI 0x100b1
> + MX6QDL_PAD_EIM_RW__GPIO2_IO26 0x000b1
> + >;
> + };
> +
> + pinctrl_ipu1_csi0: ipu1csi0grp {
> + fsl,pins = <
> + MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT13__IPU1_CSI0_DATA13 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT14__IPU1_CSI0_DATA14 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT15__IPU1_CSI0_DATA15 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT16__IPU1_CSI0_DATA16 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT17__IPU1_CSI0_DATA17 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT18__IPU1_CSI0_DATA18 0x1b0b0
> + MX6QDL_PAD_CSI0_DAT19__IPU1_CSI0_DATA19 0x1b0b0
> + MX6QDL_PAD_CSI0_PIXCLK__IPU1_CSI0_PIXCLK 0x1b0b0
> + /* ITU656_nRESET */
> + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0
> + /* ITU656_nPDN */
> + MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b0
> + >;
> + };
Why do you mux the the camera interface and have no camera device within
this dt.
> + pinctrl_ipu1_disp: ipudisp1grp {
> + fsl,pins = <
> + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0xb0
> + MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0xb0
> +
> + MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0xb0
> + MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0xb0
> + MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0xb0
> + MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0xb0
> + MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0xb0
> + MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0xb0
> + MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0xb0
> + MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0xb0
> +
> + MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0xb0
> + MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0xb0
> + MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0xb0
> + MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0xb0
> + MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0xb0
> + MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0xb0
> + MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0xb0
> + MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0xb0
> +
> + MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0xb0
> + MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0xb0
> + MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0xb0
> + MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0xb0
> + MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0xb0
> + MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0xb0
> + MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0xb0
> + MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0xb0
> + >;
> + };
> +
> + pinctrl_leds: ledsgrp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
> + >;
> + };
> +
> + pinctrl_pwm1: pwm1grp {
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_9__PWM1_OUT 0x1b0b0
> + >;
> + };
> +
> + pinctrl_reg_12v_bl: 12blgrp {
Pls, keep the name scheme like the others.
Regards,
Marco
> + fsl,pins = <
> + MX6QDL_PAD_GPIO_7__GPIO1_IO07 0x1b0b0
> + >;
> + };
> +
> + pinctrl_tsc: tscgrp {
> +
> + fsl,pins = <
> + MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b0
> + MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0
> + >;
> + };
> +};
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v6 3/5] ARM: dts: add Protonic VT7 board
2020-04-22 7:04 ` Marco Felsch
@ 2020-04-22 7:11 ` Marco Felsch
2020-04-22 9:38 ` David Jander
1 sibling, 0 replies; 12+ messages in thread
From: Marco Felsch @ 2020-04-22 7:11 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, devicetree, Fabio Estevam, Rob Herring,
Robin van der Gracht, Sascha Hauer, linux-kernel, Rob Herring,
NXP Linux Team, Pengutronix Kernel Team, David Jander, Shawn Guo,
linux-arm-kernel
Hi Oleksij,
On 20-04-22 09:04, Marco Felsch wrote:
> Hi Oleksij,
>
> On 20-04-21 14:40, Oleksij Rempel wrote:
...
> > + reg_1v8: regulator-1v8 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "1v8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + };
Just noticed that this regulator is part of the common .dtsi too,
so we can drop it here.
Regards,
Marco
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v6 3/5] ARM: dts: add Protonic VT7 board
2020-04-22 7:04 ` Marco Felsch
2020-04-22 7:11 ` Marco Felsch
@ 2020-04-22 9:38 ` David Jander
2020-04-22 11:20 ` Marco Felsch
1 sibling, 1 reply; 12+ messages in thread
From: David Jander @ 2020-04-22 9:38 UTC (permalink / raw)
To: Marco Felsch
Cc: Oleksij Rempel, Mark Rutland, Rob Herring, Sascha Hauer,
Shawn Guo, devicetree, Rob Herring, Robin van der Gracht,
linux-kernel, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
Hi Marco,
Just chiming in with the answers I know most of...
On Wed, 22 Apr 2020 09:04:41 +0200
Marco Felsch <m.felsch@pengutronix.de> wrote:
> Hi Oleksij,
>
> On 20-04-21 14:40, Oleksij Rempel wrote:
> > The Protonic VT7 is a mid-class ISObus Virtual Terminal with a 7 inch
> > touchscreen display.
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > Signed-off-by: David Jander <david@protonic.nl>
> > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > ---
> > arch/arm/boot/dts/Makefile | 1 +
> > arch/arm/boot/dts/imx6dl-prtvt7.dts | 472 ++++++++++++++++++++++++++++
> > 2 files changed, 473 insertions(+)
> > create mode 100644 arch/arm/boot/dts/imx6dl-prtvt7.dts
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index 8ce744f1cbfc9..66ee89e7929f9 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -450,6 +450,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> > imx6dl-pico-hobbit.dtb \
> > imx6dl-pico-nymph.dtb \
> > imx6dl-pico-pi.dtb \
> > + imx6dl-prtvt7.dtb \
> > imx6dl-rex-basic.dtb \
> > imx6dl-riotboard.dtb \
> > imx6dl-sabreauto.dtb \
> > diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> > new file mode 100644
> > index 0000000000000..a948c7c6eb3ce
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> > @@ -0,0 +1,472 @@
> > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > +/*
> > + * Copyright (c) 2016 Protonic Holland
> > + */
> > +
> > +/dts-v1/;
> > +#include "imx6dl.dtsi"
> > +#include "imx6qdl-prti6q.dtsi"
>
> Should we name it "imx6qdl-prt-common.dtsi"? Still don't like that this
> dtsi comes from the 1st commit rather then having a single commit adding
> the .dtsi but that is only my opinion.
Isn't the extension ".dtsi" implying "common" already?
This file is strictly common to the "prti6q" family of products, not to all
Protonic products, so the name you suggest would be potentially misleading I
guess. Maybe we can just leave it like this?
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/sound/fsl-imx-audmux.h>
> > +
> > +/ {
> > + model = "Protonic VT7";
> > + compatible = "prt,prtvt7", "fsl,imx6dl";
> > +
> > + memory@10000000 {
> > + device_type = "memory";
> > + reg = <0x10000000 0x20000000>;
> > + };
> > +
> > + backlight_lcd: backlight-lcd {
> > + compatible = "pwm-backlight";
> > + pwms = <&pwm1 0 500000>;
> > + brightness-levels = <0 20 81 248 1000>;
> > + default-brightness-level = <20>;
> > + num-interpolated-steps = <21>;
>
> Do you need this fine granularity here? Just asking ;)
Yes. These amount of steps are needed.
> > + power-supply = <®_12v_bl>;
> > + enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
>
> Where gets this gpio muxed?
In imx6qdl-prti6q.dtsi
> > + };
> > +
> > + display {
> > + compatible = "fsl,imx-parallel-display";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_ipu1_disp>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + interface-pix-fmt = "rgb24";
> > + status = "okay";
>
> Status not needed here.
Ack.
> > +
> > + port@0 {
> > + reg = <0>;
> > +
> > + display_in: endpoint {
> > + remote-endpoint = <&ipu1_di0_disp0>;
> > + };
> > + };
> > +
> > + port@1 {
> > + reg = <1>;
> > +
> > + display_out: endpoint {
> > + remote-endpoint = <&panel_in>;
> > + };
> > + };
> > + };
> > +
> > + keys {
> > + compatible = "gpio-keys";
> > + autorepeat;
> > +
> > + esc {
> > + label = "GPIO Key ESC";
> > + linux,code = <KEY_ESC>;
> > + gpios = <&gpio_pca 0 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + up {
> > + label = "GPIO Key UP";
> > + linux,code = <KEY_UP>;
> > + gpios = <&gpio_pca 1 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + down {
> > + label = "GPIO Key DOWN";
> > + linux,code = <KEY_DOWN>;
> > + gpios = <&gpio_pca 4 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + enter {
> > + label = "GPIO Key Enter";
> > + linux,code = <KEY_ENTER>;
> > + gpios = <&gpio_pca 3 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + cycle {
> > + label = "GPIO Key CYCLE";
> > + linux,code = <KEY_CYCLEWINDOWS>;
> > + gpios = <&gpio_pca 2 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f1 {
> > + label = "GPIO Key F1";
> > + linux,code = <KEY_F1>;
> > + gpios = <&gpio_pca 14 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f2 {
> > + label = "GPIO Key F2";
> > + linux,code = <KEY_F2>;
> > + gpios = <&gpio_pca 13 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f3 {
> > + label = "GPIO Key F3";
> > + linux,code = <KEY_F3>;
> > + gpios = <&gpio_pca 12 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f4 {
> > + label = "GPIO Key F4";
> > + linux,code = <KEY_F4>;
> > + gpios = <&gpio_pca 11 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f5 {
> > + label = "GPIO Key F5";
> > + linux,code = <KEY_F5>;
> > + gpios = <&gpio_pca 10 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f6 {
> > + label = "GPIO Key F6";
> > + linux,code = <KEY_F6>;
> > + gpios = <&gpio_pca 5 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f7 {
> > + label = "GPIO Key F7";
> > + linux,code = <KEY_F7>;
> > + gpios = <&gpio_pca 6 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f8 {
> > + label = "GPIO Key F8";
> > + linux,code = <KEY_F8>;
> > + gpios = <&gpio_pca 7 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f9 {
> > + label = "GPIO Key F9";
> > + linux,code = <KEY_F9>;
> > + gpios = <&gpio_pca 8 GPIO_ACTIVE_LOW>;
> > + };
> > +
> > + f10 {
> > + label = "GPIO Key F10";
> > + linux,code = <KEY_F10>;
> > + gpios = <&gpio_pca 9 GPIO_ACTIVE_LOW>;
> > + };
>
> Don't know if there is a common rule if the gpio key should be sorted
> alphabetical too.
>
> > + };
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_leds>;
> > +
> > + led-debug0 {
> > + function = LED_FUNCTION_STATUS;
> > + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> > + linux,default-trigger = "heartbeat";
> > + };
> > + };
> > +
> > + panel {
> > + compatible = "innolux,g070y2t0ec";
>
> Did you send a patch for this panel?
Good catch. Yes, there is a patch for this panel. Maybe that patch should come
first, Oleksij?
> > + backlight = <&backlight_lcd>;
> > +
> > + port {
> > + panel_in: endpoint {
> > + remote-endpoint = <&display_out>;
> > + };
> > + };
> > + };
> > +
> > + reg_12v_bl: regulator-bl-12v {
>
> Nit, it's common to allign the pahndle and the name, so either:
>
> reg_12v_bl -> regulator-12v-bl
>
> or
>
> reg_bl_12v -> regulator-bl-12v
>
> also it would be cool to keep the first digit after the point like you
> did it for the 1.8 regulator. So the result would be:
>
> reg_12v0_bl -> regulator-12v0-bl
>
> or
>
> reg_bl_12v0 -> regulator-bl-12v0
I'm not strictly against it, but isn't the implicit rule "All significant
digits, with a minimum of 2" even better here? Just saying... 12000v0 would
look a bit awkward ;-)
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_reg_12v_bl>;
> > + regulator-name = "12v-bl";
> > + regulator-min-microvolt = <12000000>;
> > + regulator-max-microvolt = <12000000>;
> > + gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + };
> > +
> > + reg_1v8: regulator-1v8 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "1v8";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-always-on;
> > + };
> > +
> > + sound {
> > + compatible = "simple-audio-card";
> > + simple-audio-card,name = "prti6q-sgtl5000";
> > + simple-audio-card,format = "i2s";
> > + simple-audio-card,widgets =
> > + "Microphone", "Microphone Jack",
> > + "Line", "Line In Jack",
> > + "Headphone", "Headphone Jack",
> > + "Speaker", "External Speaker";
> > + simple-audio-card,routing =
> > + "MIC_IN", "Microphone Jack",
> > + "LINE_IN", "Line In Jack",
> > + "Headphone Jack", "HP_OUT",
> > + "External Speaker", "LINE_OUT";
> > +
> > + simple-audio-card,cpu {
> > + sound-dai = <&ssi1>;
> > + system-clock-frequency = <0>;
> > + };
> > +
> > + simple-audio-card,codec {
> > + sound-dai = <&sgtl5000>;
> > + bitclock-master;
> > + frame-master;
> > + };
> > + };
> > +};
> > +
> > +&clks {
> > + assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>;
> > + assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>;
> > +};
> > +
> > +&ecspi2 {
> > + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_ecspi2>;
> > + status = "okay";
> > +
> > + tsc@0 {
> > + compatible = "ti,tsc2046";
> > + reg = <0>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_tsc>;
> > + spi-max-frequency = <100000>;
> > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
>
> The this should be listed within the binding doc.
>
> > + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
>
> IRQ and the GPIO are the same gpio line?
Yes, this driver uses the same GPIO as interrupt and also as a GPIO. A bit
strange, I agree. It is the same pin on the TS controller.
> > + vcc-supply = <®_3v3>;
> > +
> > + ti,vref-delay-usecs = /bits/ 16 <100>;
> > +
> > + ti,x-min = /bits/ 16 <0>;
> > + ti,x-max = /bits/ 16 <8000>;
> > + ti,y-min = /bits/ 16 <0>;
> > + ti,y-max = /bits/ 16 <4800>;
> > + ti,x-plate-ohms = /bits/ 16 <800>;
> > + ti,y-plate-ohms = /bits/ 16 <300>;
> > + ti,pressure-max = /bits/ 16 <4095>;
> > +
> > + ti,skip-samples = <2>;
> > + ti,sample-period-msecs = <10>;
> > + ti,report-period-msecs = <30>;
> > +
> > + ti,filter-tolerance = <80>;
> > + ti,touch-resistance-threshold = <3500>;
Now that I see this, this DT node corresponds to a rewritten version of the
ads7846 touchscreen driver, which probably also should precede this patch?
The original driver is horribly buggy, and I have submitted patches twice
already long ago to input mailing list, but unfortunately it got completely
ignored both times.
> > + };
> > +};
> > +
> > +&audmux {
>
> Pls, sort it alphabetical.
>
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_audmux>;
> > + status = "okay";
> > +
> > + mux_ssi1 {
> > + fsl,audmux-port = <0>;
> > + fsl,port-config = <
> > + IMX_AUDMUX_V2_PTCR_SYN 0
> > + IMX_AUDMUX_V2_PTCR_TFSEL(2) 0
> > + IMX_AUDMUX_V2_PTCR_TCSEL(2) 0
> > + IMX_AUDMUX_V2_PTCR_TFSDIR 0
> > + IMX_AUDMUX_V2_PTCR_TCLKDIR IMX_AUDMUX_V2_PDCR_RXDSEL(2)
> > + >;
> > + };
> > +
> > + mux_pins3 {
> > + fsl,audmux-port = <2>;
> > + fsl,port-config = <
> > + IMX_AUDMUX_V2_PTCR_SYN IMX_AUDMUX_V2_PDCR_RXDSEL(0)
> > + 0 IMX_AUDMUX_V2_PDCR_TXRXEN
> > + >;
> > + };
> > +};
> > +
> > +&can1 {
>
> This here too.
>
> > + pinctrl-0 = <&pinctrl_can1 &pinctrl_can1phy>;
> > +};
> > +
> > +&i2c1 {
> > + sgtl5000: codec@a {
> > + compatible = "fsl,sgtl5000";
> > + reg = <0xa>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_codec>;
> > + #sound-dai-cells = <0>;
> > + clocks = <&clks 201>;
> > + VDDA-supply = <®_3v3>;
> > + VDDIO-supply = <®_3v3>;
> > + VDDD-supply = <®_1v8>;
> > + };
> > +};
> > +
> > +&i2c3 {
> > + rtc@51 {
> > + compatible = "nxp,pcf8563";
> > + reg = <0x51>;
> > + };
> > +
> > + gpio_pca: gpio@74 {
> > + compatible = "nxp,pca9539";
> > + reg = <0x74>;
> > + interrupts-extended = <&gpio4 5 IRQ_TYPE_LEVEL_LOW>;
> > + #gpio-cells = <2>;
> > + gpio-controller;
> > + };
> > +};
> > +
> > +&ipu1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_ipu1_csi0>;
> > + status = "okay";
> > +};
> > +
> > +&ipu1_di0_disp0 {
> > + remote-endpoint = <&display_in>;
> > +};
> > +
> > +&pwm1 {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_pwm1>;
> > + status = "okay";
> > +};
> > +
> > +&snvs_poweroff {
> > + status = "okay";
> > +};
> > +
> > +&snvs_pwrkey {
> > + status = "okay";
> > +};
> > +
> > +&ssi1 {
> > + #sound-dai-cells = <0>;
> > + fsl,mode = "i2s-slave";
> > + status = "okay";
> > +};
> > +
> > +&usbh1 {
> > + status = "disabled";
> > +};
> > +
> > +&vpu {
> > + status = "disabled";
> > +};
>
> Why do you disable this nodes? You should drop it from the common .dtsi
> if you disable them more than once.
We should have to count the enables and disables, and decide which solution
ends up with less lines of code overall, I suppose.
Our boards DT's are built in a kind of class hierarchy. There are a total of
16+ different i.MX6 boards. Almost all of them inherit from PRTI6Q, and some
have other, higher-order ancestors. Oleksij is busy with the first few of them
right now.
We can optimize all inheritances for the few boards that are being submitted
now, but if the rest will follow, the end result might either be less than
optimal, or this will need to change again.
> > +&iomuxc {
> > + pinctrl_audmux: audmuxgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_CSI0_MCLK__CCM_CLKO1 0x030b0
> > + MX6QDL_PAD_CSI0_DAT7__AUD3_RXD 0x130b0
> > + MX6QDL_PAD_CSI0_DAT4__AUD3_TXC 0x130b0
> > + MX6QDL_PAD_CSI0_DAT5__AUD3_TXD 0x110b0
> > + MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS 0x130b0
> > + >;
> > + };
> > +
> > + pinctrl_can1phy: can1phy {
> > + fsl,pins = <
> > + /* CAN1_SR */
> > + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x13070
> > + /* CAN1_TERM */
> > + MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0
> > + >;
> > + };
> > +
> > + pinctrl_codec: codecgrp {
> > + fsl,pins = <
> > + /* AUDIO_nRESET */
> > + MX6QDL_PAD_CSI0_VSYNC__GPIO5_IO21 0x1f0b0
> > + >;
> > + };
> > +
> > + pinctrl_ecspi2: ecspi2grp {
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_OE__ECSPI2_MISO 0x100b1
> > + MX6QDL_PAD_EIM_CS0__ECSPI2_SCLK 0x100b1
> > + MX6QDL_PAD_EIM_CS1__ECSPI2_MOSI 0x100b1
> > + MX6QDL_PAD_EIM_RW__GPIO2_IO26 0x000b1
> > + >;
> > + };
> > +
> > + pinctrl_ipu1_csi0: ipu1csi0grp {
> > + fsl,pins = <
> > + MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT13__IPU1_CSI0_DATA13 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT14__IPU1_CSI0_DATA14 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT15__IPU1_CSI0_DATA15 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT16__IPU1_CSI0_DATA16 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT17__IPU1_CSI0_DATA17 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT18__IPU1_CSI0_DATA18 0x1b0b0
> > + MX6QDL_PAD_CSI0_DAT19__IPU1_CSI0_DATA19 0x1b0b0
> > + MX6QDL_PAD_CSI0_PIXCLK__IPU1_CSI0_PIXCLK 0x1b0b0
> > + /* ITU656_nRESET */
> > + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0
> > + /* ITU656_nPDN */
> > + MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b0
> > + >;
> > + };
>
> Why do you mux the the camera interface and have no camera device within
> this dt.
Because the camera requires more patches that are on the way to mainline, but
not there yet. Maybe for now these should be removed?
> > + pinctrl_ipu1_disp: ipudisp1grp {
> > + fsl,pins = <
> > + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0xb0
> > + MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0xb0
> > +
> > + MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0xb0
> > + MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0xb0
> > + MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0xb0
> > + MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0xb0
> > + MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0xb0
> > + MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0xb0
> > + MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0xb0
> > + MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0xb0
> > +
> > + MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0xb0
> > + MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0xb0
> > + MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0xb0
> > + MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0xb0
> > + MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0xb0
> > + MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0xb0
> > + MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0xb0
> > + MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0xb0
> > +
> > + MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0xb0
> > + MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0xb0
> > + MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0xb0
> > + MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0xb0
> > + MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0xb0
> > + MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0xb0
> > + MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0xb0
> > + MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0xb0
> > + >;
> > + };
> > +
> > + pinctrl_leds: ledsgrp {
> > + fsl,pins = <
> > + MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
> > + >;
> > + };
> > +
> > + pinctrl_pwm1: pwm1grp {
> > + fsl,pins = <
> > + MX6QDL_PAD_GPIO_9__PWM1_OUT 0x1b0b0
> > + >;
> > + };
> > +
> > + pinctrl_reg_12v_bl: 12blgrp {
>
> Pls, keep the name scheme like the others.
>
> Regards,
> Marco
>
> > + fsl,pins = <
> > + MX6QDL_PAD_GPIO_7__GPIO1_IO07 0x1b0b0
> > + >;
> > + };
> > +
> > + pinctrl_tsc: tscgrp {
> > +
> > + fsl,pins = <
> > + MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b0
> > + MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0
> > + >;
> > + };
> > +};
Best regards,
--
David Jander
Protonic Holland.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH v6 3/5] ARM: dts: add Protonic VT7 board
2020-04-22 9:38 ` David Jander
@ 2020-04-22 11:20 ` Marco Felsch
0 siblings, 0 replies; 12+ messages in thread
From: Marco Felsch @ 2020-04-22 11:20 UTC (permalink / raw)
To: David Jander
Cc: Oleksij Rempel, Mark Rutland, Rob Herring, Sascha Hauer,
Shawn Guo, devicetree, Rob Herring, Robin van der Gracht,
linux-kernel, NXP Linux Team, Pengutronix Kernel Team,
Fabio Estevam, linux-arm-kernel
I David,
On 20-04-22 11:38, David Jander wrote:
>
> Hi Marco,
>
> Just chiming in with the answers I know most of...
Thanks for your reponse =)
> On Wed, 22 Apr 2020 09:04:41 +0200
> Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> > Hi Oleksij,
> >
> > On 20-04-21 14:40, Oleksij Rempel wrote:
> > > The Protonic VT7 is a mid-class ISObus Virtual Terminal with a 7 inch
> > > touchscreen display.
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> > > Signed-off-by: David Jander <david@protonic.nl>
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > > arch/arm/boot/dts/Makefile | 1 +
> > > arch/arm/boot/dts/imx6dl-prtvt7.dts | 472 ++++++++++++++++++++++++++++
> > > 2 files changed, 473 insertions(+)
> > > create mode 100644 arch/arm/boot/dts/imx6dl-prtvt7.dts
> > >
> > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > > index 8ce744f1cbfc9..66ee89e7929f9 100644
> > > --- a/arch/arm/boot/dts/Makefile
> > > +++ b/arch/arm/boot/dts/Makefile
> > > @@ -450,6 +450,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
> > > imx6dl-pico-hobbit.dtb \
> > > imx6dl-pico-nymph.dtb \
> > > imx6dl-pico-pi.dtb \
> > > + imx6dl-prtvt7.dtb \
> > > imx6dl-rex-basic.dtb \
> > > imx6dl-riotboard.dtb \
> > > imx6dl-sabreauto.dtb \
> > > diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> > > new file mode 100644
> > > index 0000000000000..a948c7c6eb3ce
> > > --- /dev/null
> > > +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> > > @@ -0,0 +1,472 @@
> > > +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> > > +/*
> > > + * Copyright (c) 2016 Protonic Holland
> > > + */
> > > +
> > > +/dts-v1/;
> > > +#include "imx6dl.dtsi"
> > > +#include "imx6qdl-prti6q.dtsi"
> >
> > Should we name it "imx6qdl-prt-common.dtsi"? Still don't like that this
> > dtsi comes from the 1st commit rather then having a single commit adding
> > the .dtsi but that is only my opinion.
>
> Isn't the extension ".dtsi" implying "common" already?
> This file is strictly common to the "prti6q" family of products, not to all
> Protonic products, so the name you suggest would be potentially misleading I
> guess. Maybe we can just leave it like this?
It was just a suggestion. It's not that obvious that the WD2 is part of
the PRTI6Q family for outsiders.
> > > +#include <dt-bindings/input/input.h>
> > > +#include <dt-bindings/leds/common.h>
> > > +#include <dt-bindings/sound/fsl-imx-audmux.h>
> > > +
> > > +/ {
> > > + model = "Protonic VT7";
> > > + compatible = "prt,prtvt7", "fsl,imx6dl";
> > > +
> > > + memory@10000000 {
> > > + device_type = "memory";
> > > + reg = <0x10000000 0x20000000>;
> > > + };
> > > +
> > > + backlight_lcd: backlight-lcd {
> > > + compatible = "pwm-backlight";
> > > + pwms = <&pwm1 0 500000>;
> > > + brightness-levels = <0 20 81 248 1000>;
> > > + default-brightness-level = <20>;
> > > + num-interpolated-steps = <21>;
> >
> > Do you need this fine granularity here? Just asking ;)
>
> Yes. These amount of steps are needed.
>
> > > + power-supply = <®_12v_bl>;
> > > + enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>;
> >
> > Where gets this gpio muxed?
>
> In imx6qdl-prti6q.dtsi
Yep, thanks for the link. So you override here the complete node since
it has the extact name. What do you want to change here and why didn't
you use phandle from the .dtsi?
> > > + };
> > > +
> > > + display {
> > > + compatible = "fsl,imx-parallel-display";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_ipu1_disp>;
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + interface-pix-fmt = "rgb24";
> > > + status = "okay";
> >
> > Status not needed here.
>
> Ack.
>
> > > +
> > > + port@0 {
> > > + reg = <0>;
> > > +
> > > + display_in: endpoint {
> > > + remote-endpoint = <&ipu1_di0_disp0>;
> > > + };
> > > + };
> > > +
> > > + port@1 {
> > > + reg = <1>;
> > > +
> > > + display_out: endpoint {
> > > + remote-endpoint = <&panel_in>;
> > > + };
> > > + };
> > > + };
> > > +
> > > + keys {
> > > + compatible = "gpio-keys";
> > > + autorepeat;
> > > +
> > > + esc {
> > > + label = "GPIO Key ESC";
> > > + linux,code = <KEY_ESC>;
> > > + gpios = <&gpio_pca 0 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + up {
> > > + label = "GPIO Key UP";
> > > + linux,code = <KEY_UP>;
> > > + gpios = <&gpio_pca 1 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + down {
> > > + label = "GPIO Key DOWN";
> > > + linux,code = <KEY_DOWN>;
> > > + gpios = <&gpio_pca 4 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + enter {
> > > + label = "GPIO Key Enter";
> > > + linux,code = <KEY_ENTER>;
> > > + gpios = <&gpio_pca 3 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + cycle {
> > > + label = "GPIO Key CYCLE";
> > > + linux,code = <KEY_CYCLEWINDOWS>;
> > > + gpios = <&gpio_pca 2 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f1 {
> > > + label = "GPIO Key F1";
> > > + linux,code = <KEY_F1>;
> > > + gpios = <&gpio_pca 14 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f2 {
> > > + label = "GPIO Key F2";
> > > + linux,code = <KEY_F2>;
> > > + gpios = <&gpio_pca 13 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f3 {
> > > + label = "GPIO Key F3";
> > > + linux,code = <KEY_F3>;
> > > + gpios = <&gpio_pca 12 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f4 {
> > > + label = "GPIO Key F4";
> > > + linux,code = <KEY_F4>;
> > > + gpios = <&gpio_pca 11 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f5 {
> > > + label = "GPIO Key F5";
> > > + linux,code = <KEY_F5>;
> > > + gpios = <&gpio_pca 10 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f6 {
> > > + label = "GPIO Key F6";
> > > + linux,code = <KEY_F6>;
> > > + gpios = <&gpio_pca 5 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f7 {
> > > + label = "GPIO Key F7";
> > > + linux,code = <KEY_F7>;
> > > + gpios = <&gpio_pca 6 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f8 {
> > > + label = "GPIO Key F8";
> > > + linux,code = <KEY_F8>;
> > > + gpios = <&gpio_pca 7 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f9 {
> > > + label = "GPIO Key F9";
> > > + linux,code = <KEY_F9>;
> > > + gpios = <&gpio_pca 8 GPIO_ACTIVE_LOW>;
> > > + };
> > > +
> > > + f10 {
> > > + label = "GPIO Key F10";
> > > + linux,code = <KEY_F10>;
> > > + gpios = <&gpio_pca 9 GPIO_ACTIVE_LOW>;
> > > + };
> >
> > Don't know if there is a common rule if the gpio key should be sorted
> > alphabetical too.
> >
> > > + };
> > > +
> > > + leds {
> > > + compatible = "gpio-leds";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_leds>;
> > > +
> > > + led-debug0 {
> > > + function = LED_FUNCTION_STATUS;
> > > + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> > > + linux,default-trigger = "heartbeat";
> > > + };
> > > + };
> > > +
> > > + panel {
> > > + compatible = "innolux,g070y2t0ec";
> >
> > Did you send a patch for this panel?
>
> Good catch. Yes, there is a patch for this panel. Maybe that patch should come
> first, Oleksij?
I would appreciate this. It happens often that drivers are not mainlined
yet but patches are on the ML and on their way to mainline.
> > > + backlight = <&backlight_lcd>;
> > > +
> > > + port {
> > > + panel_in: endpoint {
> > > + remote-endpoint = <&display_out>;
> > > + };
> > > + };
> > > + };
> > > +
> > > + reg_12v_bl: regulator-bl-12v {
> >
> > Nit, it's common to allign the pahndle and the name, so either:
> >
> > reg_12v_bl -> regulator-12v-bl
> >
> > or
> >
> > reg_bl_12v -> regulator-bl-12v
> >
> > also it would be cool to keep the first digit after the point like you
> > did it for the 1.8 regulator. So the result would be:
> >
> > reg_12v0_bl -> regulator-12v0-bl
> >
> > or
> >
> > reg_bl_12v0 -> regulator-bl-12v0
>
> I'm not strictly against it, but isn't the implicit rule "All significant
> digits, with a minimum of 2" even better here? Just saying... 12000v0 would
> look a bit awkward ;-)
Yep, that looks a bit awkward.. What I wanted to say is to keep the
style over the DTs and don't mix them.
> > > + compatible = "regulator-fixed";
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_reg_12v_bl>;
> > > + regulator-name = "12v-bl";
> > > + regulator-min-microvolt = <12000000>;
> > > + regulator-max-microvolt = <12000000>;
> > > + gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> > > + enable-active-high;
> > > + };
> > > +
> > > + reg_1v8: regulator-1v8 {
> > > + compatible = "regulator-fixed";
> > > + regulator-name = "1v8";
> > > + regulator-min-microvolt = <1800000>;
> > > + regulator-max-microvolt = <1800000>;
> > > + regulator-always-on;
> > > + };
> > > +
> > > + sound {
> > > + compatible = "simple-audio-card";
> > > + simple-audio-card,name = "prti6q-sgtl5000";
> > > + simple-audio-card,format = "i2s";
> > > + simple-audio-card,widgets =
> > > + "Microphone", "Microphone Jack",
> > > + "Line", "Line In Jack",
> > > + "Headphone", "Headphone Jack",
> > > + "Speaker", "External Speaker";
> > > + simple-audio-card,routing =
> > > + "MIC_IN", "Microphone Jack",
> > > + "LINE_IN", "Line In Jack",
> > > + "Headphone Jack", "HP_OUT",
> > > + "External Speaker", "LINE_OUT";
> > > +
> > > + simple-audio-card,cpu {
> > > + sound-dai = <&ssi1>;
> > > + system-clock-frequency = <0>;
> > > + };
> > > +
> > > + simple-audio-card,codec {
> > > + sound-dai = <&sgtl5000>;
> > > + bitclock-master;
> > > + frame-master;
> > > + };
> > > + };
> > > +};
> > > +
> > > +&clks {
> > > + assigned-clocks = <&clks IMX6QDL_CLK_LDB_DI0_SEL>;
> > > + assigned-clock-parents = <&clks IMX6QDL_CLK_PLL5_VIDEO_DIV>;
> > > +};
> > > +
> > > +&ecspi2 {
> > > + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_ecspi2>;
> > > + status = "okay";
> > > +
> > > + tsc@0 {
> > > + compatible = "ti,tsc2046";
> > > + reg = <0>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_tsc>;
> > > + spi-max-frequency = <100000>;
> > > + interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
> >
> > The this should be listed within the binding doc.
> >
> > > + pendown-gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> >
> > IRQ and the GPIO are the same gpio line?
>
> Yes, this driver uses the same GPIO as interrupt and also as a GPIO. A bit
> strange, I agree. It is the same pin on the TS controller.
>
> > > + vcc-supply = <®_3v3>;
> > > +
> > > + ti,vref-delay-usecs = /bits/ 16 <100>;
> > > +
> > > + ti,x-min = /bits/ 16 <0>;
> > > + ti,x-max = /bits/ 16 <8000>;
> > > + ti,y-min = /bits/ 16 <0>;
> > > + ti,y-max = /bits/ 16 <4800>;
> > > + ti,x-plate-ohms = /bits/ 16 <800>;
> > > + ti,y-plate-ohms = /bits/ 16 <300>;
> > > + ti,pressure-max = /bits/ 16 <4095>;
> > > +
> > > + ti,skip-samples = <2>;
> > > + ti,sample-period-msecs = <10>;
> > > + ti,report-period-msecs = <30>;
> > > +
> > > + ti,filter-tolerance = <80>;
> > > + ti,touch-resistance-threshold = <3500>;
>
> Now that I see this, this DT node corresponds to a rewritten version of the
> ads7846 touchscreen driver, which probably also should precede this patch?
> The original driver is horribly buggy, and I have submitted patches twice
> already long ago to input mailing list, but unfortunately it got completely
> ignored both times.
Pls, can you resend the patches with cc me or give me some pointers? So
we can give them another try.
> > > + };
> > > +};
> > > +
> > > +&audmux {
> >
> > Pls, sort it alphabetical.
> >
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_audmux>;
> > > + status = "okay";
> > > +
> > > + mux_ssi1 {
> > > + fsl,audmux-port = <0>;
> > > + fsl,port-config = <
> > > + IMX_AUDMUX_V2_PTCR_SYN 0
> > > + IMX_AUDMUX_V2_PTCR_TFSEL(2) 0
> > > + IMX_AUDMUX_V2_PTCR_TCSEL(2) 0
> > > + IMX_AUDMUX_V2_PTCR_TFSDIR 0
> > > + IMX_AUDMUX_V2_PTCR_TCLKDIR IMX_AUDMUX_V2_PDCR_RXDSEL(2)
> > > + >;
> > > + };
> > > +
> > > + mux_pins3 {
> > > + fsl,audmux-port = <2>;
> > > + fsl,port-config = <
> > > + IMX_AUDMUX_V2_PTCR_SYN IMX_AUDMUX_V2_PDCR_RXDSEL(0)
> > > + 0 IMX_AUDMUX_V2_PDCR_TXRXEN
> > > + >;
> > > + };
> > > +};
> > > +
> > > +&can1 {
> >
> > This here too.
> >
> > > + pinctrl-0 = <&pinctrl_can1 &pinctrl_can1phy>;
> > > +};
> > > +
> > > +&i2c1 {
> > > + sgtl5000: codec@a {
> > > + compatible = "fsl,sgtl5000";
> > > + reg = <0xa>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_codec>;
> > > + #sound-dai-cells = <0>;
> > > + clocks = <&clks 201>;
> > > + VDDA-supply = <®_3v3>;
> > > + VDDIO-supply = <®_3v3>;
> > > + VDDD-supply = <®_1v8>;
> > > + };
> > > +};
> > > +
> > > +&i2c3 {
> > > + rtc@51 {
> > > + compatible = "nxp,pcf8563";
> > > + reg = <0x51>;
> > > + };
> > > +
> > > + gpio_pca: gpio@74 {
> > > + compatible = "nxp,pca9539";
> > > + reg = <0x74>;
> > > + interrupts-extended = <&gpio4 5 IRQ_TYPE_LEVEL_LOW>;
> > > + #gpio-cells = <2>;
> > > + gpio-controller;
> > > + };
> > > +};
> > > +
> > > +&ipu1 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_ipu1_csi0>;
> > > + status = "okay";
> > > +};
> > > +
> > > +&ipu1_di0_disp0 {
> > > + remote-endpoint = <&display_in>;
> > > +};
> > > +
> > > +&pwm1 {
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&pinctrl_pwm1>;
> > > + status = "okay";
> > > +};
> > > +
> > > +&snvs_poweroff {
> > > + status = "okay";
> > > +};
> > > +
> > > +&snvs_pwrkey {
> > > + status = "okay";
> > > +};
> > > +
> > > +&ssi1 {
> > > + #sound-dai-cells = <0>;
> > > + fsl,mode = "i2s-slave";
> > > + status = "okay";
> > > +};
> > > +
> > > +&usbh1 {
> > > + status = "disabled";
> > > +};
> > > +
> > > +&vpu {
> > > + status = "disabled";
> > > +};
> >
> > Why do you disable this nodes? You should drop it from the common .dtsi
> > if you disable them more than once.
>
> We should have to count the enables and disables, and decide which solution
> ends up with less lines of code overall, I suppose.
> Our boards DT's are built in a kind of class hierarchy. There are a total of
> 16+ different i.MX6 boards. Almost all of them inherit from PRTI6Q, and some
> have other, higher-order ancestors. Oleksij is busy with the first few of them
> right now.
> We can optimize all inheritances for the few boards that are being submitted
> now, but if the rest will follow, the end result might either be less than
> optimal, or this will need to change again.
I see, but I still prefer the "enable once" way since it is a bit more
straight forward. But it should be no blocker..
> > > +&iomuxc {
> > > + pinctrl_audmux: audmuxgrp {
> > > + fsl,pins = <
> > > + MX6QDL_PAD_CSI0_MCLK__CCM_CLKO1 0x030b0
> > > + MX6QDL_PAD_CSI0_DAT7__AUD3_RXD 0x130b0
> > > + MX6QDL_PAD_CSI0_DAT4__AUD3_TXC 0x130b0
> > > + MX6QDL_PAD_CSI0_DAT5__AUD3_TXD 0x110b0
> > > + MX6QDL_PAD_CSI0_DAT6__AUD3_TXFS 0x130b0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_can1phy: can1phy {
> > > + fsl,pins = <
> > > + /* CAN1_SR */
> > > + MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x13070
> > > + /* CAN1_TERM */
> > > + MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_codec: codecgrp {
> > > + fsl,pins = <
> > > + /* AUDIO_nRESET */
> > > + MX6QDL_PAD_CSI0_VSYNC__GPIO5_IO21 0x1f0b0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_ecspi2: ecspi2grp {
> > > + fsl,pins = <
> > > + MX6QDL_PAD_EIM_OE__ECSPI2_MISO 0x100b1
> > > + MX6QDL_PAD_EIM_CS0__ECSPI2_SCLK 0x100b1
> > > + MX6QDL_PAD_EIM_CS1__ECSPI2_MOSI 0x100b1
> > > + MX6QDL_PAD_EIM_RW__GPIO2_IO26 0x000b1
> > > + >;
> > > + };
> > > +
> > > + pinctrl_ipu1_csi0: ipu1csi0grp {
> > > + fsl,pins = <
> > > + MX6QDL_PAD_CSI0_DAT12__IPU1_CSI0_DATA12 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT13__IPU1_CSI0_DATA13 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT14__IPU1_CSI0_DATA14 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT15__IPU1_CSI0_DATA15 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT16__IPU1_CSI0_DATA16 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT17__IPU1_CSI0_DATA17 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT18__IPU1_CSI0_DATA18 0x1b0b0
> > > + MX6QDL_PAD_CSI0_DAT19__IPU1_CSI0_DATA19 0x1b0b0
> > > + MX6QDL_PAD_CSI0_PIXCLK__IPU1_CSI0_PIXCLK 0x1b0b0
> > > + /* ITU656_nRESET */
> > > + MX6QDL_PAD_GPIO_2__GPIO1_IO02 0x1b0b0
> > > + /* ITU656_nPDN */
> > > + MX6QDL_PAD_CSI0_DATA_EN__GPIO5_IO20 0x1b0b0
> > > + >;
> > > + };
> >
> > Why do you mux the the camera interface and have no camera device within
> > this dt.
>
> Because the camera requires more patches that are on the way to mainline, but
> not there yet. Maybe for now these should be removed?
Adding the muxing later would be the better way.
Regards,
Marco
> > > + pinctrl_ipu1_disp: ipudisp1grp {
> > > + fsl,pins = <
> > > + MX6QDL_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK 0xb0
> > > + MX6QDL_PAD_DI0_PIN15__IPU1_DI0_PIN15 0xb0
> > > +
> > > + MX6QDL_PAD_DISP0_DAT0__IPU1_DISP0_DATA00 0xb0
> > > + MX6QDL_PAD_DISP0_DAT1__IPU1_DISP0_DATA01 0xb0
> > > + MX6QDL_PAD_DISP0_DAT2__IPU1_DISP0_DATA02 0xb0
> > > + MX6QDL_PAD_DISP0_DAT3__IPU1_DISP0_DATA03 0xb0
> > > + MX6QDL_PAD_DISP0_DAT4__IPU1_DISP0_DATA04 0xb0
> > > + MX6QDL_PAD_DISP0_DAT5__IPU1_DISP0_DATA05 0xb0
> > > + MX6QDL_PAD_DISP0_DAT6__IPU1_DISP0_DATA06 0xb0
> > > + MX6QDL_PAD_DISP0_DAT7__IPU1_DISP0_DATA07 0xb0
> > > +
> > > + MX6QDL_PAD_DISP0_DAT8__IPU1_DISP0_DATA08 0xb0
> > > + MX6QDL_PAD_DISP0_DAT9__IPU1_DISP0_DATA09 0xb0
> > > + MX6QDL_PAD_DISP0_DAT10__IPU1_DISP0_DATA10 0xb0
> > > + MX6QDL_PAD_DISP0_DAT11__IPU1_DISP0_DATA11 0xb0
> > > + MX6QDL_PAD_DISP0_DAT12__IPU1_DISP0_DATA12 0xb0
> > > + MX6QDL_PAD_DISP0_DAT13__IPU1_DISP0_DATA13 0xb0
> > > + MX6QDL_PAD_DISP0_DAT14__IPU1_DISP0_DATA14 0xb0
> > > + MX6QDL_PAD_DISP0_DAT15__IPU1_DISP0_DATA15 0xb0
> > > +
> > > + MX6QDL_PAD_DISP0_DAT16__IPU1_DISP0_DATA16 0xb0
> > > + MX6QDL_PAD_DISP0_DAT17__IPU1_DISP0_DATA17 0xb0
> > > + MX6QDL_PAD_DISP0_DAT18__IPU1_DISP0_DATA18 0xb0
> > > + MX6QDL_PAD_DISP0_DAT19__IPU1_DISP0_DATA19 0xb0
> > > + MX6QDL_PAD_DISP0_DAT20__IPU1_DISP0_DATA20 0xb0
> > > + MX6QDL_PAD_DISP0_DAT21__IPU1_DISP0_DATA21 0xb0
> > > + MX6QDL_PAD_DISP0_DAT22__IPU1_DISP0_DATA22 0xb0
> > > + MX6QDL_PAD_DISP0_DAT23__IPU1_DISP0_DATA23 0xb0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_leds: ledsgrp {
> > > + fsl,pins = <
> > > + MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_pwm1: pwm1grp {
> > > + fsl,pins = <
> > > + MX6QDL_PAD_GPIO_9__PWM1_OUT 0x1b0b0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_reg_12v_bl: 12blgrp {
> >
> > Pls, keep the name scheme like the others.
> >
> > Regards,
> > Marco
> >
> > > + fsl,pins = <
> > > + MX6QDL_PAD_GPIO_7__GPIO1_IO07 0x1b0b0
> > > + >;
> > > + };
> > > +
> > > + pinctrl_tsc: tscgrp {
> > > +
> > > + fsl,pins = <
> > > + MX6QDL_PAD_EIM_D20__GPIO3_IO20 0x1b0b0
> > > + MX6QDL_PAD_EIM_EB2__GPIO2_IO30 0x1b0b0
> > > + >;
> > > + };
> > > +};
>
> Best regards,
>
> --
> David Jander
> Protonic Holland.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v6 4/5] ARM: dts: add Protonic RVT board
2020-04-21 12:40 [PATCH v6 0/5] mainline Protonic boards Oleksij Rempel
` (2 preceding siblings ...)
2020-04-21 12:40 ` [PATCH v6 3/5] ARM: dts: add Protonic VT7 board Oleksij Rempel
@ 2020-04-21 12:40 ` Oleksij Rempel
2020-04-21 12:40 ` [PATCH v6 5/5] dt-bindings: arm: fsl: add different Protonic boards Oleksij Rempel
4 siblings, 0 replies; 12+ messages in thread
From: Oleksij Rempel @ 2020-04-21 12:40 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, Rob Herring, David Jander, devicetree,
Fabio Estevam, linux-arm-kernel, linux-kernel, NXP Linux Team,
Pengutronix Kernel Team
Protonic RVT is an internal development platform for a wireless ISObus
Virtual Terminal based on COTS tablets, and the predecessor of the WD2
platform.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/imx6dl-prtrvt.dts | 182 ++++++++++++++++++++++++++++
2 files changed, 183 insertions(+)
create mode 100644 arch/arm/boot/dts/imx6dl-prtrvt.dts
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 66ee89e7929f9..89842a034e4ba 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -450,6 +450,7 @@ dtb-$(CONFIG_SOC_IMX6Q) += \
imx6dl-pico-hobbit.dtb \
imx6dl-pico-nymph.dtb \
imx6dl-pico-pi.dtb \
+ imx6dl-prtrvt.dtb \
imx6dl-prtvt7.dtb \
imx6dl-rex-basic.dtb \
imx6dl-riotboard.dtb \
diff --git a/arch/arm/boot/dts/imx6dl-prtrvt.dts b/arch/arm/boot/dts/imx6dl-prtrvt.dts
new file mode 100644
index 0000000000000..b7721e52a463a
--- /dev/null
+++ b/arch/arm/boot/dts/imx6dl-prtrvt.dts
@@ -0,0 +1,182 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Copyright (c) 2014 Protonic Holland
+ */
+
+/dts-v1/;
+#include "imx6dl.dtsi"
+#include "imx6qdl-prti6q.dtsi"
+#include <dt-bindings/leds/common.h>
+
+/ {
+ model = "Protonic RVT board";
+ compatible = "prt,prtrvt", "fsl,imx6dl";
+
+ memory@10000000 {
+ device_type = "memory";
+ reg = <0x10000000 0x10000000>;
+ };
+
+ leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_leds>;
+
+ led-debug0 {
+ function = LED_FUNCTION_STATUS;
+ gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "heartbeat";
+ };
+ };
+};
+
+&can1 {
+ pinctrl-0 = <&pinctrl_can1 &pinctrl_can1phy>;
+};
+
+&ecspi1 {
+ cs-gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi1>;
+ status = "okay";
+
+ flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <20000000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ };
+};
+
+&ecspi3 {
+ cs-gpios = <&gpio4 24 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_ecspi3>;
+ status = "okay";
+
+ nfc@0 {
+ compatible = "ti,trf7970a";
+ reg = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_nfc>;
+ spi-max-frequency = <2000000>;
+ interrupts-extended = <&gpio5 14 IRQ_TYPE_LEVEL_LOW>;
+ ti,enable-gpios = <&gpio5 12 GPIO_ACTIVE_LOW>,
+ <&gpio5 11 GPIO_ACTIVE_LOW>;
+ vin-supply = <®_3v3>;
+ vin-voltage-override = <3100000>;
+ autosuspend-delay = <30000>;
+ irq-status-read-quirk;
+ en2-rf-quirk;
+ t5t-rmb-extra-byte-quirk;
+ status = "okay";
+ };
+};
+
+&i2c3 {
+ adc@49 {
+ compatible = "ti,ads1015";
+ reg = <0x49>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* nc */
+ channel@4 {
+ reg = <4>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+
+ /* nc */
+ channel@5 {
+ reg = <5>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+
+ /* can1_l */
+ channel@6 {
+ reg = <6>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+
+ /* can1_h */
+ channel@7 {
+ reg = <7>;
+ ti,gain = <3>;
+ ti,datarate = <3>;
+ };
+ };
+
+ rtc@51 {
+ compatible = "nxp,pcf8563";
+ reg = <0x51>;
+ };
+};
+
+&pcie {
+ status = "okay";
+};
+
+&usbh1 {
+ status = "disabled";
+};
+
+&vpu {
+ status = "disabled";
+};
+
+&iomuxc {
+ pinctrl_can1phy: can1phy {
+ fsl,pins = <
+ /* CAN1_SR */
+ MX6QDL_PAD_KEY_COL3__GPIO4_IO12 0x13070
+ /* CAN1_TERM */
+ MX6QDL_PAD_GPIO_0__GPIO1_IO00 0x1b0b0
+ >;
+ };
+
+ pinctrl_ecspi1: ecspi1grp {
+ fsl,pins = <
+ MX6QDL_PAD_EIM_D17__ECSPI1_MISO 0x100b1
+ MX6QDL_PAD_EIM_D18__ECSPI1_MOSI 0x100b1
+ MX6QDL_PAD_EIM_D16__ECSPI1_SCLK 0x100b1
+ /* CS */
+ MX6QDL_PAD_EIM_D19__GPIO3_IO19 0x000b1
+ >;
+ };
+
+ pinctrl_ecspi3: ecspi3grp {
+ fsl,pins = <
+ MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK 0x100b1
+ MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI 0x100b1
+ MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO 0x100b1
+ MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x000b1
+ >;
+ };
+
+ pinctrl_leds: ledsgrp {
+ fsl,pins = <
+ MX6QDL_PAD_GPIO_8__GPIO1_IO08 0x1b0b0
+ >;
+ };
+
+ pinctrl_nfc: nfcgrp {
+ fsl,pins = <
+ /* NFC_ASK_OOK */
+ MX6QDL_PAD_DISP0_DAT15__GPIO5_IO09 0x100b1
+ /* NFC_PWR_EN */
+ MX6QDL_PAD_DISP0_DAT16__GPIO5_IO10 0x100b1
+ /* NFC_EN2 */
+ MX6QDL_PAD_DISP0_DAT17__GPIO5_IO11 0x100b1
+ /* NFC_EN */
+ MX6QDL_PAD_DISP0_DAT18__GPIO5_IO12 0x100b1
+ /* NFC_MOD */
+ MX6QDL_PAD_DISP0_DAT19__GPIO5_IO13 0x100b1
+ /* NFC_IRQ */
+ MX6QDL_PAD_DISP0_DAT20__GPIO5_IO14 0x100b1
+ >;
+ };
+};
--
2.26.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH v6 5/5] dt-bindings: arm: fsl: add different Protonic boards
2020-04-21 12:40 [PATCH v6 0/5] mainline Protonic boards Oleksij Rempel
` (3 preceding siblings ...)
2020-04-21 12:40 ` [PATCH v6 4/5] ARM: dts: add Protonic RVT board Oleksij Rempel
@ 2020-04-21 12:40 ` Oleksij Rempel
2020-05-05 19:00 ` Rob Herring
4 siblings, 1 reply; 12+ messages in thread
From: Oleksij Rempel @ 2020-04-21 12:40 UTC (permalink / raw)
To: Mark Rutland, Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, devicetree, Fabio Estevam, linux-arm-kernel,
linux-kernel, NXP Linux Team, Pengutronix Kernel Team
Add Protonic PRTI6Q, WD2, RVT, VT7 boards.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index cd3fbe7e39487..a1657505b3357 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -119,6 +119,8 @@ properties:
- fsl,imx6q-sabreauto
- fsl,imx6q-sabrelite
- fsl,imx6q-sabresd
+ - prt,prti6q # Protonic PRTI6Q board
+ - prt,prtwd2 # Protonic WD2 board
- technexion,imx6q-pico-dwarf # TechNexion i.MX6Q Pico-Dwarf
- technexion,imx6q-pico-hobbit # TechNexion i.MX6Q Pico-Hobbit
- technexion,imx6q-pico-nymph # TechNexion i.MX6Q Pico-Nymph
@@ -170,6 +172,8 @@ properties:
- emtrion,emcon-mx6-avari # emCON-MX6S or emCON-MX6DL SoM on Avari Base
- fsl,imx6dl-sabreauto # i.MX6 DualLite/Solo SABRE Automotive Board
- fsl,imx6dl-sabresd # i.MX6 DualLite SABRE Smart Device Board
+ - prt,prtrvt # Protonic RVT board
+ - prt,prtvt7 # Protonic VT7 board
- technexion,imx6dl-pico-dwarf # TechNexion i.MX6DL Pico-Dwarf
- technexion,imx6dl-pico-hobbit # TechNexion i.MX6DL Pico-Hobbit
- technexion,imx6dl-pico-nymph # TechNexion i.MX6DL Pico-Nymph
--
2.26.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH v6 5/5] dt-bindings: arm: fsl: add different Protonic boards
2020-04-21 12:40 ` [PATCH v6 5/5] dt-bindings: arm: fsl: add different Protonic boards Oleksij Rempel
@ 2020-05-05 19:00 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2020-05-05 19:00 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Mark Rutland, devicetree, linux-kernel, Oleksij Rempel,
NXP Linux Team, Pengutronix Kernel Team, Fabio Estevam,
linux-arm-kernel
On Tue, 21 Apr 2020 14:40:57 +0200, Oleksij Rempel wrote:
> Add Protonic PRTI6Q, WD2, RVT, VT7 boards.
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
> Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 12+ messages in thread