* [PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c
@ 2020-05-04 11:33 Jason Yan
2020-05-06 8:47 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-05-04 11:33 UTC (permalink / raw)
To: pkshih, kvalo, davem, linux-wireless, netdev, linux-kernel; +Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:476:6-14: WARNING:
Comparison to bool
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:54:5-22: WARNING:
Comparison to bool
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c
index 0f401ad92c2e..c376817a1bf4 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c
@@ -51,7 +51,7 @@ void rtl88e_phy_rf6052_set_cck_txpower(struct ieee80211_hw *hw,
if (rtlefuse->eeprom_regulatory != 0)
turbo_scanoff = true;
- if (mac->act_scanning == true) {
+ if (mac->act_scanning) {
tx_agc[RF90_PATH_A] = 0x3f3f3f3f;
tx_agc[RF90_PATH_B] = 0x3f3f3f3f;
@@ -473,7 +473,7 @@ static bool _rtl88e_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
break;
}
- if (rtstatus != true) {
+ if (!rtstatus) {
RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE,
"Radio[%d] Fail!!\n", rfpath);
return false;
--
2.21.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c
2020-05-04 11:33 [PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c Jason Yan
@ 2020-05-06 8:47 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2020-05-06 8:47 UTC (permalink / raw)
To: Jason Yan; +Cc: pkshih, davem, linux-wireless, netdev, linux-kernel, Jason Yan
Jason Yan <yanaijie@huawei.com> wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:476:6-14: WARNING:
> Comparison to bool
> drivers/net/wireless/realtek/rtlwifi/rtl8188ee/rf.c:54:5-22: WARNING:
> Comparison to bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
cbb1404f6541 rtlwifi: rtl8188ee: remove Comparison to bool in rf.c
--
https://patchwork.kernel.org/patch/11525533/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-06 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-04 11:33 [PATCH] rtlwifi: rtl8188ee: remove Comparison to bool in rf.c Jason Yan
2020-05-06 8:47 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).