* [PATCH -next] net: enetc: Make some symbols static
@ 2020-05-06 11:22 ChenTao
2020-05-06 21:20 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: ChenTao @ 2020-05-06 11:22 UTC (permalink / raw)
To: claudiu.manoil; +Cc: davem, netdev, linux-kernel, chentao107
Fix the following warning:
drivers/net/ethernet/freescale/enetc/enetc_qos.c:427:20: warning:
symbol 'enetc_act_fwd' was not declared. Should it be static?
drivers/net/ethernet/freescale/enetc/enetc_qos.c:966:20: warning:
symbol 'enetc_check_flow_actions' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: ChenTao <chentao107@huawei.com>
---
drivers/net/ethernet/freescale/enetc/enetc_qos.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index 48e589e9d0f7..172acb602ccb 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -424,7 +424,7 @@ struct enetc_psfp {
spinlock_t psfp_lock; /* spinlock for the struct enetc_psfp r/w */
};
-struct actions_fwd enetc_act_fwd[] = {
+static struct actions_fwd enetc_act_fwd[] = {
{
BIT(FLOW_ACTION_GATE),
BIT(FLOW_DISSECTOR_KEY_ETH_ADDRS),
@@ -963,7 +963,8 @@ static int enetc_psfp_hw_set(struct enetc_ndev_priv *priv,
return err;
}
-struct actions_fwd *enetc_check_flow_actions(u64 acts, unsigned int inputkeys)
+static struct actions_fwd *enetc_check_flow_actions(u64 acts,
+ unsigned int inputkeys)
{
int i;
--
2.22.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net: enetc: Make some symbols static
2020-05-06 11:22 [PATCH -next] net: enetc: Make some symbols static ChenTao
@ 2020-05-06 21:20 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-06 21:20 UTC (permalink / raw)
To: chentao107; +Cc: claudiu.manoil, netdev, linux-kernel
From: ChenTao <chentao107@huawei.com>
Date: Wed, 6 May 2020 19:22:17 +0800
> Fix the following warning:
>
> drivers/net/ethernet/freescale/enetc/enetc_qos.c:427:20: warning:
> symbol 'enetc_act_fwd' was not declared. Should it be static?
> drivers/net/ethernet/freescale/enetc/enetc_qos.c:966:20: warning:
> symbol 'enetc_check_flow_actions' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: ChenTao <chentao107@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-06 21:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 11:22 [PATCH -next] net: enetc: Make some symbols static ChenTao
2020-05-06 21:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).