* [PATCH] kgdb: Return true in kgdb_nmi_poll_knock()
@ 2020-05-07 11:06 Jason Yan
2020-05-07 15:10 ` Doug Anderson
2020-05-11 13:08 ` Daniel Thompson
0 siblings, 2 replies; 3+ messages in thread
From: Jason Yan @ 2020-05-07 11:06 UTC (permalink / raw)
To: jason.wessel, daniel.thompson, dianders, kgdb-bugreport, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
include/linux/kgdb.h:301:54-55: WARNING: return of 0/1 in function
'kgdb_nmi_poll_knock' with return type bool
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
include/linux/kgdb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
index b072aeb1fd78..042828aeb73d 100644
--- a/include/linux/kgdb.h
+++ b/include/linux/kgdb.h
@@ -298,7 +298,7 @@ extern bool kgdb_nmi_poll_knock(void);
#else
static inline int kgdb_register_nmi_console(void) { return 0; }
static inline int kgdb_unregister_nmi_console(void) { return 0; }
-static inline bool kgdb_nmi_poll_knock(void) { return 1; }
+static inline bool kgdb_nmi_poll_knock(void) { return true; }
#endif
extern int kgdb_register_io_module(struct kgdb_io *local_kgdb_io_ops);
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] kgdb: Return true in kgdb_nmi_poll_knock()
2020-05-07 11:06 [PATCH] kgdb: Return true in kgdb_nmi_poll_knock() Jason Yan
@ 2020-05-07 15:10 ` Doug Anderson
2020-05-11 13:08 ` Daniel Thompson
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2020-05-07 15:10 UTC (permalink / raw)
To: Jason Yan; +Cc: Jason Wessel, Daniel Thompson, kgdb-bugreport, LKML
Hi,
On Thu, May 7, 2020 at 4:07 AM Jason Yan <yanaijie@huawei.com> wrote:
>
> Fix the following coccicheck warning:
>
> include/linux/kgdb.h:301:54-55: WARNING: return of 0/1 in function
> 'kgdb_nmi_poll_knock' with return type bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> include/linux/kgdb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kgdb: Return true in kgdb_nmi_poll_knock()
2020-05-07 11:06 [PATCH] kgdb: Return true in kgdb_nmi_poll_knock() Jason Yan
2020-05-07 15:10 ` Doug Anderson
@ 2020-05-11 13:08 ` Daniel Thompson
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2020-05-11 13:08 UTC (permalink / raw)
To: Jason Yan; +Cc: jason.wessel, dianders, kgdb-bugreport, linux-kernel
On Thu, May 07, 2020 at 07:06:49PM +0800, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> include/linux/kgdb.h:301:54-55: WARNING: return of 0/1 in function
> 'kgdb_nmi_poll_knock' with return type bool
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Applied, thanks.
> ---
> include/linux/kgdb.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kgdb.h b/include/linux/kgdb.h
> index b072aeb1fd78..042828aeb73d 100644
> --- a/include/linux/kgdb.h
> +++ b/include/linux/kgdb.h
> @@ -298,7 +298,7 @@ extern bool kgdb_nmi_poll_knock(void);
> #else
> static inline int kgdb_register_nmi_console(void) { return 0; }
> static inline int kgdb_unregister_nmi_console(void) { return 0; }
> -static inline bool kgdb_nmi_poll_knock(void) { return 1; }
> +static inline bool kgdb_nmi_poll_knock(void) { return true; }
> #endif
>
> extern int kgdb_register_io_module(struct kgdb_io *local_kgdb_io_ops);
> --
> 2.21.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-11 13:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-07 11:06 [PATCH] kgdb: Return true in kgdb_nmi_poll_knock() Jason Yan
2020-05-07 15:10 ` Doug Anderson
2020-05-11 13:08 ` Daniel Thompson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).