* [PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62
2020-05-08 22:59 [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Douglas Anderson
@ 2020-05-08 22:59 ` Douglas Anderson
2020-05-09 20:00 ` Sam Ravnborg
2020-05-08 22:59 ` [PATCH 3/3] panel: " Douglas Anderson
2020-05-09 20:00 ` [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Sam Ravnborg
2 siblings, 1 reply; 6+ messages in thread
From: Douglas Anderson @ 2020-05-08 22:59 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg
Cc: robdclark, linux-arm-msm, Bjorn Andersson, Douglas Anderson,
Daniel Vetter, David Airlie, Rob Herring, devicetree, dri-devel,
linux-kernel
This panel appears to be the same or nearly the same as the BOE
NV133FHM-N61, but since (in the very least) it identifies itself as a
different model in the EDID we should add a new compatible string for
it.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index fdd74d07f645..d6cca1479633 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -75,6 +75,8 @@ properties:
- boe,nv101wxmn51
# BOE NV133FHM-N61 13.3" FHD (1920x1080) TFT LCD Panel
- boe,nv133fhm-n61
+ # BOE NV133FHM-N62 13.3" FHD (1920x1080) TFT LCD Panel
+ - boe,nv133fhm-n62
# BOE NV140FHM-N49 14.0" FHD a-Si FT panel
- boe,nv140fhmn49
# CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel
--
2.26.2.645.ge9eca65c58-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62
2020-05-08 22:59 ` [PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62 Douglas Anderson
@ 2020-05-09 20:00 ` Sam Ravnborg
0 siblings, 0 replies; 6+ messages in thread
From: Sam Ravnborg @ 2020-05-09 20:00 UTC (permalink / raw)
To: Douglas Anderson
Cc: Thierry Reding, robdclark, linux-arm-msm, Bjorn Andersson,
Daniel Vetter, David Airlie, Rob Herring, devicetree, dri-devel,
linux-kernel
On Fri, May 08, 2020 at 03:59:01PM -0700, Douglas Anderson wrote:
> This panel appears to be the same or nearly the same as the BOE
> NV133FHM-N61, but since (in the very least) it identifies itself as a
> different model in the EDID we should add a new compatible string for
> it.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Applied this and the next patch to drm-misc-next.
Thanks,
Sam
> ---
>
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index fdd74d07f645..d6cca1479633 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -75,6 +75,8 @@ properties:
> - boe,nv101wxmn51
> # BOE NV133FHM-N61 13.3" FHD (1920x1080) TFT LCD Panel
> - boe,nv133fhm-n61
> + # BOE NV133FHM-N62 13.3" FHD (1920x1080) TFT LCD Panel
> + - boe,nv133fhm-n62
> # BOE NV140FHM-N49 14.0" FHD a-Si FT panel
> - boe,nv140fhmn49
> # CDTech(H.K.) Electronics Limited 4.3" 480x272 color TFT-LCD panel
> --
> 2.26.2.645.ge9eca65c58-goog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] panel: simple: Add BOE NV133FHM-N62
2020-05-08 22:59 [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Douglas Anderson
2020-05-08 22:59 ` [PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62 Douglas Anderson
@ 2020-05-08 22:59 ` Douglas Anderson
2020-05-09 20:00 ` [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Sam Ravnborg
2 siblings, 0 replies; 6+ messages in thread
From: Douglas Anderson @ 2020-05-08 22:59 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg
Cc: robdclark, linux-arm-msm, Bjorn Andersson, Douglas Anderson,
Daniel Vetter, David Airlie, dri-devel, linux-kernel
All info I could find about this panel show that it behaves the same
as the BOE NV133FHM-N61. However, it definitely appears to be a
unique panel because reading the EDID shows "NV133FHM-N62". We'll add
a string match for the new panel but until we find something unique
about it we'll just point at the N61's structures.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/gpu/drm/panel/panel-simple.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 7219436499f1..7fb7b257f968 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1173,6 +1173,7 @@ static const struct panel_desc boe_nv101wxmn51 = {
},
};
+/* Also used for boe_nv133fhm_n62 */
static const struct drm_display_mode boe_nv133fhm_n61_modes = {
.clock = 147840,
.hdisplay = 1920,
@@ -1186,6 +1187,7 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = {
.vrefresh = 60,
};
+/* Also used for boe_nv133fhm_n62 */
static const struct panel_desc boe_nv133fhm_n61 = {
.modes = &boe_nv133fhm_n61_modes,
.num_modes = 1,
@@ -3659,6 +3661,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "boe,nv133fhm-n61",
.data = &boe_nv133fhm_n61,
+ }, {
+ .compatible = "boe,nv133fhm-n62",
+ .data = &boe_nv133fhm_n61,
}, {
.compatible = "boe,nv140fhmn49",
.data = &boe_nv140fhmn49,
--
2.26.2.645.ge9eca65c58-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61
2020-05-08 22:59 [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Douglas Anderson
2020-05-08 22:59 ` [PATCH 2/3] dt-bindings: display: simple: Add BOE NV133FHM-N62 Douglas Anderson
2020-05-08 22:59 ` [PATCH 3/3] panel: " Douglas Anderson
@ 2020-05-09 20:00 ` Sam Ravnborg
2020-05-09 22:49 ` Doug Anderson
2 siblings, 1 reply; 6+ messages in thread
From: Sam Ravnborg @ 2020-05-09 20:00 UTC (permalink / raw)
To: Douglas Anderson
Cc: Thierry Reding, robdclark, linux-arm-msm, Bjorn Andersson,
Daniel Vetter, David Airlie, dri-devel, linux-kernel
Hi Douglas
On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote:
> The BOE NV133FHM-N61 is documented in the original commit to be a
> 13.3" panel, but the size listed in our struct doesn't match.
> Specifically:
>
> math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92
>
> Searching around on the Internet shows that the size that was in the
> structure was the "Outline Size", not the "Display Area". Let's fix
> it.
>
> Also the Internet says that this panel supports 262K colors. That's
> 6bpp, not 8bpp.
>
> Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
Added to drm-misc-next as I did not think this had to be updated in
mainline right now. Let me know if you expect it to land in mainline
soonish.
Sam
> ---
>
> drivers/gpu/drm/panel/panel-simple.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index d6c29543e510..7219436499f1 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1189,10 +1189,10 @@ static const struct drm_display_mode boe_nv133fhm_n61_modes = {
> static const struct panel_desc boe_nv133fhm_n61 = {
> .modes = &boe_nv133fhm_n61_modes,
> .num_modes = 1,
> - .bpc = 8,
> + .bpc = 6,
> .size = {
> - .width = 300,
> - .height = 187,
> + .width = 294,
> + .height = 165,
> },
> .delay = {
> .hpd_absent_delay = 200,
> --
> 2.26.2.645.ge9eca65c58-goog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61
2020-05-09 20:00 ` [PATCH 1/3] panel: simple: Fix size and bpp of BOE NV133FHM-N61 Sam Ravnborg
@ 2020-05-09 22:49 ` Doug Anderson
0 siblings, 0 replies; 6+ messages in thread
From: Doug Anderson @ 2020-05-09 22:49 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Thierry Reding, Rob Clark, linux-arm-msm, Bjorn Andersson,
Daniel Vetter, David Airlie, dri-devel, LKML
Hi,
On Sat, May 9, 2020 at 1:00 PM Sam Ravnborg <sam@ravnborg.org> wrote:
>
> Hi Douglas
>
> On Fri, May 08, 2020 at 03:59:00PM -0700, Douglas Anderson wrote:
> > The BOE NV133FHM-N61 is documented in the original commit to be a
> > 13.3" panel, but the size listed in our struct doesn't match.
> > Specifically:
> >
> > math.sqrt(30.0 * 30.0 + 18.7 * 18.7) / 2.54 ==> 13.92
> >
> > Searching around on the Internet shows that the size that was in the
> > structure was the "Outline Size", not the "Display Area". Let's fix
> > it.
> >
> > Also the Internet says that this panel supports 262K colors. That's
> > 6bpp, not 8bpp.
> >
> > Fixes: b0c664cc80e8 ("panel: simple: Add BOE NV133FHM-N61")
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> Added to drm-misc-next as I did not think this had to be updated in
> mainline right now. Let me know if you expect it to land in mainline
> soonish.
drm-misc-next is perfect, thanks!
-Doug
^ permalink raw reply [flat|nested] 6+ messages in thread