From: Jakub Kicinski <kuba@kernel.org>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths
Date: Fri, 8 May 2020 19:04:02 -0700 [thread overview]
Message-ID: <20200508190402.76018e90@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.LNX.2.22.394.2005091143590.8@nippy.intranet>
On Sat, 9 May 2020 11:57:44 +1000 (AEST) Finn Thain wrote:
> On Fri, 8 May 2020, Jakub Kicinski wrote:
> > On Fri, 8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > > Only macsonic has been compile tested. I don't have the needed setup to
> > > compile xtsonic
> >
> > Well, we gotta do that before we apply the patch :S
> >
>
> I've compiled xtsonic.c with this patch.
>
> > Does the driver actually depend on some platform stuff,
>
> xtsonic.c looks portable enough but it has some asm includes that I
> haven't looked at. It is really a question for the arch maintainers.
I see.
> > or can we do this:
> >
> > diff --git a/drivers/net/ethernet/natsemi/Kconfig b/drivers/net/ethernet/natsemi/Kconfig
> > @@ -58,7 +58,7 @@ config NS83820
> >
> > config XTENSA_XT2000_SONIC
> > tristate "Xtensa XT2000 onboard SONIC Ethernet support"
> > - depends on XTENSA_PLATFORM_XT2000
> > + depends on XTENSA_PLATFORM_XT2000 || COMPILE_TEST
> > ---help---
> > This is the driver for the onboard card of the Xtensa XT2000 board.
> >
> > ?
> >
>
> That's effectively what I did to compile test xtsonic.c (I removed the
> line to get the same effect).
Thank you, that should do!
next prev parent reply other threads:[~2020-05-09 2:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 17:25 [PATCH] net/sonic: Fix some resource leaks in error handling paths Christophe JAILLET
2020-05-08 23:28 ` Finn Thain
2020-05-09 0:57 ` Jakub Kicinski
2020-05-09 1:57 ` Finn Thain
2020-05-09 2:04 ` Jakub Kicinski [this message]
2020-05-09 1:54 ` Jakub Kicinski
2020-05-09 16:47 ` Christophe JAILLET
2020-05-09 18:13 ` Jakub Kicinski
2020-05-09 20:31 ` Christophe JAILLET
2020-05-09 22:42 ` Joe Perches
2020-05-09 23:32 ` David Miller
2020-05-09 23:41 ` Joe Perches
2020-05-09 23:52 ` Finn Thain
2020-05-09 6:15 Markus Elfring
2020-05-09 23:45 ` Finn Thain
2020-05-10 5:30 ` Markus Elfring
2020-05-10 8:25 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508190402.76018e90@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=fthain@telegraphics.com.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).