linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
	davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/sonic: Fix some resource leaks in error handling paths
Date: Sun, 10 May 2020 09:52:24 +1000 (AEST)	[thread overview]
Message-ID: <alpine.LNX.2.22.394.2005100946241.11@nippy.intranet> (raw)
In-Reply-To: <20200508185402.41d9d068@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Fri, 8 May 2020, Jakub Kicinski wrote:

> On Fri,  8 May 2020 19:25:57 +0200 Christophe JAILLET wrote:
> > @@ -527,8 +531,9 @@ static int mac_sonic_platform_remove(struct platform_device *pdev)
> >  	struct sonic_local* lp = netdev_priv(dev);
> >  
> >  	unregister_netdev(dev);
> > -	dma_free_coherent(lp->device, SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode),
> > -	                  lp->descriptors, lp->descriptors_laddr);
> > +	dma_free_coherent(lp->device,
> > +			  SIZEOF_SONIC_DESC * SONIC_BUS_SCALE(lp->dma_bitmode),
> > +			  lp->descriptors, lp->descriptors_laddr);
> >  	free_netdev(dev);
> >  
> >  	return 0;
> 
> This is a white-space only change, right? Since this is a fix we should
> avoid making cleanups which are not strictly necessary.
> 

I think it is harmless if it doesn't create any merge conflicts. Any merge 
conflict created by the whitespace change would have happened anyway, 
because all of the changes in this patch are very closely related. That's 
why I was happy to put a 'reviewed-by' tag on this.

  parent reply	other threads:[~2020-05-09 23:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-08 17:25 [PATCH] net/sonic: Fix some resource leaks in error handling paths Christophe JAILLET
2020-05-08 23:28 ` Finn Thain
2020-05-09  0:57 ` Jakub Kicinski
2020-05-09  1:57   ` Finn Thain
2020-05-09  2:04     ` Jakub Kicinski
2020-05-09  1:54 ` Jakub Kicinski
2020-05-09 16:47   ` Christophe JAILLET
2020-05-09 18:13     ` Jakub Kicinski
2020-05-09 20:31       ` Christophe JAILLET
2020-05-09 22:42       ` Joe Perches
2020-05-09 23:32         ` David Miller
2020-05-09 23:41           ` Joe Perches
2020-05-09 23:52   ` Finn Thain [this message]
2020-05-09  6:15 Markus Elfring
2020-05-09 23:45 ` Finn Thain
2020-05-10  5:30   ` Markus Elfring
2020-05-10  8:25     ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.22.394.2005100946241.11@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).