* [PATCH] drm: vmwgfx: include linux/highmem.h
@ 2020-05-08 22:01 Arnd Bergmann
2020-05-09 3:14 ` Stephen Rothwell
2020-05-11 2:53 ` Ira Weiny
0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2020-05-08 22:01 UTC (permalink / raw)
To: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter,
Christian König
Cc: Arnd Bergmann, Ira Weiny, Christoph Hellwig, Daniel Vetter,
Andy Lutomirski, Benjamin Herrenschmidt, Borislav Petkov,
Chris Zankel, Dan Williams, Dave Hansen, David S. Miller,
Helge Deller, H. Peter Anvin, Huang Rui, Ingo Molnar,
James E.J. Bottomley, Max Filippov, Paul Mackerras,
Peter Zijlstra, Thomas Bogendoerfer, Thomas Gleixner, Al Viro,
Andrew Morton, Stephen Rothwell, dri-devel, linux-kernel
In order to call kmap_atomic() etc, we need to include linux/highmem.h:
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line':
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
377 | kunmap_atomic(d->src_addr);
| ^~~~~~~~~~~~~
| in_atomic
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration]
391 | kmap_atomic_prot(d->dst_pages[dst_page],
| ^~~~~~~~~~~~~~~~
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
390 | d->dst_addr =
| ^
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
403 | d->src_addr =
| ^
Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
index 94d456a1d1a9..1629427d5734 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
@@ -27,6 +27,7 @@
**************************************************************************/
#include "vmwgfx_drv.h"
+#include <linux/highmem.h>
/*
* Template that implements find_first_diff() for a generic
--
2.26.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: include linux/highmem.h
2020-05-08 22:01 [PATCH] drm: vmwgfx: include linux/highmem.h Arnd Bergmann
@ 2020-05-09 3:14 ` Stephen Rothwell
2020-05-12 17:29 ` Randy Dunlap
2020-05-11 2:53 ` Ira Weiny
1 sibling, 1 reply; 5+ messages in thread
From: Stephen Rothwell @ 2020-05-09 3:14 UTC (permalink / raw)
To: Arnd Bergmann
Cc: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter,
Christian König, Ira Weiny, Christoph Hellwig,
Daniel Vetter, Andy Lutomirski, Benjamin Herrenschmidt,
Borislav Petkov, Chris Zankel, Dan Williams, Dave Hansen,
David S. Miller, Helge Deller, H. Peter Anvin, Huang Rui,
Ingo Molnar, James E.J. Bottomley, Max Filippov, Paul Mackerras,
Peter Zijlstra, Thomas Bogendoerfer, Thomas Gleixner, Al Viro,
Andrew Morton, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
Hi Arnd,
On Sat, 9 May 2020 00:01:31 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>
> In order to call kmap_atomic() etc, we need to include linux/highmem.h:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line':
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
> 377 | kunmap_atomic(d->src_addr);
> | ^~~~~~~~~~~~~
> | in_atomic
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration]
> 391 | kmap_atomic_prot(d->dst_pages[dst_page],
> | ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 390 | d->dst_addr =
> | ^
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 403 | d->src_addr =
> | ^
>
> Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> index 94d456a1d1a9..1629427d5734 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> @@ -27,6 +27,7 @@
> **************************************************************************/
>
> #include "vmwgfx_drv.h"
> +#include <linux/highmem.h>
>
> /*
> * Template that implements find_first_diff() for a generic
> --
> 2.26.0
>
Added to linux-next for Monday (in case Andrew doesn't get around to it).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: include linux/highmem.h
2020-05-09 3:14 ` Stephen Rothwell
@ 2020-05-12 17:29 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2020-05-12 17:29 UTC (permalink / raw)
To: Stephen Rothwell, Arnd Bergmann
Cc: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter,
Christian König, Ira Weiny, Christoph Hellwig,
Daniel Vetter, Andy Lutomirski, Benjamin Herrenschmidt,
Borislav Petkov, Chris Zankel, Dan Williams, Dave Hansen,
David S. Miller, Helge Deller, H. Peter Anvin, Huang Rui,
Ingo Molnar, James E.J. Bottomley, Max Filippov, Paul Mackerras,
Peter Zijlstra, Thomas Bogendoerfer, Thomas Gleixner, Al Viro,
Andrew Morton, dri-devel, linux-kernel
On 5/8/20 8:14 PM, Stephen Rothwell wrote:
> Hi Arnd,
>
> On Sat, 9 May 2020 00:01:31 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> In order to call kmap_atomic() etc, we need to include linux/highmem.h:
>>
>> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line':
>> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
>> 377 | kunmap_atomic(d->src_addr);
>> | ^~~~~~~~~~~~~
>> | in_atomic
>> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration]
>> 391 | kmap_atomic_prot(d->dst_pages[dst_page],
>> | ^~~~~~~~~~~~~~~~
>> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
>> 390 | d->dst_addr =
>> | ^
>> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
>> 403 | d->src_addr =
>> | ^
>>
>> Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
>> index 94d456a1d1a9..1629427d5734 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
>> @@ -27,6 +27,7 @@
>> **************************************************************************/
>>
>> #include "vmwgfx_drv.h"
>> +#include <linux/highmem.h>
>>
>> /*
>> * Template that implements find_first_diff() for a generic
>> --
>> 2.26.0
>>
>
> Added to linux-next for Monday (in case Andrew doesn't get around to it).
>
Hi,
What happened with this patch?
I am seeing the same build problems in linux-next of 20200512.
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm: vmwgfx: include linux/highmem.h
2020-05-08 22:01 [PATCH] drm: vmwgfx: include linux/highmem.h Arnd Bergmann
2020-05-09 3:14 ` Stephen Rothwell
@ 2020-05-11 2:53 ` Ira Weiny
2020-05-11 7:52 ` Arnd Bergmann
1 sibling, 1 reply; 5+ messages in thread
From: Ira Weiny @ 2020-05-11 2:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter,
Christian König, Christoph Hellwig, Daniel Vetter,
Andy Lutomirski, Benjamin Herrenschmidt, Borislav Petkov,
Chris Zankel, Dan Williams, Dave Hansen, David S. Miller,
Helge Deller, H. Peter Anvin, Huang Rui, Ingo Molnar,
James E.J. Bottomley, Max Filippov, Paul Mackerras,
Peter Zijlstra, Thomas Bogendoerfer, Thomas Gleixner, Al Viro,
Andrew Morton, Stephen Rothwell, dri-devel, linux-kernel
On Sat, May 09, 2020 at 12:01:31AM +0200, Arnd Bergmann wrote:
> In order to call kmap_atomic() etc, we need to include linux/highmem.h:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line':
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
> 377 | kunmap_atomic(d->src_addr);
> | ^~~~~~~~~~~~~
> | in_atomic
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration]
> 391 | kmap_atomic_prot(d->dst_pages[dst_page],
> | ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 390 | d->dst_addr =
> | ^
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 403 | d->src_addr =
> | ^
>
> Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I'm curious about the config which failed... Because this compiled for me.
Regardless it was stupid of me to not include this.
Thanks,
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_blit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> index 94d456a1d1a9..1629427d5734 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_blit.c
> @@ -27,6 +27,7 @@
> **************************************************************************/
>
> #include "vmwgfx_drv.h"
> +#include <linux/highmem.h>
>
> /*
> * Template that implements find_first_diff() for a generic
> --
> 2.26.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm: vmwgfx: include linux/highmem.h
2020-05-11 2:53 ` Ira Weiny
@ 2020-05-11 7:52 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2020-05-11 7:52 UTC (permalink / raw)
To: Ira Weiny
Cc: VMware Graphics, Thomas Hellstrom, David Airlie, Daniel Vetter,
Christian König, Christoph Hellwig, Daniel Vetter,
Andy Lutomirski, Benjamin Herrenschmidt, Borislav Petkov,
Chris Zankel, Dan Williams, Dave Hansen, David S. Miller,
Helge Deller, H. Peter Anvin, Huang Rui, Ingo Molnar,
James E.J. Bottomley, Max Filippov, Paul Mackerras,
Peter Zijlstra, Thomas Bogendoerfer, Thomas Gleixner, Al Viro,
Andrew Morton, Stephen Rothwell, dri-devel, linux-kernel
On Mon, May 11, 2020 at 4:53 AM Ira Weiny <ira.weiny@intel.com> wrote:
>
> On Sat, May 09, 2020 at 12:01:31AM +0200, Arnd Bergmann wrote:
> > In order to call kmap_atomic() etc, we need to include linux/highmem.h:
> >
> > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line':
> > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of function 'kunmap_atomic'; did you mean 'in_atomic'? [-Werror=implicit-function-declaration]
> > 377 | kunmap_atomic(d->src_addr);
> > | ^~~~~~~~~~~~~
> > | in_atomic
> > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:391:5: error: implicit declaration of function 'kmap_atomic_prot' [-Werror=implicit-function-declaration]
> > 391 | kmap_atomic_prot(d->dst_pages[dst_page],
> > | ^~~~~~~~~~~~~~~~
> > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:390:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
> > 390 | d->dst_addr =
> > | ^
> > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:403:16: warning: assignment to 'u8 *' {aka 'unsigned char *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
> > 403 | d->src_addr =
> > | ^
> >
> > Fixes: 46385a895322 ("drm: remove drm specific kmap_atomic code")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> I'm curious about the config which failed... Because this compiled for me.
> Regardless it was stupid of me to not include this.
>
> Thanks,
>
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
I do a lot of randconfig build tests and only one of them had this problem.
See https://pastebin.com/LmX0Jfbg for reference, I did not check further
which of the options caused this.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-12 17:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 22:01 [PATCH] drm: vmwgfx: include linux/highmem.h Arnd Bergmann
2020-05-09 3:14 ` Stephen Rothwell
2020-05-12 17:29 ` Randy Dunlap
2020-05-11 2:53 ` Ira Weiny
2020-05-11 7:52 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).