From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Stefan Chulski <stefanc@marvell.com>
Cc: Matteo Croce <mcroce@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
Marcin Wojtas <mw@semihalf.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables
Date: Sat, 9 May 2020 14:25:24 +0100 [thread overview]
Message-ID: <20200509132524.GD1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <DM5PR18MB11462564D691544445CA2A43B0A30@DM5PR18MB1146.namprd18.prod.outlook.com>
On Sat, May 09, 2020 at 12:31:21PM +0000, Stefan Chulski wrote:
> > -----Original Message-----
> > From: Matteo Croce <mcroce@redhat.com>
> > Sent: Saturday, May 9, 2020 3:16 PM
> > To: Stefan Chulski <stefanc@marvell.com>
> > Cc: David S . Miller <davem@davemloft.net>; Maxime Chevallier
> > <maxime.chevallier@bootlin.com>; netdev <netdev@vger.kernel.org>; LKML
> > <linux-kernel@vger.kernel.org>; Antoine Tenart
> > <antoine.tenart@bootlin.com>; Thomas Petazzoni
> > <thomas.petazzoni@bootlin.com>; gregory.clement@bootlin.com;
> > miquel.raynal@bootlin.com; Nadav Haklai <nadavh@marvell.com>; Marcin
> > Wojtas <mw@semihalf.com>; Linux ARM <linux-arm-
> > kernel@lists.infradead.org>; Russell King - ARM Linux admin
> > <linux@armlinux.org.uk>
> > Subject: Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to
> > handle RSS tables
> >
> > Hi,
> >
> > The point is that RXHASH works fine on all interfaces, but on the gigabit one
> > (eth2 usually).
> > And on the 10 gbit interface is very very effective, the throughput goes 4x when
> > enabled, so it would be a big drawback to disable it on all interfaces.
> >
> > Honestly I don't have any 2.5 gbit hardware to test it on eth3, so I don't know if
> > rxhash actually only works on the first interface of a unit (so eth0 and eth1), or
> > if it just doesn't work on the gigabit one.
> >
> > If someone could test it on the 2.5 gbit port, this will be helpful.
>
> RSS tables is part of Packet Processor IP, not MAC(so it's not related to specific speed). Probably issue exist on specific packet processor ports.
> Since RSS work fine on first port of the CP, we can do the following:
> if (port-> id == 0)
> dev->hw_features |= NETIF_F_RXHASH;
I can confirm that Macchiatobin Single Shot eth0 port works with a
1G Fibre SFP or 10G DA SFP with or without rxhash on.
So it seems Stefan's hunch that it is port related is correct.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
next prev parent reply other threads:[~2020-05-09 13:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 10:05 [PATCH net-next 0/5] net: mvpp2: Classifier updates, RSS Maxime Chevallier
2019-05-24 10:05 ` [PATCH net-next 1/5] net: mvpp2: cls: Use the correct number of rules in various places Maxime Chevallier
2019-05-24 10:05 ` [PATCH net-next 2/5] net: mvpp2: cls: Bypass C2 internals FIFOs at init Maxime Chevallier
2019-05-24 10:05 ` [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables Maxime Chevallier
2020-04-13 23:43 ` Matteo Croce
2020-04-23 17:00 ` Russell King - ARM Linux admin
2020-05-09 0:12 ` Matteo Croce
2020-05-09 11:15 ` [EXT] " Stefan Chulski
2020-05-09 11:45 ` Russell King - ARM Linux admin
2020-05-09 12:16 ` Thomas Petazzoni
2020-05-09 12:48 ` Russell King - ARM Linux admin
2020-05-09 13:10 ` Thomas Petazzoni
2020-05-09 13:14 ` Matteo Croce
2020-05-09 13:51 ` Russell King - ARM Linux admin
2020-05-09 14:48 ` Russell King - ARM Linux admin
2020-05-09 15:31 ` Matteo Croce
2020-05-09 19:52 ` Russell King - ARM Linux admin
2020-05-09 20:20 ` Russell King - ARM Linux admin
2020-05-19 9:53 ` Russell King - ARM Linux admin
2020-05-19 10:05 ` Matteo Croce
2020-05-19 17:05 ` Matteo Croce
2020-05-20 11:10 ` Russell King - ARM Linux admin
2020-05-20 11:16 ` Matteo Croce
2020-05-20 11:18 ` Russell King - ARM Linux admin
2020-05-09 12:16 ` Matteo Croce
2020-05-09 12:31 ` Stefan Chulski
2020-05-09 13:25 ` Russell King - ARM Linux admin [this message]
2019-05-24 10:05 ` [PATCH net-next 4/5] net: mvpp2: cls: Extract the RSS context when parsing the ethtool rule Maxime Chevallier
2019-05-24 10:05 ` [PATCH net-next 5/5] net: mvpp2: cls: Support steering to RSS contexts Maxime Chevallier
2019-05-25 23:38 ` [PATCH net-next 0/5] net: mvpp2: Classifier updates, RSS David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200509132524.GD1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=antoine.tenart@bootlin.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mcroce@redhat.com \
--cc=miquel.raynal@bootlin.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).