From: Changbin Du <changbin.du@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: [PATCH 18/19] perf ftrace: add option --latency-format to display more info about delay
Date: Sun, 10 May 2020 23:06:27 +0800 [thread overview]
Message-ID: <20200510150628.16610-19-changbin.du@gmail.com> (raw)
In-Reply-To: <20200510150628.16610-1-changbin.du@gmail.com>
This is for the function graph tracer to display more info about latency.
The execution context is shown in this case.
$ sudo perf ftrace -G --latency-format
\# tracer: function_graph
\#
1) .... | 0.992 us | mutex_unlock();
1) .... | 1.404 us | __fsnotify_parent();
1) .... | 1.023 us | fsnotify();
1) .... | 0.335 us | __sb_end_write();
1) d... | 0.439 us | fpregs_assert_state_consistent();
1) d... | | do_syscall_64() {
1) .... | | __x64_sys_close() {
Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
tools/perf/builtin-ftrace.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index d376b37c53fc..fd8e2f305136 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -44,6 +44,7 @@ struct perf_ftrace {
bool nosleep_time;
bool nofuncgraph_irqs;
bool funcgraph_tail;
+ bool latency_format;
bool long_info;
unsigned tracing_thresh;
bool trace_children;
@@ -217,6 +218,7 @@ static void reset_tracing_options(struct perf_ftrace *ftrace __maybe_unused)
write_tracing_option_file("sleep-time", "1");
write_tracing_option_file("funcgraph-irqs", "1");
write_tracing_option_file("funcgraph-tail", "0");
+ write_tracing_option_file("latency-format", "0");
write_tracing_option_file("funcgraph-proc", "0");
write_tracing_option_file("funcgraph-abstime", "0");
write_tracing_option_file("irq-info", "0");
@@ -456,6 +458,17 @@ static int set_tracing_funcgraph_tail(struct perf_ftrace *ftrace)
return 0;
}
+static int set_tracing_latency_format(struct perf_ftrace *ftrace)
+{
+ if (!ftrace->latency_format)
+ return 0;
+
+ if (write_tracing_option_file("latency-format", "1") < 0)
+ return -1;
+
+ return 0;
+}
+
static int set_tracing_trace_children(struct perf_ftrace *ftrace)
{
if (!ftrace->trace_children)
@@ -579,6 +592,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
goto out_reset;
}
+ if (set_tracing_latency_format(ftrace) < 0) {
+ pr_err("failed to set tracing option latency-format\n");
+ goto out_reset;
+ }
+
if (set_tracing_trace_children(ftrace) < 0) {
pr_err("failed to set tracing option function-fork\n");
goto out_reset;
@@ -748,6 +766,8 @@ int cmd_ftrace(int argc, const char **argv)
"Ignore functions that happen inside interrupt (function_graph only)"),
OPT_BOOLEAN(0, "funcgraph-tail", &ftrace.funcgraph_tail,
"Show function tails comment (function_graph only)"),
+ OPT_BOOLEAN(0, "latency-format", &ftrace.latency_format,
+ "displays additional information about the latency (function_graph only)"),
OPT_BOOLEAN('l', "long-info", &ftrace.long_info,
"Show process names, PIDs, timestamps, irq-info if available"),
OPT_UINTEGER(0, "tracing-thresh", &ftrace.tracing_thresh,
--
2.25.1
next prev parent reply other threads:[~2020-05-10 15:10 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 15:06 [PATCH 00/19] perf: ftrace enhancement Changbin Du
2020-05-10 15:06 ` [PATCH 01/19] perf ftrace: trace system wide if no target is given Changbin Du
2020-05-20 20:47 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 02/19] perf ftrace: detect workload failure Changbin Du
2020-05-20 20:51 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 03/19] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-05-20 20:56 ` Arnaldo Carvalho de Melo
2020-05-31 5:52 ` Namhyung Kim
2020-06-06 14:28 ` Changbin Du
2020-05-10 15:06 ` [PATCH 04/19] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-05-20 20:58 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 05/19] perf ftrace: add option '-l/--list-functions' to list available functions Changbin Du
2020-05-20 20:59 ` Arnaldo Carvalho de Melo
2020-06-06 14:42 ` Changbin Du
2020-05-10 15:06 ` [PATCH 06/19] perf ftrace: add support for trace option sleep-time Changbin Du
2020-05-20 21:01 ` Arnaldo Carvalho de Melo
2020-05-31 5:56 ` Namhyung Kim
2020-06-06 14:19 ` Changbin Du
2020-05-10 15:06 ` [PATCH 07/19] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-05-20 21:01 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 08/19] perf ftrace: add option -l/--long-info to show more info Changbin Du
2020-05-20 21:02 ` Arnaldo Carvalho de Melo
2020-05-31 6:00 ` Namhyung Kim
2020-06-06 14:14 ` Changbin Du
2020-05-10 15:06 ` [PATCH 09/19] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-05-20 21:03 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 10/19] perf ftrace: add support for trace option funcgraph-tail Changbin Du
2020-05-20 21:03 ` Arnaldo Carvalho de Melo
2020-05-20 21:05 ` Arnaldo Carvalho de Melo
2020-05-31 6:07 ` Namhyung Kim
2020-06-25 11:21 ` Changbin Du
2020-05-10 15:06 ` [PATCH 11/19] perf ftrace: add option '-u/--userstacktrace' to show userspace stacktrace Changbin Du
2020-05-20 21:07 ` Arnaldo Carvalho de Melo
2020-06-14 11:15 ` Changbin Du
2020-05-10 15:06 ` [PATCH 12/19] perf ftrace: add support for tracing children processes Changbin Du
2020-05-20 21:07 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 13/19] perf ftrace: add option '-b/--buffer-size' to set per-cpu buffer size Changbin Du
2020-05-20 21:08 ` Arnaldo Carvalho de Melo
2020-06-06 14:43 ` Changbin Du
2020-05-10 15:06 ` [PATCH 14/19] perf ftrace: add option -P/--no-pager to disable pager Changbin Du
2020-05-20 21:09 ` Arnaldo Carvalho de Melo
2020-06-06 14:40 ` Changbin Du
2020-05-10 15:06 ` [PATCH 15/19] perf ftrace: show trace column header Changbin Du
2020-05-20 21:11 ` Arnaldo Carvalho de Melo
2020-06-06 14:37 ` Changbin Du
2020-05-10 15:06 ` [PATCH 16/19] perf ftrace: add option -t/--tid to filter by thread id Changbin Du
2020-05-20 21:12 ` Arnaldo Carvalho de Melo
2020-06-06 14:32 ` Changbin Du
2020-05-10 15:06 ` [PATCH 17/19] perf ftrace: add option -d/--delay to delay tracing Changbin Du
2020-05-20 21:13 ` Arnaldo Carvalho de Melo
2020-06-06 14:30 ` Changbin Du
2020-05-10 15:06 ` Changbin Du [this message]
2020-05-20 21:14 ` [PATCH 18/19] perf ftrace: add option --latency-format to display more info about delay Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 19/19] perf ftrace: add change log Changbin Du
2020-05-10 15:23 ` [PATCH 00/19] perf: ftrace enhancement Steven Rostedt
2020-05-10 16:18 ` Arnaldo Melo
2020-05-20 20:31 ` Arnaldo Carvalho de Melo
2020-05-26 0:17 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510150628.16610-19-changbin.du@gmail.com \
--to=changbin.du@gmail.com \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).