From: Changbin Du <changbin.du@gmail.com>
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Cc: Changbin Du <changbin.du@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/19] perf ftrace: add option '-l/--list-functions' to list available functions
Date: Sat, 6 Jun 2020 22:42:53 +0800 [thread overview]
Message-ID: <20200606144253.sdo2f5o54d5zdic7@mail.google.com> (raw)
In-Reply-To: <20200520205940.GS32678@kernel.org>
On Wed, May 20, 2020 at 05:59:40PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sun, May 10, 2020 at 11:06:14PM +0800, Changbin Du escreveu:
> > This adds an option '-l/--list-functions' to list all available functions
> > which is read from tracing file 'available_filter_functions'.
>
> Here, in 'perf probe' we have:
>
> [acme@five perf]$ perf probe -F tcp_* | head
> tcp_abort
> tcp_ack
> tcp_ack_update_rtt.isra.0
> tcp_add_backlog
> tcp_add_reno_sack
> tcp_adjust_pcount
> tcp_alloc_md5sig_pool
> tcp_any_retrans_done.part.0
> tcp_assign_congestion_control
> tcp_bpf_clone
> [acme@five perf]$ perf probe -h -F
>
> Usage: perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]
> or: perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]
> or: perf probe [<options>] --del '[GROUP:]EVENT' ...
> or: perf probe --list [GROUP:]EVENT ...
> or: perf probe [<options>] --line 'LINEDESC'
> or: perf probe [<options>] --vars 'PROBEPOINT'
> or: perf probe [<options>] --funcs
>
> -F, --funcs <[FILTER]>
> Show potential probe-able functions.
>
> [acme@five perf]$
>
> So I think we should align with this.
>
> - Arnaldo
>
Agreed. Will do that in next revision.
> > Signed-off-by: Changbin Du <changbin.du@gmail.com>
> > ---
> > tools/perf/builtin-ftrace.c | 43 +++++++++++++++++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> >
> > diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
> > index 1d30c2d5f88b..8133d910d5d8 100644
> > --- a/tools/perf/builtin-ftrace.c
> > +++ b/tools/perf/builtin-ftrace.c
> > @@ -33,6 +33,7 @@ struct perf_ftrace {
> > struct evlist *evlist;
> > struct target target;
> > const char *tracer;
> > + bool list_avail_functions;
> > struct list_head filters;
> > struct list_head notrace;
> > struct list_head graph_funcs;
> > @@ -142,6 +143,43 @@ static int write_tracing_option_file(const char *name, const char *val)
> > return ret;
> > }
> >
> > +static int read_tracing_file_to_stdout(const char *name)
> > +{
> > + char buf[4096];
> > + char *file;
> > + int fd;
> > + int ret = -1;
> > +
> > + file = get_tracing_file(name);
> > + if (!file) {
> > + pr_debug("cannot get tracing file: %s\n", name);
> > + return -1;
> > + }
> > +
> > + fd = open(file, O_RDONLY);
> > + if (fd < 0) {
> > + pr_debug("cannot open tracing file: %s: %s\n",
> > + name, str_error_r(errno, buf, sizeof(buf)));
> > + goto out;
> > + }
> > +
> > + /* read contents to stdout */
> > + while (true) {
> > + int n = read(fd, buf, sizeof(buf));
> > + if (n <= 0)
> > + goto out_close;
> > + if (fwrite(buf, n, 1, stdout) != 1)
> > + goto out_close;
> > + }
> > + ret = 0;
> > +
> > +out_close:
> > + close(fd);
> > +out:
> > + put_tracing_file(file);
> > + return ret;
> > +}
> > +
> > static int reset_tracing_cpu(void);
> > static void reset_tracing_filters(void);
> >
> > @@ -332,6 +370,9 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
> > signal(SIGCHLD, sig_handler);
> > signal(SIGPIPE, sig_handler);
> >
> > + if (ftrace->list_avail_functions)
> > + return read_tracing_file_to_stdout("available_filter_functions");
> > +
> > if (reset_tracing_files(ftrace) < 0) {
> > pr_err("failed to reset ftrace\n");
> > goto out;
> > @@ -483,6 +524,8 @@ int cmd_ftrace(int argc, const char **argv)
> > NULL
> > };
> > const struct option ftrace_options[] = {
> > + OPT_BOOLEAN('L', "list-functions", &ftrace.list_avail_functions,
> > + "List available functions to filter"),
> > OPT_STRING('p', "pid", &ftrace.target.pid, "pid",
> > "trace on existing process id"),
> > OPT_INCR('v', "verbose", &verbose,
> > --
> > 2.25.1
> >
>
> --
>
> - Arnaldo
--
Cheers,
Changbin Du
next prev parent reply other threads:[~2020-06-06 14:43 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 15:06 [PATCH 00/19] perf: ftrace enhancement Changbin Du
2020-05-10 15:06 ` [PATCH 01/19] perf ftrace: trace system wide if no target is given Changbin Du
2020-05-20 20:47 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 02/19] perf ftrace: detect workload failure Changbin Du
2020-05-20 20:51 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 03/19] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-05-20 20:56 ` Arnaldo Carvalho de Melo
2020-05-31 5:52 ` Namhyung Kim
2020-06-06 14:28 ` Changbin Du
2020-05-10 15:06 ` [PATCH 04/19] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-05-20 20:58 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 05/19] perf ftrace: add option '-l/--list-functions' to list available functions Changbin Du
2020-05-20 20:59 ` Arnaldo Carvalho de Melo
2020-06-06 14:42 ` Changbin Du [this message]
2020-05-10 15:06 ` [PATCH 06/19] perf ftrace: add support for trace option sleep-time Changbin Du
2020-05-20 21:01 ` Arnaldo Carvalho de Melo
2020-05-31 5:56 ` Namhyung Kim
2020-06-06 14:19 ` Changbin Du
2020-05-10 15:06 ` [PATCH 07/19] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-05-20 21:01 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 08/19] perf ftrace: add option -l/--long-info to show more info Changbin Du
2020-05-20 21:02 ` Arnaldo Carvalho de Melo
2020-05-31 6:00 ` Namhyung Kim
2020-06-06 14:14 ` Changbin Du
2020-05-10 15:06 ` [PATCH 09/19] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-05-20 21:03 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 10/19] perf ftrace: add support for trace option funcgraph-tail Changbin Du
2020-05-20 21:03 ` Arnaldo Carvalho de Melo
2020-05-20 21:05 ` Arnaldo Carvalho de Melo
2020-05-31 6:07 ` Namhyung Kim
2020-06-25 11:21 ` Changbin Du
2020-05-10 15:06 ` [PATCH 11/19] perf ftrace: add option '-u/--userstacktrace' to show userspace stacktrace Changbin Du
2020-05-20 21:07 ` Arnaldo Carvalho de Melo
2020-06-14 11:15 ` Changbin Du
2020-05-10 15:06 ` [PATCH 12/19] perf ftrace: add support for tracing children processes Changbin Du
2020-05-20 21:07 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 13/19] perf ftrace: add option '-b/--buffer-size' to set per-cpu buffer size Changbin Du
2020-05-20 21:08 ` Arnaldo Carvalho de Melo
2020-06-06 14:43 ` Changbin Du
2020-05-10 15:06 ` [PATCH 14/19] perf ftrace: add option -P/--no-pager to disable pager Changbin Du
2020-05-20 21:09 ` Arnaldo Carvalho de Melo
2020-06-06 14:40 ` Changbin Du
2020-05-10 15:06 ` [PATCH 15/19] perf ftrace: show trace column header Changbin Du
2020-05-20 21:11 ` Arnaldo Carvalho de Melo
2020-06-06 14:37 ` Changbin Du
2020-05-10 15:06 ` [PATCH 16/19] perf ftrace: add option -t/--tid to filter by thread id Changbin Du
2020-05-20 21:12 ` Arnaldo Carvalho de Melo
2020-06-06 14:32 ` Changbin Du
2020-05-10 15:06 ` [PATCH 17/19] perf ftrace: add option -d/--delay to delay tracing Changbin Du
2020-05-20 21:13 ` Arnaldo Carvalho de Melo
2020-06-06 14:30 ` Changbin Du
2020-05-10 15:06 ` [PATCH 18/19] perf ftrace: add option --latency-format to display more info about delay Changbin Du
2020-05-20 21:14 ` Arnaldo Carvalho de Melo
2020-05-10 15:06 ` [PATCH 19/19] perf ftrace: add change log Changbin Du
2020-05-10 15:23 ` [PATCH 00/19] perf: ftrace enhancement Steven Rostedt
2020-05-10 16:18 ` Arnaldo Melo
2020-05-20 20:31 ` Arnaldo Carvalho de Melo
2020-05-26 0:17 ` Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200606144253.sdo2f5o54d5zdic7@mail.google.com \
--to=changbin.du@gmail.com \
--cc=arnaldo.melo@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).