linux-next: Signed-off-by missing for commit in the gfs2 tree

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

Hi all,

Commit

  de80f184535d ("gfs2: Don't ignore inode write errors during inode_go_sync")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

Hi all,

Commits

  1c47c16d9bde ("gfs2: Use wait_event_freezable_timeout() for freezable kthread")
  6650ff05e56f ("gfs2: Add missing set_freezable() for freezable kthread")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

Commit

  584e70f20bd0 ("gfs2: prevent gfs2_logd from spinning")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

Commit

  fa6629ae1481 ("gfs2: prevent gfs2_logd from spinning")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

Hi all,

Commit

  de33661d31f7 ("fs: Fix bug in gfs2_freeze_func that can cause deadlock")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

Hi all,

Commit

  0e1c26572546 ("gfs2: Improve gfs2_upgrade_iopen_glock comment")

is missing a Signed-off-by from its author and committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 161 bytes --]

Hi all,

Commit

  f5370b4a014e ("gfs2: Fix spelling error in comment")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hi all,

Commit

  c70bac321715 ("gfs2: Remove redundant NULL check before kfree")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 186 bytes --]

Hi all,

Commit

  9e349f23802b ("gfs2: Make sure FITRIM minlen is rounded up to fs block size")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

Hi all,

Commit

  700e82af02f2 ("gfs2: assign rgrp glock before compute_bitstructs")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

Hi all,

Commit

  c125c1290099 ("gfs2: release iopen glock early in evict")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

Hi all,

Commit

  d2097641ed78 ("gfs2: Fix invalid block size message")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

Hi all,

Commits

  c2af4bc4f3a0 ("gfs2: make recovery workqueue operate on a gfs2 mount point, not journal")
  c8e56050f64f ("gfs2: make gfs2_log_write_page static")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 163 bytes --]

Hi all,

Commit

  955584707816 ("gfs2: Fix comments to glock_hash_walk")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

Hi all,

Commit

  aa4796e18397 ("gfs2: Fix bad comment for trans_drain")

is missing a Signed-off-by from its committer.

One of the traps of rebasing ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 173 bytes --]

Hi all,

Commit

  b15a7defc994 ("gfs2: convert to use DEFINE_SEQ_ATTRIBUTE macro")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi all,

Commit

  d4f40a25ec27 ("docs: filesystems: convert gfs2-glocks.txt to ReST")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Hi all,

Commit

  467c82b82836 ("gfs2: clean_journal improperly set sd_log_flush_head")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

Hi all,

Commit

  ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi all,

On Wed, 12 Dec 2018 07:24:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Commit
> 
>   ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
> 
> is missing a Signed-off-by from its committer.

Now, after the rebase:

Commits

  187e4dad3f55 ("gfs2: Remove vestigial bd_ops")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Andreas Grünbacher]

Hi,

Am Di., 11. Dez. 2018 um 21:40 Uhr schrieb Stephen Rothwell
<sfr@canb.auug.org.au>:
> Hi all,
>
> On Wed, 12 Dec 2018 07:24:02 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Commit
> >
> >   ec702fa79702 ("gfs2: Dump nrpages for inodes and their glocks")
> >
> > is missing a Signed-off-by from its committer.
>
> Now, after the rebase:
>
> Commits
>
>   187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
>
> is missing a Signed-off-by from its committer.

Yep, I've not asked for a way to get the server to reject or warn
about such pushes without a reason.

Thanks,
Andreas

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1679 bytes --]

Hi Andreas,

On Tue, 11 Dec 2018 21:47:43 +0100 Andreas Grünbacher <andreas.gruenbacher@gmail.com> wrote:
>
> Yep, I've not asked for a way to get the server to reject or warn
> about such pushes without a reason.

Sure, but also here's the script I run (which could be run before
pushing) ...

----------------------------------------------------------------------
#!/bin/bash

if [ "$#" -lt 1 ]; then
	printf "Usage: %s <commit range>\n", "$0" 1>&2
	exit 1
fi

commits=$(git rev-list --no-merges "$@")
if [ -z "$commits" ]; then
	printf "No commits\n"
	exit 0
fi

author_missing=
committer_missing=

print_commits()
{
	local t="$1"

	shift

	s=
	is='is'
	its='its'
	[ "$#" -gt 1 ] && {
		s='s'
		is='are'
		its='their'
	}
	printf "Commit%s\n\n" "$s"
	git log --no-walk --pretty='format:  %h ("%s")' "$@"
	printf "\n%s missing a Signed-off-by from %s %s%s.\n" "$is" "$its" "$t" "$s"
	printf "\n"
}

for c in $commits; do
	ae=$(git log -1 --format='<%ae>%n<%aE>%n %an %n %aN ' "$c" | sort -u)
	ce=$(git log -1 --format='<%ce>%n<%cE>%n %cn %n %cN ' "$c" | sort -u)
	msg=$(git log -1 --format='%b' "$c")
	sob=$(echo "$msg" | sed -En 's/^\s*Signed-off-by:?\s*/ /ip')

	am=false
	cm=false
	grep -i -F -q "$ae" <<<"$sob" ||
		am=true
	grep -i -F -q "$ce" <<<"$sob" ||
		cm=true
	"$am" && author_missing+=" $c"
	"$cm" && committer_missing+=" $c"
done

if [ "$author_missing" ]; then
	print_commits "author" $author_missing
fi
if [ "$committer_missing" ]; then
	print_commits "committer" $committer_missing
fi
----------------------------------------------------------------------

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Konstantin Ryabitsev]

On Tue, Dec 11, 2018 at 09:47:43PM +0100, Andreas Grünbacher wrote:
> > Now, after the rebase:
> >
> > Commits
> >
> >   187e4dad3f55 ("gfs2: Remove vestigial bd_ops")
> >
> > is missing a Signed-off-by from its committer.
> 
> Yep, I've not asked for a way to get the server to reject or warn
> about such pushes without a reason.

We don't run checks on push that involve iterating through commits,
because most of the pushes we receive are merges and rejecting on a
commit somewhere deep in an octopus merge would just result in angry
maintainers.

Best,
-K

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

Hi all,

Commits

  25b76c531970 ("gfs2: add a helper function to get_log_header that can be used elsewhere")
  14e81158a6d6 ("gfs2: add more timing info to journal recovery process")

are missing a Signed-off-by from their committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

Hi all,

Commit

  b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the kernel threads")

is missing a Signed-off-by from its committer.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Bob Peterson]

----- Original Message -----
> Hi all,
> 
> Commit
> 
>   b7f5a2cd27b7 ("GFS2: Flush the GFS2 delete workqueue before stopping the
>   kernel threads")
> 
> is missing a Signed-off-by from its committer.
> 
> --
> Cheers,
> Stephen Rothwell

Fixed now. Sorry about that.

Regards,

Bob Peterson

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

Hi all,

Commit

  b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")

is missing a Signed-off-by from its committer.  It was rebased.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Andreas Grünbacher]

Hi Stephen,

2018-07-25 0:01 GMT+02:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> Hi all,
>
> Commit
>
>   b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
>
> is missing a Signed-off-by from its committer.  It was rebased.

thanks, I've fixed it now but this is getting rather annoying -- and
it must happen to others as well. Do you happen to have git hooks that
prevent this from happening?

Thanks,
Andreas

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 800 bytes --]

Hi Andreas,

On Wed, 25 Jul 2018 00:23:22 +0200 Andreas Grünbacher <andreas.gruenbacher@gmail.com> wrote:
>
> 2018-07-25 0:01 GMT+02:00 Stephen Rothwell <sfr@canb.auug.org.au>:
> > Hi all,
> >
> > Commit
> >
> >   b6fbc2f6a686 ("GFS2: Fix recovery issues for spectators")
> >
> > is missing a Signed-off-by from its committer.  It was rebased.  
> 
> thanks, I've fixed it now but this is getting rather annoying -- and
> it must happen to others as well. Do you happen to have git hooks that
> prevent this from happening?

No, but I don't rebase stuff (that matters) ;-)  I think that someone
did write a hook, but can't remember who, sorry.

What I have is a script that I run over each new set of commits I fetch
that checks these things.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Signed-off-by missing for commit in the gfs2 tree

[Stephen Rothwell]

Hi all,

Commit

  7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")

is missing a Signed-off-by from its author.

-- 
Cheers,
Stephen Rothwell

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Steven Whitehouse]

On 16/01/18 20:51, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
>    7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
>
> is missing a Signed-off-by from its author.
>
Bob, can you add that?

Steve.

Re: linux-next: Signed-off-by missing for commit in the gfs2 tree

[Bob Peterson]

----- Original Message -----
| 
| 
| On 16/01/18 20:51, Stephen Rothwell wrote:
| > Hi all,
| >
| > Commit
| >
| >    7d2040199855 ("gfs2: Add gfs2_blk2rgrpd comment and fix incorrect use")
| >
| > is missing a Signed-off-by from its author.
| >
| Bob, can you add that?
| 
| Steve.

This should be fixed now.

Bob