* [PATCH] nfsd: Fix old-style function definition
@ 2020-05-11 12:07 Ma Feng
2020-05-11 13:58 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Ma Feng @ 2020-05-11 12:07 UTC (permalink / raw)
To: bfields, chuck.lever; +Cc: linux-nfs, linux-kernel
Fix warning:
fs/nfsd/nfssvc.c:604:6: warning: old-style function definition [-Wold-style-definition]
bool i_am_nfsd()
^~~~~~~~~
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
---
fs/nfsd/nfssvc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 4f588c0..b603dfc 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -601,7 +601,7 @@ static const struct svc_serv_ops nfsd_thread_sv_ops = {
.svo_module = THIS_MODULE,
};
-bool i_am_nfsd()
+bool i_am_nfsd(void)
{
return kthread_func(current) == nfsd;
}
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfsd: Fix old-style function definition
2020-05-11 12:07 [PATCH] nfsd: Fix old-style function definition Ma Feng
@ 2020-05-11 13:58 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2020-05-11 13:58 UTC (permalink / raw)
To: Ma Feng; +Cc: chuck.lever, linux-nfs, linux-kernel
On Mon, May 11, 2020 at 08:07:08PM +0800, Ma Feng wrote:
> Fix warning:
>
> fs/nfsd/nfssvc.c:604:6: warning: old-style function definition [-Wold-style-definition]
> bool i_am_nfsd()
Applying for 5.8, thanks.--b.
> ^~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Ma Feng <mafeng.ma@huawei.com>
> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 4f588c0..b603dfc 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -601,7 +601,7 @@ static const struct svc_serv_ops nfsd_thread_sv_ops = {
> .svo_module = THIS_MODULE,
> };
>
> -bool i_am_nfsd()
> +bool i_am_nfsd(void)
> {
> return kthread_func(current) == nfsd;
> }
> --
> 2.6.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-11 13:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-11 12:07 [PATCH] nfsd: Fix old-style function definition Ma Feng
2020-05-11 13:58 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).