* [PATCH] coresight: platform: use dev_warn instead of dev_warn_once
@ 2020-05-08 10:28 Kathiravan T
2020-05-11 16:58 ` Mathieu Poirier
0 siblings, 1 reply; 4+ messages in thread
From: Kathiravan T @ 2020-05-08 10:28 UTC (permalink / raw)
To: mathieu.poirier, suzuki.poulose, mike.leach, alexander.shishkin,
linux-arm-kernel, linux-kernel
Cc: Kathiravan T
When more than one coresight components uses the obsolete DT bindings,
warning is displayed for only one component and not for the others.
Lets warn it for all components by replacing dev_warn_once with dev_warn.
Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
---
drivers/hwtracing/coresight/coresight-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
index 43418a2..b7d9a02 100644
--- a/drivers/hwtracing/coresight/coresight-platform.c
+++ b/drivers/hwtracing/coresight/coresight-platform.c
@@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev,
if (!parent) {
legacy_binding = true;
parent = node;
- dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n");
+ dev_warn(dev, "Uses obsolete Coresight DT bindings\n");
}
conn = pdata->conns;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn_once
2020-05-08 10:28 [PATCH] coresight: platform: use dev_warn instead of dev_warn_once Kathiravan T
@ 2020-05-11 16:58 ` Mathieu Poirier
2020-05-11 17:31 ` Suzuki K Poulose
0 siblings, 1 reply; 4+ messages in thread
From: Mathieu Poirier @ 2020-05-11 16:58 UTC (permalink / raw)
To: Kathiravan T
Cc: suzuki.poulose, mike.leach, alexander.shishkin, linux-arm-kernel,
linux-kernel
Hi Kathiravan,
On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote:
> When more than one coresight components uses the obsolete DT bindings,
> warning is displayed for only one component and not for the others.
> Lets warn it for all components by replacing dev_warn_once with dev_warn.
>
> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
> ---
> drivers/hwtracing/coresight/coresight-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 43418a2..b7d9a02 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev,
> if (!parent) {
> legacy_binding = true;
> parent = node;
> - dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n");
> + dev_warn(dev, "Uses obsolete Coresight DT bindings\n");
We made a concious decision to use dev_warn_once() rather than dev_warn().
There can be a lot of coresight devices on a platform and warning for every
device doesn't do anything more than adding noise.
If one device is using obsolete bindings the others very likely to do so as
well. While fixing one device, checking the remaining devices should be
intuitive.
Thanks,
Mathieu
> }
>
> conn = pdata->conns;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn_once
2020-05-11 16:58 ` Mathieu Poirier
@ 2020-05-11 17:31 ` Suzuki K Poulose
2020-05-13 12:36 ` Kathiravan Thirumoorthy
0 siblings, 1 reply; 4+ messages in thread
From: Suzuki K Poulose @ 2020-05-11 17:31 UTC (permalink / raw)
To: mathieu.poirier, kathirav
Cc: mike.leach, alexander.shishkin, linux-arm-kernel, linux-kernel
On 05/11/2020 05:58 PM, Mathieu Poirier wrote:
> Hi Kathiravan,
>
> On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote:
>> When more than one coresight components uses the obsolete DT bindings,
>> warning is displayed for only one component and not for the others.
>> Lets warn it for all components by replacing dev_warn_once with dev_warn.
>>
>> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
>> ---
>> drivers/hwtracing/coresight/coresight-platform.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
>> index 43418a2..b7d9a02 100644
>> --- a/drivers/hwtracing/coresight/coresight-platform.c
>> +++ b/drivers/hwtracing/coresight/coresight-platform.c
>> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev,
>> if (!parent) {
>> legacy_binding = true;
>> parent = node;
>> - dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n");
>> + dev_warn(dev, "Uses obsolete Coresight DT bindings\n");
>
> We made a concious decision to use dev_warn_once() rather than dev_warn().
> There can be a lot of coresight devices on a platform and warning for every
> device doesn't do anything more than adding noise.
>
> If one device is using obsolete bindings the others very likely to do so as
> well. While fixing one device, checking the remaining devices should be
> intuitive.
Exactly ! Or someone could repeat the process until all are fixed ;-)
Cheers
Suzuki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn_once
2020-05-11 17:31 ` Suzuki K Poulose
@ 2020-05-13 12:36 ` Kathiravan Thirumoorthy
0 siblings, 0 replies; 4+ messages in thread
From: Kathiravan Thirumoorthy @ 2020-05-13 12:36 UTC (permalink / raw)
To: Suzuki K Poulose, mathieu.poirier
Cc: mike.leach, alexander.shishkin, linux-arm-kernel, linux-kernel
On 5/11/2020 11:01 PM, Suzuki K Poulose wrote:
> On 05/11/2020 05:58 PM, Mathieu Poirier wrote:
>> Hi Kathiravan,
>>
>> On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote:
>>> When more than one coresight components uses the obsolete DT bindings,
>>> warning is displayed for only one component and not for the others.
>>> Lets warn it for all components by replacing dev_warn_once with
>>> dev_warn.
>>>
>>> Signed-off-by: Kathiravan T <kathirav@codeaurora.org>
>>> ---
>>> drivers/hwtracing/coresight/coresight-platform.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/hwtracing/coresight/coresight-platform.c
>>> b/drivers/hwtracing/coresight/coresight-platform.c
>>> index 43418a2..b7d9a02 100644
>>> --- a/drivers/hwtracing/coresight/coresight-platform.c
>>> +++ b/drivers/hwtracing/coresight/coresight-platform.c
>>> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct
>>> device *dev,
>>> if (!parent) {
>>> legacy_binding = true;
>>> parent = node;
>>> - dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n");
>>> + dev_warn(dev, "Uses obsolete Coresight DT bindings\n");
>>
>> We made a concious decision to use dev_warn_once() rather than
>> dev_warn().
>> There can be a lot of coresight devices on a platform and warning for
>> every
>> device doesn't do anything more than adding noise.
>>
>> If one device is using obsolete bindings the others very likely to do
>> so as
>> well. While fixing one device, checking the remaining devices should be
>> intuitive.
>
> Exactly ! Or someone could repeat the process until all are fixed ;-)
>
> Cheers
> Suzuki
Thanks Mathieu and Suzuki for the inputs. I shall drop this patch.
Thanks,
Kathiravan T.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-13 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-08 10:28 [PATCH] coresight: platform: use dev_warn instead of dev_warn_once Kathiravan T
2020-05-11 16:58 ` Mathieu Poirier
2020-05-11 17:31 ` Suzuki K Poulose
2020-05-13 12:36 ` Kathiravan Thirumoorthy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).