From: Phil Auld <pauld@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
vincent.guittot@linaro.org, juri.lelli@redhat.com,
zohooouoto@zoho.com.cn, dietmar.eggemann@arm.com
Subject: Re: [PATCH v3] sched/fair: Fix enqueue_task_fair warning some more
Date: Tue, 12 May 2020 10:24:47 -0400 [thread overview]
Message-ID: <20200512142447.GA4256@lorien.usersys.redhat.com> (raw)
In-Reply-To: <20200512141048.GL2978@hirez.programming.kicks-ass.net>
On Tue, May 12, 2020 at 04:10:48PM +0200 Peter Zijlstra wrote:
> On Tue, May 12, 2020 at 09:52:22AM -0400, Phil Auld wrote:
> > sched/fair: Fix enqueue_task_fair warning some more
> >
> > The recent patch, fe61468b2cb (sched/fair: Fix enqueue_task_fair warning)
> > did not fully resolve the issues with the rq->tmp_alone_branch !=
> > &rq->leaf_cfs_rq_list warning in enqueue_task_fair. There is a case where
> > the first for_each_sched_entity loop exits due to on_rq, having incompletely
> > updated the list. In this case the second for_each_sched_entity loop can
> > further modify se. The later code to fix up the list management fails to do
> > what is needed because se does not point to the sched_entity which broke out
> > of the first loop. The list is not fixed up because the throttled parent was
> > already added back to the list by a task enqueue in a parallel child hierarchy.
> >
> > Address this by calling list_add_leaf_cfs_rq if there are throttled parents
> > while doing the second for_each_sched_entity loop.
> >
> > v3: clean up commit message and add fixes and review tags.
>
> Excellent, ignore what I just sent, I now have this one.
>
Thank you!
Cheers,
Phil
--
next prev parent reply other threads:[~2020-05-12 14:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 14:18 [PATCH] sched/fair: Fix enqueue_task_fair warning some more Phil Auld
2020-05-06 16:36 ` Vincent Guittot
2020-05-06 18:05 ` Phil Auld
2020-05-07 15:06 ` Vincent Guittot
2020-05-07 15:17 ` Phil Auld
2020-05-07 18:04 ` Phil Auld
2020-05-07 18:21 ` Vincent Guittot
2020-05-07 20:36 ` [PATCH v2] " Phil Auld
2020-05-08 15:15 ` Tao Zhou
2020-05-08 15:27 ` Vincent Guittot
2020-05-08 17:02 ` Tao Zhou
2020-05-11 8:36 ` Vincent Guittot
[not found] ` <BL0PR14MB37792D0FD629FFF1C9FEDE369AA10@BL0PR14MB3779.namprd14.prod.outlook.com>
2020-05-11 19:22 ` Vincent Guittot
2020-05-11 8:40 ` Dietmar Eggemann
2020-05-11 9:36 ` Vincent Guittot
2020-05-11 10:39 ` Dietmar Eggemann
2020-05-11 12:12 ` Vincent Guittot
2020-05-11 17:02 ` Dietmar Eggemann
2020-05-11 17:14 ` Vincent Guittot
[not found] ` <BL0PR14MB3779ED5E2E5AD157B58D002C9AA10@BL0PR14MB3779.namprd14.prod.outlook.com>
2020-05-11 17:03 ` Dietmar Eggemann
2020-05-11 19:25 ` Vincent Guittot
2020-05-11 20:44 ` Phil Auld
2020-05-12 9:00 ` Dietmar Eggemann
2020-05-12 13:37 ` Phil Auld
2020-05-12 14:06 ` Peter Zijlstra
2020-05-12 13:52 ` [PATCH v3] " Phil Auld
2020-05-12 14:10 ` Peter Zijlstra
2020-05-12 14:24 ` Phil Auld [this message]
2020-05-19 18:44 ` [tip: sched/urgent] sched/fair: Fix enqueue_task_fair() " tip-bot2 for Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512142447.GA4256@lorien.usersys.redhat.com \
--to=pauld@redhat.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=zohooouoto@zoho.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).