* [PATCH 0/1] power: convert to use new I2C API
@ 2020-03-26 21:09 Wolfram Sang
2020-03-26 21:09 ` [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device() Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:09 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, linux-kernel, linux-pm
We are deprecating calls which return NULL in favor of new variants which
return an ERR_PTR. Only build tested.
Wolfram Sang (1):
power: supply: bq24190_charger: convert to use i2c_new_client_device()
drivers/power/supply/bq24190_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device()
2020-03-26 21:09 [PATCH 0/1] power: convert to use new I2C API Wolfram Sang
@ 2020-03-26 21:09 ` Wolfram Sang
2020-05-12 16:27 ` Wolfram Sang
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2020-03-26 21:09 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Sebastian Reichel, linux-pm, linux-kernel
Move away from the deprecated API in this comment.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/power/supply/bq24190_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
index 453d6332d43a..4540e913057f 100644
--- a/drivers/power/supply/bq24190_charger.c
+++ b/drivers/power/supply/bq24190_charger.c
@@ -673,7 +673,7 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi)
* { .type = "bq24190", .addr = 0x6b, .properties = pe, .irq = irq };
* struct i2c_adapter ad = { ... };
* i2c_add_adapter(&ad);
- * i2c_new_device(&ad, &bi);
+ * i2c_new_client_device(&ad, &bi);
*/
if (device_property_read_bool(bdi->dev, "disable-reset"))
return 0;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device()
2020-03-26 21:09 ` [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device() Wolfram Sang
@ 2020-05-12 16:27 ` Wolfram Sang
2020-05-12 17:10 ` Sebastian Reichel
0 siblings, 1 reply; 4+ messages in thread
From: Wolfram Sang @ 2020-05-12 16:27 UTC (permalink / raw)
To: linux-i2c; +Cc: Sebastian Reichel, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Thu, Mar 26, 2020 at 10:09:54PM +0100, Wolfram Sang wrote:
> Move away from the deprecated API in this comment.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Can we have this now so I can remove the old API in the next merge
window?
> ---
> drivers/power/supply/bq24190_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> index 453d6332d43a..4540e913057f 100644
> --- a/drivers/power/supply/bq24190_charger.c
> +++ b/drivers/power/supply/bq24190_charger.c
> @@ -673,7 +673,7 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi)
> * { .type = "bq24190", .addr = 0x6b, .properties = pe, .irq = irq };
> * struct i2c_adapter ad = { ... };
> * i2c_add_adapter(&ad);
> - * i2c_new_device(&ad, &bi);
> + * i2c_new_client_device(&ad, &bi);
> */
> if (device_property_read_bool(bdi->dev, "disable-reset"))
> return 0;
> --
> 2.20.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device()
2020-05-12 16:27 ` Wolfram Sang
@ 2020-05-12 17:10 ` Sebastian Reichel
0 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2020-05-12 17:10 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1271 bytes --]
Hi Wolfram,
On Tue, May 12, 2020 at 06:27:23PM +0200, Wolfram Sang wrote:
> On Thu, Mar 26, 2020 at 10:09:54PM +0100, Wolfram Sang wrote:
> > Move away from the deprecated API in this comment.
> >
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Can we have this now so I can remove the old API in the next merge
> window?
Thanks for the ping. The patch is now queued into power-supply's
for-next branch.
-- Sebastian
> > ---
> > drivers/power/supply/bq24190_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c
> > index 453d6332d43a..4540e913057f 100644
> > --- a/drivers/power/supply/bq24190_charger.c
> > +++ b/drivers/power/supply/bq24190_charger.c
> > @@ -673,7 +673,7 @@ static int bq24190_register_reset(struct bq24190_dev_info *bdi)
> > * { .type = "bq24190", .addr = 0x6b, .properties = pe, .irq = irq };
> > * struct i2c_adapter ad = { ... };
> > * i2c_add_adapter(&ad);
> > - * i2c_new_device(&ad, &bi);
> > + * i2c_new_client_device(&ad, &bi);
> > */
> > if (device_property_read_bool(bdi->dev, "disable-reset"))
> > return 0;
> > --
> > 2.20.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-12 17:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-26 21:09 [PATCH 0/1] power: convert to use new I2C API Wolfram Sang
2020-03-26 21:09 ` [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device() Wolfram Sang
2020-05-12 16:27 ` Wolfram Sang
2020-05-12 17:10 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).