* [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment
@ 2020-05-10 10:13 John Oldman
2020-05-13 11:58 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: John Oldman @ 2020-05-10 10:13 UTC (permalink / raw)
To: nsaenzjulienne
Cc: gregkh, bcm-kernel-feedback-list, linux-rpi-kernel,
linux-arm-kernel, devel, linux-kernel, John Oldman
Coding style issue
This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
---
v1: Initial attempt.
v2: Resubmitted with shorter comment line, as suggested by Greg KH.
v3: Resubmitted with descriptiuon text moved into the comment area.
.../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++----------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
index 1640906e3929..993535bbc479 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
@@ -15,10 +15,10 @@ static int g_once_init;
static struct mutex g_connected_mutex;
/****************************************************************************
-*
-* Function to initialize our lock.
-*
-***************************************************************************/
+ *
+ * Function to initialize our lock.
+ *
+ ***************************************************************************/
static void connected_init(void)
{
@@ -29,13 +29,13 @@ static void connected_init(void)
}
/****************************************************************************
-*
-* This function is used to defer initialization until the vchiq stack is
-* initialized. If the stack is already initialized, then the callback will
-* be made immediately, otherwise it will be deferred until
-* vchiq_call_connected_callbacks is called.
-*
-***************************************************************************/
+ *
+ * This function is used to defer initialization until the vchiq stack is
+ * initialized. If the stack is already initialized, then the callback will
+ * be made immediately, otherwise it will be deferred until
+ * vchiq_call_connected_callbacks is called.
+ *
+ ***************************************************************************/
void vchiq_add_connected_callback(VCHIQ_CONNECTED_CALLBACK_T callback)
{
@@ -64,11 +64,11 @@ void vchiq_add_connected_callback(VCHIQ_CONNECTED_CALLBACK_T callback)
}
/****************************************************************************
-*
-* This function is called by the vchiq stack once it has been connected to
-* the videocore and clients can start to use the stack.
-*
-***************************************************************************/
+ *
+ * This function is called by the vchiq stack once it has been connected to
+ * the videocore and clients can start to use the stack.
+ *
+ ***************************************************************************/
void vchiq_call_connected_callbacks(void)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment
2020-05-10 10:13 [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment John Oldman
@ 2020-05-13 11:58 ` Greg KH
2020-05-13 12:06 ` John Oldman
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2020-05-13 11:58 UTC (permalink / raw)
To: John Oldman
Cc: nsaenzjulienne, devel, linux-kernel, bcm-kernel-feedback-list,
linux-rpi-kernel, linux-arm-kernel
On Sun, May 10, 2020 at 11:13:08AM +0100, John Oldman wrote:
> Coding style issue
> This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
>
> Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> ---
> v1: Initial attempt.
> v2: Resubmitted with shorter comment line, as suggested by Greg KH.
> v3: Resubmitted with descriptiuon text moved into the comment area.
>
> .../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> index 1640906e3929..993535bbc479 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> @@ -15,10 +15,10 @@ static int g_once_init;
> static struct mutex g_connected_mutex;
>
> /****************************************************************************
> -*
> -* Function to initialize our lock.
> -*
> -***************************************************************************/
> + *
> + * Function to initialize our lock.
> + *
> + ***************************************************************************/
>
> static void connected_init(void)
Shouldn't that really be written as:
/* Function to initialize our lock */
static void connect_init(void);
No need for the /****** mess, and no need for the blank line.
Simple and clean is best.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment
2020-05-13 11:58 ` Greg KH
@ 2020-05-13 12:06 ` John Oldman
0 siblings, 0 replies; 3+ messages in thread
From: John Oldman @ 2020-05-13 12:06 UTC (permalink / raw)
To: Greg KH
Cc: John Oldman, nsaenzjulienne, devel, linux-kernel,
bcm-kernel-feedback-list, linux-rpi-kernel, linux-arm-kernel
yea I agree, will re-submit...
Cheers
john
On Wed, 13 May 2020 at 12:58, Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Sun, May 10, 2020 at 11:13:08AM +0100, John Oldman wrote:
> > Coding style issue
> > This patch clears the checkpatch.pl "Block comments should align the * on each line" warning.
> >
> > Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
> > ---
> > v1: Initial attempt.
> > v2: Resubmitted with shorter comment line, as suggested by Greg KH.
> > v3: Resubmitted with descriptiuon text moved into the comment area.
> >
> > .../interface/vchiq_arm/vchiq_connected.c | 32 +++++++++----------
> > 1 file changed, 16 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> > index 1640906e3929..993535bbc479 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c
> > @@ -15,10 +15,10 @@ static int g_once_init;
> > static struct mutex g_connected_mutex;
> >
> > /****************************************************************************
> > -*
> > -* Function to initialize our lock.
> > -*
> > -***************************************************************************/
> > + *
> > + * Function to initialize our lock.
> > + *
> > + ***************************************************************************/
> >
> > static void connected_init(void)
>
> Shouldn't that really be written as:
>
> /* Function to initialize our lock */
> static void connect_init(void);
>
>
> No need for the /****** mess, and no need for the blank line.
>
> Simple and clean is best.
>
> thanks,
>
> greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-13 12:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-10 10:13 [PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment John Oldman
2020-05-13 11:58 ` Greg KH
2020-05-13 12:06 ` John Oldman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).