From: Andrew Morton <akpm@linux-foundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sh: include linux/time_types.h for sockios
Date: Tue, 19 May 2020 18:10:34 -0700 [thread overview]
Message-ID: <20200519181034.58c67eb5bea24aae24d33421@linux-foundation.org> (raw)
In-Reply-To: <20200519131327.1836482-1-arnd@arndb.de>
On Tue, 19 May 2020 15:13:13 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> Using the socket ioctls on arch/sh (and only there) causes build
> time problems when __kernel_old_timeval/__kernel_old_timespec are
> not already visible to the compiler.
>
> Add an explict include line for the header that defines these
> structures.
I can grab this.
> Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Fixes: 8c709f9a0693 ("y2038: sh: remove timeval/timespec usage from headers")
> Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
cc:stable?
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/sh/include/uapi/asm/sockios.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/sh/include/uapi/asm/sockios.h b/arch/sh/include/uapi/asm/sockios.h
> index 3da561453260..ef01ced9e169 100644
> --- a/arch/sh/include/uapi/asm/sockios.h
> +++ b/arch/sh/include/uapi/asm/sockios.h
> @@ -2,6 +2,8 @@
> #ifndef __ASM_SH_SOCKIOS_H
> #define __ASM_SH_SOCKIOS_H
>
> +#include <linux/time_types.h>
> +
> /* Socket-level I/O control calls. */
> #define FIOGETOWN _IOR('f', 123, int)
> #define FIOSETOWN _IOW('f', 124, int)
next prev parent reply other threads:[~2020-05-20 1:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 13:13 [PATCH] sh: include linux/time_types.h for sockios Arnd Bergmann
2020-05-20 1:10 ` Andrew Morton [this message]
2020-05-20 8:32 ` Arnd Bergmann
2020-05-20 11:47 ` Geert Uytterhoeven
2020-05-20 14:46 ` Arnd Bergmann
2020-05-20 14:51 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519181034.58c67eb5bea24aae24d33421@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).