From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
"David S. Miller" <davem@davemloft.net>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Linux-sh list <linux-sh@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sh: include linux/time_types.h for sockios
Date: Wed, 20 May 2020 16:51:30 +0200 [thread overview]
Message-ID: <CAMuHMdWKOZMn-pMpE6MgKo1ArL701fp4ZR65sa5yGfozf7Yu4Q@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a0+RWNUroSAtdVazxMV=o+FYpTX9Wvkbr5gODh4=zODkQ@mail.gmail.com>
Hi Arnd,
On Wed, May 20, 2020 at 4:46 PM Arnd Bergmann <arnd@arndb.de> wrote:
> On Wed, May 20, 2020 at 1:47 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, May 20, 2020 at 10:32 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > > On Wed, May 20, 2020 at 3:10 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> > > > On Tue, 19 May 2020 15:13:13 +0200 Arnd Bergmann <arnd@arndb.de> wrote:
> > > > > Using the socket ioctls on arch/sh (and only there) causes build
> > > > > time problems when __kernel_old_timeval/__kernel_old_timespec are
> > > > > not already visible to the compiler.
> > > > >
> > > > > Add an explict include line for the header that defines these
> > > > > structures.
> > > >
> > > > I can grab this.
> > >
> > > Thanks!
> > >
> > > > > Reported-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> > > > > Tested-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> > > > > Fixes: 8c709f9a0693 ("y2038: sh: remove timeval/timespec usage from headers")
> > > > > Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
> > > >
> > > > cc:stable?
> > >
> > > Yes, I missed that.
> >
> > Doesn't matter, the stable bots will pick it up anyway, based on the Fixes tag.
>
> I normally prefer to be explicit, as some bug fixes may address
> something that has been caused by an earlier commit, but should not
> be backported for some reason.
Which means that with the current "intelligent' backporting, you need a
Not-for-stable tag instead...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2020-05-20 14:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 13:13 [PATCH] sh: include linux/time_types.h for sockios Arnd Bergmann
2020-05-20 1:10 ` Andrew Morton
2020-05-20 8:32 ` Arnd Bergmann
2020-05-20 11:47 ` Geert Uytterhoeven
2020-05-20 14:46 ` Arnd Bergmann
2020-05-20 14:51 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdWKOZMn-pMpE6MgKo1ArL701fp4ZR65sa5yGfozf7Yu4Q@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).