From: Guru Das Srinagesh <firstname.lastname@example.org> To: Lee Jones <email@example.com> Cc: firstname.lastname@example.org, linux-arm-msm <email@example.com>, Rob Herring <firstname.lastname@example.org>, Subbaraman Narayanamurthy <email@example.com>, David Collins <firstname.lastname@example.org>, email@example.com Subject: Re: [PATCH v1 2/2] mfd: Introduce QTI I2C PMIC controller Date: Tue, 19 May 2020 11:57:57 -0700 [thread overview] Message-ID: <20200519185757.GA13992@codeaurora.org> (raw) In-Reply-To: <20200515104520.GK271301@dell> On Fri, May 15, 2020 at 11:45:20AM +0100, Lee Jones wrote: > On Thu, 30 Apr 2020, Guru Das Srinagesh wrote: > > > On Wed, Apr 29, 2020 at 08:50:10AM +0100, Lee Jones wrote: > > > On Tue, 28 Apr 2020, Guru Das Srinagesh wrote: > > > > > > > The Qualcomm Technologies, Inc. I2C PMIC Controller is used by > > > > multi-function PMIC devices which communicate over the I2C bus. The > > > > controller enumerates all child nodes as platform devices, and > > > > instantiates a regmap interface for them to communicate over the I2C > > > > bus. > > > > > > > > The controller also controls interrupts for all of the children platform > > > > devices. The controller handles the summary interrupt by deciphering > > > > which peripheral triggered the interrupt, and which of the peripheral > > > > interrupts were triggered. Finally, it calls the interrupt handlers for > > > > each of the virtual interrupts that were registered. > > > > > > > > Nicholas Troast is the original author of this driver. > > > > > > > > Signed-off-by: Guru Das Srinagesh <firstname.lastname@example.org> > > > > --- > > > > drivers/mfd/Kconfig | 11 + > > > > drivers/mfd/Makefile | 1 + > > > > drivers/mfd/qcom-i2c-pmic.c | 737 ++++++++++++++++++++++++++++++++++++++++++++ > > > > > > The vast majority of this driver deals with IRQ handling. Why can't > > > this be split out into its own IRQ Chip driver and moved to > > > drivers/irqchip? > > > > There appear to be quite a few in-tree MFD drivers that register IRQ > > controllers, like this driver does: > > > > $ grep --exclude-dir=.git -rnE "irq_domain_(add|create).+\(" drivers/mfd | wc -l > > 23 > > > > As a further example, drivers/mfd/stpmic1.c closely resembles this > > driver in that it uses both devm_regmap_add_irq_chip() as well as > > devm_of_platform_populate(). > > > > As such, it seems like this driver is in line with some of the > > architectural choices that have been accepted in already-merged drivers. > > Could you please elaborate on your concerns? > > It is true that *basic* IRQ domain support has been added to these > drivers in the past. However, IMHO the support added to this driver > goes beyond those realms such that it would justify a driver of its > own. I am exploring an option to see if the regmap-irq APIs may be used in this driver, similar to stpmic1.c. Just to let you know, it might be a few days before I am able to post my next patchset as I'll have to make the necessary changes and test them out first. Thank you. Guru Das.
next prev parent reply other threads:[~2020-05-19 18:57 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-29 0:30 [PATCH v1 0/2] " Guru Das Srinagesh 2020-04-29 0:30 ` [PATCH v1 1/2] dt-bindings: mfd: Document " Guru Das Srinagesh 2020-04-29 7:51 ` Lee Jones 2020-04-29 21:01 ` Rob Herring 2020-04-29 0:30 ` [PATCH v1 2/2] mfd: Introduce " Guru Das Srinagesh 2020-04-29 7:50 ` Lee Jones 2020-05-01 1:13 ` Guru Das Srinagesh 2020-05-01 1:18 ` Joe Perches 2020-05-01 1:28 ` Guru Das Srinagesh 2020-05-15 10:45 ` Lee Jones 2020-05-19 18:57 ` Guru Das Srinagesh [this message] 2020-05-20 6:39 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200519185757.GA13992@codeaurora.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v1 2/2] mfd: Introduce QTI I2C PMIC controller' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).