From: Matt Helsley <mhelsley@vmware.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Julien Thierry <jthierry@redhat.com>,
Miroslav Benes <mbenes@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/3] objtool: Enable compilation of objtool for all architectures
Date: Tue, 19 May 2020 14:46:37 -0700 [thread overview]
Message-ID: <20200519214637.GS9040@rlwimi.vmware.com> (raw)
In-Reply-To: <20200519211829.p2d454nz3h3mdxsa@treble>
On Tue, May 19, 2020 at 04:18:29PM -0500, Josh Poimboeuf wrote:
> On Tue, May 19, 2020 at 01:55:33PM -0700, Matt Helsley wrote:
> > +const char __attribute__ ((weak)) *objname;
> > +
> > +int missing_check(const char *_objname, bool orc)
> > +{
> > + return 127;
> > +}
> > +
> > +int __attribute__ ((weak, alias("missing_check"))) check(const char *_objname, bool orc);
> > +
> > +int missing_orc_dump(const char *_objname)
> > +{
> > + return 127;
> > +}
> > +
> > +int __attribute__ ((weak, alias("missing_orc_dump"))) orc_dump(const char *_objname);
> > +
> > +int __attribute__ ((weak)) create_orc(struct objtool_file *file)
> > +{
> > + return 127;
> > +}
> > +
> > +int __attribute__ ((weak)) create_orc_sections(struct objtool_file *file)
> > +{
> > + return 127;
> > +}
>
> I think the aliased "missing_" functions are no longer needed, right?
> i.e. can we just have weak versions of check() and orc_dump()?
Oops, Yeah, we can remove those aliases. I can fix and resend this one if you
like.
> Otherwise everything looks good to me.
Excellent. I'm thinking I'll get the relocs patches posted as an RFC next...
Cheers,
-Matt
next prev parent reply other threads:[~2020-05-19 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 20:55 [PATCH 0/3] Enable objtool multiarch build Matt Helsley
2020-05-19 20:55 ` [PATCH 1/3] objtool: Exit successfully when requesting help Matt Helsley
2020-05-27 14:44 ` Kamalesh Babulal
2020-05-19 20:55 ` [PATCH 2/3] objtool: Move struct objtool_file into arch-independent header Matt Helsley
2020-05-20 8:04 ` Julien Thierry
2020-05-27 14:43 ` Kamalesh Babulal
2020-05-19 20:55 ` [PATCH 3/3] objtool: Enable compilation of objtool for all architectures Matt Helsley
2020-05-19 21:18 ` Josh Poimboeuf
2020-05-19 21:46 ` Matt Helsley [this message]
2020-05-20 14:16 ` Josh Poimboeuf
2020-05-20 16:38 ` Matt Helsley
2020-05-27 14:42 ` Kamalesh Babulal
2020-05-20 8:31 ` Julien Thierry
2020-05-20 16:41 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519214637.GS9040@rlwimi.vmware.com \
--to=mhelsley@vmware.com \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).