From: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>, Matt Helsley <mhelsley@vmware.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Julien Thierry <jthierry@redhat.com>,
Miroslav Benes <mbenes@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/3] objtool: Enable compilation of objtool for all architectures
Date: Wed, 27 May 2020 20:12:51 +0530 [thread overview]
Message-ID: <c0e767a9-4672-8b1d-c486-374f3f252d44@linux.vnet.ibm.com> (raw)
In-Reply-To: <20200520141604.npsaelrakozqzur6@treble>
[...]
> From: Matt Helsley <mhelsley@vmware.com>
> Subject: [PATCH] objtool: Enable compilation of objtool for all architectures
>
> Objtool currently only compiles for x86 architectures. This is
> fine as it presently does not support tooling for other
> architectures. However, we would like to be able to convert other
> kernel tools to run as objtool sub commands because they too
> process ELF object files. This will allow us to convert tools
> such as recordmcount to use objtool's ELF code.
>
> Since much of recordmcount's ELF code is copy-paste code to/from
> a variety of other kernel tools (look at modpost for example) this
> means that if we can convert recordmcount we can convert more.
>
> We define weak definitions for subcommand entry functions and other weak
> definitions for shared functions critical to building existing
> subcommands. These return 127 when the command is missing which signify
> tools that do not exist on all architectures. In this case the "check"
> and "orc" tools do not exist on all architectures so we only add them
> for x86. Future changes adding support for "check", to arm64 for
> example, can then modify the SUBCMD_CHECK variable when building for
> arm64.
>
> Objtool is not currently wired in to KConfig to be built for other
> architectures because it's not needed for those architectures and
> there are no commands it supports other than those for x86. As more
> command support is enabled on various architectures the necessary
> KConfig changes can be made (e.g. adding "STACK_VALIDATION") to
> trigger building objtool.
>
> [ jpoimboe: remove aliases, add __weak macro, add error messages ]
>
> Cc: Julien Thierry <jthierry@redhat.com>
> Signed-off-by: Matt Helsley <mhelsley@vmware.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
A minor nit-pick in objtool.h
Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
[...]
> diff --git a/tools/objtool/objtool.h b/tools/objtool/objtool.h
> index d89616b2ca39..528028a66816 100644
> --- a/tools/objtool/objtool.h
> +++ b/tools/objtool/objtool.h
> @@ -19,4 +19,9 @@ struct objtool_file {
> bool ignore_unreachables, c_file, hints, rodata;
> };
>
> +int check(const char *objname, bool orc);
> +int orc_dump(const char *objname);
> +int create_orc(struct objtool_file *file);
> +int create_orc_sections(struct objtool_file *file);
> +
> #endif /* _OBJTOOL_H */
above hunk will not apply cleanly on patch 2 of the series, it expects
a new line after struct objtool which is missing in patch 2.
--
Kamalesh
next prev parent reply other threads:[~2020-05-27 14:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 20:55 [PATCH 0/3] Enable objtool multiarch build Matt Helsley
2020-05-19 20:55 ` [PATCH 1/3] objtool: Exit successfully when requesting help Matt Helsley
2020-05-27 14:44 ` Kamalesh Babulal
2020-05-19 20:55 ` [PATCH 2/3] objtool: Move struct objtool_file into arch-independent header Matt Helsley
2020-05-20 8:04 ` Julien Thierry
2020-05-27 14:43 ` Kamalesh Babulal
2020-05-19 20:55 ` [PATCH 3/3] objtool: Enable compilation of objtool for all architectures Matt Helsley
2020-05-19 21:18 ` Josh Poimboeuf
2020-05-19 21:46 ` Matt Helsley
2020-05-20 14:16 ` Josh Poimboeuf
2020-05-20 16:38 ` Matt Helsley
2020-05-27 14:42 ` Kamalesh Babulal [this message]
2020-05-20 8:31 ` Julien Thierry
2020-05-20 16:41 ` Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0e767a9-4672-8b1d-c486-374f3f252d44@linux.vnet.ibm.com \
--to=kamalesh@linux.vnet.ibm.com \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mhelsley@vmware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).