* [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe()
@ 2020-04-15 13:57 Tang Bin
2020-04-15 14:22 ` Uwe Kleine-König
2020-05-22 15:04 ` [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Wolfram Sang
0 siblings, 2 replies; 5+ messages in thread
From: Tang Bin @ 2020-04-15 13:57 UTC (permalink / raw)
To: wsa, o.rempel, u.kleine-koenig, ardb
Cc: linux-i2c, linux-arm-kernel, linux-kernel, Tang Bin, Shengju Zhang
In the function efm32_i2c_probe(),when get irq failed,the function
platform_get_irq() logs an error message,so remove redundant message
here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
---
drivers/i2c/busses/i2c-efm32.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
index a8c6323e7..4de31fae7 100644
--- a/drivers/i2c/busses/i2c-efm32.c
+++ b/drivers/i2c/busses/i2c-efm32.c
@@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev)
ret = platform_get_irq(pdev, 0);
if (ret <= 0) {
- dev_err(&pdev->dev, "failed to get irq (%d)\n", ret);
if (!ret)
ret = -EINVAL;
return ret;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe()
2020-04-15 13:57 [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Tang Bin
@ 2020-04-15 14:22 ` Uwe Kleine-König
2020-04-16 1:12 ` [PATCH] i2c: drivers: Omit superfluous error message inefm32_i2c_probe() Tang Bin
2020-05-22 15:04 ` [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Uwe Kleine-König @ 2020-04-15 14:22 UTC (permalink / raw)
To: Tang Bin
Cc: wsa, o.rempel, ardb, linux-i2c, linux-arm-kernel, linux-kernel,
Shengju Zhang
Hello,
On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote:
> In the function efm32_i2c_probe(),when get irq failed,the function
> platform_get_irq() logs an error message,so remove redundant message
> here.
adding a space after each comma seems usual style.
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Usually the Sign-off of the sender comes last. How is Shengju Zhang
involved with this patch?
> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
> index a8c6323e7..4de31fae7 100644
> --- a/drivers/i2c/busses/i2c-efm32.c
> +++ b/drivers/i2c/busses/i2c-efm32.c
> @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev)
>
> ret = platform_get_irq(pdev, 0);
> if (ret <= 0) {
> - dev_err(&pdev->dev, "failed to get irq (%d)\n", ret);
The change looks fine.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: drivers: Omit superfluous error message inefm32_i2c_probe()
2020-04-15 14:22 ` Uwe Kleine-König
@ 2020-04-16 1:12 ` Tang Bin
0 siblings, 0 replies; 5+ messages in thread
From: Tang Bin @ 2020-04-16 1:12 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: wsa, o.rempel, ardb, linux-i2c, linux-arm-kernel, linux-kernel
Hi Uwe:
On 2020/4/15 22:22, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote:
>> In the function efm32_i2c_probe(),when get irq failed,the function
>> platform_get_irq() logs an error message,so remove redundant message
>> here.
> adding a space after each comma seems usual style.
Got it, I will notice. Whether should I submit v2 for this problems? Thanks.
>
>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
> Usually the Sign-off of the sender comes last. How is Shengju Zhang
> involved with this patch?
Got it, I will notice next time. Thanks.
>> diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c
>> index a8c6323e7..4de31fae7 100644
>> --- a/drivers/i2c/busses/i2c-efm32.c
>> +++ b/drivers/i2c/busses/i2c-efm32.c
>> @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev)
>>
>> ret = platform_get_irq(pdev, 0);
>> if (ret <= 0) {
>> - dev_err(&pdev->dev, "failed to get irq (%d)\n", ret);
> The change looks fine.
Thanks,
Tang Bin
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe()
2020-04-15 13:57 [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Tang Bin
2020-04-15 14:22 ` Uwe Kleine-König
@ 2020-05-22 15:04 ` Wolfram Sang
2020-05-22 15:09 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2020-05-22 15:04 UTC (permalink / raw)
To: Tang Bin
Cc: o.rempel, u.kleine-koenig, ardb, linux-i2c, linux-arm-kernel,
linux-kernel, Shengju Zhang
[-- Attachment #1: Type: text/plain, Size: 422 bytes --]
On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote:
> In the function efm32_i2c_probe(),when get irq failed,the function
> platform_get_irq() logs an error message,so remove redundant message
> here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Applied to for-next, thanks! Please fix the issues Uwe mentioned next
time.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe()
2020-05-22 15:04 ` [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Wolfram Sang
@ 2020-05-22 15:09 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2020-05-22 15:09 UTC (permalink / raw)
To: Tang Bin
Cc: o.rempel, u.kleine-koenig, ardb, linux-i2c, linux-arm-kernel,
linux-kernel, Shengju Zhang
[-- Attachment #1: Type: text/plain, Size: 609 bytes --]
On Fri, May 22, 2020 at 05:04:18PM +0200, Wolfram Sang wrote:
> On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote:
> > In the function efm32_i2c_probe(),when get irq failed,the function
> > platform_get_irq() logs an error message,so remove redundant message
> > here.
> >
> > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> > Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
>
> Applied to for-next, thanks! Please fix the issues Uwe mentioned next
> time.
And try to match the subject line for the subsystem, i.e. for I2C:
"i2c: <drivername>: <topic>"
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-22 15:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-15 13:57 [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Tang Bin
2020-04-15 14:22 ` Uwe Kleine-König
2020-04-16 1:12 ` [PATCH] i2c: drivers: Omit superfluous error message inefm32_i2c_probe() Tang Bin
2020-05-22 15:04 ` [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Wolfram Sang
2020-05-22 15:09 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).