[PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Shuah Khan]

get_maintainer.pl picks only the first email address found in the file.
Reorder my email addresses so it finds my linuxfoundation.org email.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
 MAINTAINERS | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ecc0749810b0..dbad8b18bfe6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4404,8 +4404,8 @@ F:	include/linux/cpuidle.h
 
 CPU POWER MONITORING SUBSYSTEM
 M:	Thomas Renninger <trenn@suse.com>
-M:	Shuah Khan <shuah@kernel.org>
 M:	Shuah Khan <skhan@linuxfoundation.org>
+M:	Shuah Khan <shuah@kernel.org>
 L:	linux-pm@vger.kernel.org
 S:	Maintained
 F:	tools/power/cpupower/
@@ -9238,8 +9238,8 @@ F:	include/uapi/linux/sunrpc/
 F:	net/sunrpc/
 
 KERNEL SELFTEST FRAMEWORK
-M:	Shuah Khan <shuah@kernel.org>
 M:	Shuah Khan <skhan@linuxfoundation.org>
+M:	Shuah Khan <shuah@kernel.org>
 L:	linux-kselftest@vger.kernel.org
 S:	Maintained
 Q:	https://patchwork.kernel.org/project/linux-kselftest/list/
@@ -17484,8 +17484,8 @@ F:	drivers/usb/common/usb-otg-fsm.c
 
 USB OVER IP DRIVER
 M:	Valentina Manea <valentina.manea.m@gmail.com>
-M:	Shuah Khan <shuah@kernel.org>
 M:	Shuah Khan <skhan@linuxfoundation.org>
+M:	Shuah Khan <shuah@kernel.org>
 L:	linux-usb@vger.kernel.org
 S:	Maintained
 F:	Documentation/usb/usbip_protocol.rst
-- 
2.25.1

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Joe Perches]

On Fri, 2020-05-22 at 20:19 -0600, Shuah Khan wrote:
> get_maintainer.pl picks only the first email address found in the file.
> Reorder my email addresses so it finds my linuxfoundation.org email.

OK.

btw:  --noremove-duplicates is also an option.  For instance:

$ ./scripts/get_maintainer.pl -f Documentation/usb/usbip_protocol.rst
Valentina Manea <valentina.manea.m@gmail.com> (maintainer:USB OVER IP DRIVER)
Shuah Khan <shuah@kernel.org> (maintainer:USB OVER IP DRIVER)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM)
Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
linux-usb@vger.kernel.org (open list:USB OVER IP DRIVER)
linux-doc@vger.kernel.org (open list:DOCUMENTATION)
linux-kernel@vger.kernel.org (open list)

vs:

$ ./scripts/get_maintainer.pl --noremove-duplicates -f Documentation/usb/usbip_protocol.rst
Valentina Manea <valentina.manea.m@gmail.com> (maintainer:USB OVER IP DRIVER)
Shuah Khan <shuah@kernel.org> (maintainer:USB OVER IP DRIVER)
Shuah Khan <skhan@linuxfoundation.org> (maintainer:USB OVER IP DRIVER)
Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM)
Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
linux-usb@vger.kernel.org (open list:USB OVER IP DRIVER)
linux-doc@vger.kernel.org (open list:DOCUMENTATION)
linux-kernel@vger.kernel.org (open list)

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Shuah Khan]

On 5/22/20 8:26 PM, Joe Perches wrote:
> On Fri, 2020-05-22 at 20:19 -0600, Shuah Khan wrote:
>> get_maintainer.pl picks only the first email address found in the file.
>> Reorder my email addresses so it finds my linuxfoundation.org email.
> 
> OK.
> 
> btw:  --noremove-duplicates is also an option.  For instance:
> 
> $ ./scripts/get_maintainer.pl -f Documentation/usb/usbip_protocol.rst
> Valentina Manea <valentina.manea.m@gmail.com> (maintainer:USB OVER IP DRIVER)
> Shuah Khan <shuah@kernel.org> (maintainer:USB OVER IP DRIVER)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM)
> Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
> linux-usb@vger.kernel.org (open list:USB OVER IP DRIVER)
> linux-doc@vger.kernel.org (open list:DOCUMENTATION)
> linux-kernel@vger.kernel.org (open list)
> 
> vs:
> 
> $ ./scripts/get_maintainer.pl --noremove-duplicates -f Documentation/usb/usbip_protocol.rst
> Valentina Manea <valentina.manea.m@gmail.com> (maintainer:USB OVER IP DRIVER)
> Shuah Khan <shuah@kernel.org> (maintainer:USB OVER IP DRIVER)
> Shuah Khan <skhan@linuxfoundation.org> (maintainer:USB OVER IP DRIVER)
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> (supporter:USB SUBSYSTEM)
> Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
> linux-usb@vger.kernel.org (open list:USB OVER IP DRIVER)
> linux-doc@vger.kernel.org (open list:DOCUMENTATION)
> linux-kernel@vger.kernel.org (open list)
> 

Sadly, people that don't run get_maintainer.pl, leave alone running it
with --noremove-duplicates option. So your suggestion doesn't really
help me.

My preference is to get patches to both Inboxes if possible which isn't
possible unless -noremove-duplicate is default. Having this option as
default probably will annoy lot of people . So I am not asking for
that.

That being said, I don't understand your comment. Are you recommending
using just one email in these entries?

thanks,
-- Shuah

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Joe Perches]

On Tue, 2020-05-26 at 11:04 -0600, Shuah Khan wrote:
> On 5/22/20 8:26 PM, Joe Perches wrote:
> > On Fri, 2020-05-22 at 20:19 -0600, Shuah Khan wrote:
> > > get_maintainer.pl picks only the first email address found in the file.
> > > Reorder my email addresses so it finds my linuxfoundation.org email.
> > 
> > OK.
[]
> Sadly, people that don't run get_maintainer.pl, leave alone running it
> with --noremove-duplicates option. So your suggestion doesn't really
> help me.
> 
> My preference is to get patches to both Inboxes if possible which isn't
> possible unless -noremove-duplicate is default. Having this option as
> default probably will annoy lot of people . So I am not asking for
> that.
> 
> That being said, I don't understand your comment. Are you recommending
> using just one email in these entries?

Yes.  And maybe set an autoforward rule in that email to
forward the received email to your other address.

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Shuah Khan]

On 5/26/20 4:27 PM, Joe Perches wrote:
> On Tue, 2020-05-26 at 11:04 -0600, Shuah Khan wrote:
>> On 5/22/20 8:26 PM, Joe Perches wrote:
>>> On Fri, 2020-05-22 at 20:19 -0600, Shuah Khan wrote:
>>>> get_maintainer.pl picks only the first email address found in the file.
>>>> Reorder my email addresses so it finds my linuxfoundation.org email.
>>>
>>> OK.
> []
>> Sadly, people that don't run get_maintainer.pl, leave alone running it
>> with --noremove-duplicates option. So your suggestion doesn't really
>> help me.
>>
>> My preference is to get patches to both Inboxes if possible which isn't
>> possible unless -noremove-duplicate is default. Having this option as
>> default probably will annoy lot of people . So I am not asking for
>> that.
>>
>> That being said, I don't understand your comment. Are you recommending
>> using just one email in these entries?
> 
> Yes.  And maybe set an autoforward rule in that email to
> forward the received email to your other address.
> 
> 
Sounds good.

thanks,
-- Shuah

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Joe Perches]

On Tue, 2020-05-26 at 16:54 -0600, Shuah Khan wrote:
> On 5/26/20 4:27 PM, Joe Perches wrote:
> > On Tue, 2020-05-26 at 11:04 -0600, Shuah Khan wrote:
> > > On 5/22/20 8:26 PM, Joe Perches wrote:
> > > > On Fri, 2020-05-22 at 20:19 -0600, Shuah Khan wrote:
> > > > > get_maintainer.pl picks only the first email address found in the file.
> > > > > Reorder my email addresses so it finds my linuxfoundation.org email.
> > > > 
> > > > OK.
> > []
> > > Sadly, people that don't run get_maintainer.pl, leave alone running it
> > > with --noremove-duplicates option. So your suggestion doesn't really
> > > help me.
> > > 
> > > My preference is to get patches to both Inboxes if possible which isn't
> > > possible unless -noremove-duplicate is default. Having this option as
> > > default probably will annoy lot of people . So I am not asking for
> > > that.
> > > 
> > > That being said, I don't understand your comment. Are you recommending
> > > using just one email in these entries?
> > 
> > Yes.  And maybe set an autoforward rule in that email to
> > forward the received email to your other address.
> > 
> > 
> Sounds good.

Another option would be to write your name
slightly differently in the 2 entries.

For instance, add "(LF)" to the linuxfoundation.org entry like:

CPU POWER MONITORING SUBSYSTEM
M:	Thomas Renninger <trenn@suse.com>
M:	Shuah Khan <shuah@kernel.org>
M:	Shuah Khan (LF) <skhan@linuxfoundation.org>
L:	linux-pm@vger.kernel.org
S:	Maintained
F:	tools/power/cpupower/

and then the get_maintainer.pl script won't
collapse the equally named but with different
email addresses into a single entry:

$ ./scripts/get_maintainer.pl -f tools/power/cpupower/
Thomas Renninger <trenn@suse.com> (maintainer:CPU POWER MONITORING SUBSYSTEM)
Shuah Khan <shuah@kernel.org> (maintainer:CPU POWER MONITORING SUBSYSTEM)
"Shuah Khan (LF)" <skhan@linuxfoundation.org> (maintainer:CPU POWER MONITORING SUBSYSTEM)
linux-pm@vger.kernel.org (open list:CPU POWER MONITORING SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Shuah Khan]

On 5/26/20 5:33 PM, Joe Perches wrote:
> On Tue, 2020-05-26 at 16:54 -0600, Shuah Khan wrote:
>> On 5/26/20 4:27 PM, Joe Perches wrote:
>>> On Tue, 2020-05-26 at 11:04 -0600, Shuah Khan wrote:
>>>> On 5/22/20 8:26 PM, Joe Perches wrote:
>>>>> On Fri, 2020-05-22 at 20:19 -0600, Shuah Khan wrote:
>>>>>> get_maintainer.pl picks only the first email address found in the file.
>>>>>> Reorder my email addresses so it finds my linuxfoundation.org email.
>>>>>
>>>>> OK.
>>> []
>>>> Sadly, people that don't run get_maintainer.pl, leave alone running it
>>>> with --noremove-duplicates option. So your suggestion doesn't really
>>>> help me.
>>>>
>>>> My preference is to get patches to both Inboxes if possible which isn't
>>>> possible unless -noremove-duplicate is default. Having this option as
>>>> default probably will annoy lot of people . So I am not asking for
>>>> that.
>>>>
>>>> That being said, I don't understand your comment. Are you recommending
>>>> using just one email in these entries?
>>>
>>> Yes.  And maybe set an autoforward rule in that email to
>>> forward the received email to your other address.
>>>
>>>
>> Sounds good.
> 
> Another option would be to write your name
> slightly differently in the 2 entries.
> 
> For instance, add "(LF)" to the linuxfoundation.org entry like:
> 
> CPU POWER MONITORING SUBSYSTEM
> M:	Thomas Renninger <trenn@suse.com>
> M:	Shuah Khan <shuah@kernel.org>
> M:	Shuah Khan (LF) <skhan@linuxfoundation.org>
> L:	linux-pm@vger.kernel.org
> S:	Maintained
> F:	tools/power/cpupower/
> 
> and then the get_maintainer.pl script won't
> collapse the equally named but with different
> email addresses into a single entry:
> 

I like this option.
> $ ./scripts/get_maintainer.pl -f tools/power/cpupower/
> Thomas Renninger <trenn@suse.com> (maintainer:CPU POWER MONITORING SUBSYSTEM)
> Shuah Khan <shuah@kernel.org> (maintainer:CPU POWER MONITORING SUBSYSTEM)
> "Shuah Khan (LF)" <skhan@linuxfoundation.org> (maintainer:CPU POWER MONITORING SUBSYSTEM)
> linux-pm@vger.kernel.org (open list:CPU POWER MONITORING SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)
> 

Thanks for the idea. I will rework the patch and send it.

thanks,
-- Shuah

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Mauro Carvalho Chehab]

Hi Shuah,

Em Fri, 22 May 2020 20:19:28 -0600
Shuah Khan <skhan@linuxfoundation.org> escreveu:

> get_maintainer.pl picks only the first email address found in the file.
> Reorder my email addresses so it finds my linuxfoundation.org email.

Next time someone would run the ordering script again, this patch
would need to be re-applied.

Instead, why don't you just use a single e-mail at the maintainer's
entry and place the other one at the .mailmap file?

> 
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
>  MAINTAINERS | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ecc0749810b0..dbad8b18bfe6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4404,8 +4404,8 @@ F:	include/linux/cpuidle.h
>  
>  CPU POWER MONITORING SUBSYSTEM
>  M:	Thomas Renninger <trenn@suse.com>
> -M:	Shuah Khan <shuah@kernel.org>
>  M:	Shuah Khan <skhan@linuxfoundation.org>
> +M:	Shuah Khan <shuah@kernel.org>
>  L:	linux-pm@vger.kernel.org
>  S:	Maintained
>  F:	tools/power/cpupower/
> @@ -9238,8 +9238,8 @@ F:	include/uapi/linux/sunrpc/
>  F:	net/sunrpc/
>  
>  KERNEL SELFTEST FRAMEWORK
> -M:	Shuah Khan <shuah@kernel.org>
>  M:	Shuah Khan <skhan@linuxfoundation.org>
> +M:	Shuah Khan <shuah@kernel.org>
>  L:	linux-kselftest@vger.kernel.org
>  S:	Maintained
>  Q:	https://patchwork.kernel.org/project/linux-kselftest/list/
> @@ -17484,8 +17484,8 @@ F:	drivers/usb/common/usb-otg-fsm.c
>  
>  USB OVER IP DRIVER
>  M:	Valentina Manea <valentina.manea.m@gmail.com>
> -M:	Shuah Khan <shuah@kernel.org>
>  M:	Shuah Khan <skhan@linuxfoundation.org>
> +M:	Shuah Khan <shuah@kernel.org>
>  L:	linux-usb@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/usb/usbip_protocol.rst



Thanks,
Mauro

Re: [PATCH] MAINTAINERS: Update my maintainer entries to reorder email addresses

[Joe Perches]

On Sat, 2020-05-23 at 07:57 +0200, Mauro Carvalho Chehab wrote:
> Hi Shuah,
> 
> Em Fri, 22 May 2020 20:19:28 -0600
> Shuah Khan <skhan@linuxfoundation.org> escreveu:
> 
> > get_maintainer.pl picks only the first email address found in the file.
> > Reorder my email addresses so it finds my linuxfoundation.org email.
> 
> Next time someone would run the ordering script again, this patch
> would need to be re-applied.

Not so.
Reordering does not change maintainer emails entries.
Reordering only happens to file patterns.