From: Wei Yang <richard.weiyang@gmail.com>
To: akpm@linux-foundation.org, andriy.shevchenko@linux.intel.com,
christian.brauner@ubuntu.com
Cc: linux-kernel@vger.kernel.org, Wei Yang <richard.weiyang@gmail.com>
Subject: [PATCH] bitops: simplify get_count_order_long()
Date: Sun, 24 May 2020 12:35:51 +0000 [thread overview]
Message-ID: <20200524123551.9469-1-richard.weiyang@gmail.com> (raw)
These two cases could be unified into one.
Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
---
include/linux/bitops.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/include/linux/bitops.h b/include/linux/bitops.h
index 9acf654f0b19..5b5609e81a84 100644
--- a/include/linux/bitops.h
+++ b/include/linux/bitops.h
@@ -206,10 +206,7 @@ static inline int get_count_order_long(unsigned long l)
{
if (l == 0UL)
return -1;
- else if (l & (l - 1UL))
- return (int)fls_long(l);
- else
- return (int)fls_long(l) - 1;
+ return (int)fls_long(--l);
}
/**
--
2.23.0
next reply other threads:[~2020-05-24 12:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 12:35 Wei Yang [this message]
2020-05-25 9:14 ` [PATCH] bitops: simplify get_count_order_long() Andy Shevchenko
2020-05-25 14:43 ` Wei Yang
2020-05-25 15:32 ` Andy Shevchenko
2020-05-25 20:41 ` Andrew Morton
2020-05-25 21:57 ` Wei Yang
2020-05-25 22:31 ` Andrew Morton
2020-05-27 22:45 ` Wei Yang
2020-05-27 23:05 ` Andrew Morton
2020-05-28 22:18 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200524123551.9469-1-richard.weiyang@gmail.com \
--to=richard.weiyang@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.brauner@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).