From: Andrew Morton <akpm@linux-foundation.org>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
christian.brauner@ubuntu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: simplify get_count_order_long()
Date: Wed, 27 May 2020 16:05:08 -0700 [thread overview]
Message-ID: <20200527160508.2ef29d6904c07ca6c650638c@linux-foundation.org> (raw)
In-Reply-To: <20200527224542.yx45druzqtlaxrl7@master>
On Wed, 27 May 2020 22:45:42 +0000 Wei Yang <richard.weiyang@gmail.com> wrote:
> /* a tiny module only meant to test get_count_order/long */
> unsigned int order_comb[][2] = {
> {0x00000003, 2},
> {0x00000004, 2},
> {0x00001fff, 13},
> {0x00002000, 13},
> {0x50000000, 32},
> {0x80000000, 32},
> };
>
> static int __init test_getorder_startup(void)
> {
> int i;
>
> for (i = 0; i < ARRAY_SIZE(order_comb); i++) {
> if (order_comb[i][1] != get_count_order(order_comb[i][0]))
> pr_warn("get_count_order wrong for %lx\n",
> order_comb[i][0]);
> }
>
> return 0;
> }
>
> Since I don't get a way to iterate all the possibilities, some random
> combination is chosen. Is this one looks good?
Looks good.
You might want to add a less-negative number as well? 0x80030000.
Something that won't turn positive if it has 1 subtracted from it.
next prev parent reply other threads:[~2020-05-27 23:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-24 12:35 [PATCH] bitops: simplify get_count_order_long() Wei Yang
2020-05-25 9:14 ` Andy Shevchenko
2020-05-25 14:43 ` Wei Yang
2020-05-25 15:32 ` Andy Shevchenko
2020-05-25 20:41 ` Andrew Morton
2020-05-25 21:57 ` Wei Yang
2020-05-25 22:31 ` Andrew Morton
2020-05-27 22:45 ` Wei Yang
2020-05-27 23:05 ` Andrew Morton [this message]
2020-05-28 22:18 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527160508.2ef29d6904c07ca6c650638c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=christian.brauner@ubuntu.com \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).